Re: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs
Date	2015-11-11 23:50 +0100
Message-ID	<qtMnf-s4-3@gated-at.bofh.it> (permalink)
References	<qoE6Z-6pV-3@gated-at.bofh.it> <qoE70-6pV-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Oct 28, 2015 at 7:54 PM, Matias Bjørling <m@bjorling.me> wrote:
> +struct nvm_dev_ops {

[...]

> +       uint8_t                 max_phys_sect;
> +};

> --- /dev/null
> +++ b/drivers/lightnvm/core.c

> +int nvm_register(struct request_queue *q, char *disk_name,
> +                                                       struct nvm_dev_ops *ops)
> +{

[...]

> +       } else if (dev->ops->max_phys_sect > 256) {

drivers/nfc/nfcmrvl/i2c.c:52: warning: comparison is always false due
to limited range of data type

Indeed, max_phys_sect is "uint8_t", so its maximum value is 255.

> +               pr_info("nvm: max sectors supported is 256.\n");

Hence this message is not correct. What's the intended maximum value?
255 or 256?

> +               return -EINVAL;
> +       }

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-11 23:50 +0100
  Re: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-11 23:50 +0100
  Re: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs Matias Bjørling <m@bjorling.me> - 2015-11-12 11:10 +0100

csiph-web