Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1267027 > unrolled thread
| Started by | Lu Baolu <baolu.lu@linux.intel.com> |
|---|---|
| First post | 2015-11-11 09:10 +0100 |
| Last post | 2015-11-12 03:20 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device Lu Baolu <baolu.lu@linux.intel.com> - 2015-11-11 09:10 +0100
Re: [PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device kbuild test robot <lkp@intel.com> - 2015-11-11 10:50 +0100
Re: [PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device Alan Stern <stern@rowland.harvard.edu> - 2015-11-11 16:20 +0100
Re: [PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device "Lu, Baolu" <baolu.lu@linux.intel.com> - 2015-11-12 03:20 +0100
| From | Lu Baolu <baolu.lu@linux.intel.com> |
|---|---|
| Date | 2015-11-11 09:10 +0100 |
| Subject | [PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device |
| Message-ID | <qtyDE-b1-15@gated-at.bofh.it> |
Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.")
adds usb3_lpm_enabled member to struct usb_device. There is no reference
to this member now. Hence, it could be removed.
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
include/linux/usb.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/usb.h b/include/linux/usb.h
index 211664f..036e4a5 100644
--- a/include/linux/usb.h
+++ b/include/linux/usb.h
@@ -583,7 +583,6 @@ struct usb_device {
unsigned usb2_hw_lpm_besl_capable:1;
unsigned usb2_hw_lpm_enabled:1;
unsigned usb2_hw_lpm_allowed:1;
- unsigned usb3_lpm_enabled:1;
unsigned usb3_lpm_u1_enabled:1;
unsigned usb3_lpm_u2_enabled:1;
int string_langid;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | kbuild test robot <lkp@intel.com> |
|---|---|
| Date | 2015-11-11 10:50 +0100 |
| Message-ID | <qtAcp-11f-5@gated-at.bofh.it> |
| In reply to | #1267027 |
[Multipart message — attachments visible in raw view] — view raw
Hi Lu,
[auto build test WARNING on v4.3-rc7]
[also build test WARNING on next-20151111]
url: https://github.com/0day-ci/linux/commits/Lu-Baolu/usb-core-lpm-add-sysfs-node-for-usb3-lpm-permit/20151111-160805
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
include/linux/usb.h:614: warning: No description found for parameter 'usb3_lpm_u1_enabled'
include/linux/usb.h:614: warning: No description found for parameter 'usb3_lpm_u2_enabled'
>> include/linux/usb.h:614: warning: Excess struct/union/enum/typedef member 'usb3_lpm_enabled' description in 'usb_device'
vim +614 include/linux/usb.h
f476fbab Randy Dunlap 2008-02-13 598 unsigned long active_duration;
15123006 Sarah Sharp 2007-12-21 599
645daaab Alan Stern 2006-08-30 600 #ifdef CONFIG_PM
f476fbab Randy Dunlap 2008-02-13 601 unsigned long connect_time;
f476fbab Randy Dunlap 2008-02-13 602
f476fbab Randy Dunlap 2008-02-13 603 unsigned do_remote_wakeup:1;
f476fbab Randy Dunlap 2008-02-13 604 unsigned reset_resume:1;
bfd1e910 Alan Stern 2012-10-19 605 unsigned port_is_suspended:1;
645daaab Alan Stern 2006-08-30 606 #endif
b1d8dfb0 Inaky Perez-Gonzalez 2008-04-08 607 struct wusb_dev *wusb_dev;
c6515272 Sarah Sharp 2009-04-27 608 int slot_id;
0846e7e9 Matthew Garrett 2012-02-03 609 enum usb_device_removable removable;
17f34867 Mathias Nyman 2013-05-23 610 struct usb2_lpm_parameters l1_params;
51e0a012 Sarah Sharp 2012-02-20 611 struct usb3_lpm_parameters u1_params;
51e0a012 Sarah Sharp 2012-02-20 612 struct usb3_lpm_parameters u2_params;
1ea7e0e8 Sarah Sharp 2012-04-24 613 unsigned lpm_disable_count;
^1da177e Linus Torvalds 2005-04-16 @614 };
^1da177e Linus Torvalds 2005-04-16 615 #define to_usb_device(d) container_of(d, struct usb_device, dev)
^1da177e Linus Torvalds 2005-04-16 616
1e429018 Matthew Wilcox 2010-04-30 617 static inline struct usb_device *interface_to_usbdev(struct usb_interface *intf)
1e429018 Matthew Wilcox 2010-04-30 618 {
1e429018 Matthew Wilcox 2010-04-30 619 return to_usb_device(intf->dev.parent);
1e429018 Matthew Wilcox 2010-04-30 620 }
1e429018 Matthew Wilcox 2010-04-30 621
^1da177e Linus Torvalds 2005-04-16 622 extern struct usb_device *usb_get_dev(struct usb_device *dev);
:::::: The code at line 614 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[toc] | [prev] | [next] | [standalone]
| From | Alan Stern <stern@rowland.harvard.edu> |
|---|---|
| Date | 2015-11-11 16:20 +0100 |
| Message-ID | <qtFlM-4tA-13@gated-at.bofh.it> |
| In reply to | #1267027 |
On Wed, 11 Nov 2015, Lu Baolu wrote:
> Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.")
> adds usb3_lpm_enabled member to struct usb_device. There is no reference
> to this member now. Hence, it could be removed.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> include/linux/usb.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/usb.h b/include/linux/usb.h
> index 211664f..036e4a5 100644
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -583,7 +583,6 @@ struct usb_device {
> unsigned usb2_hw_lpm_besl_capable:1;
> unsigned usb2_hw_lpm_enabled:1;
> unsigned usb2_hw_lpm_allowed:1;
> - unsigned usb3_lpm_enabled:1;
> unsigned usb3_lpm_u1_enabled:1;
> unsigned usb3_lpm_u2_enabled:1;
> int string_langid;
You forgot to remove the kerneldoc for this field. And you forgot to
add kerneldoc for usb3_lpm_u[12]_enabled.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Lu, Baolu" <baolu.lu@linux.intel.com> |
|---|---|
| Date | 2015-11-12 03:20 +0100 |
| Message-ID | <qtPEu-2Lj-9@gated-at.bofh.it> |
| In reply to | #1267241 |
On 11/11/2015 11:10 PM, Alan Stern wrote:
> On Wed, 11 Nov 2015, Lu Baolu wrote:
>
>> Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.")
>> adds usb3_lpm_enabled member to struct usb_device. There is no reference
>> to this member now. Hence, it could be removed.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> ---
>> include/linux/usb.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/include/linux/usb.h b/include/linux/usb.h
>> index 211664f..036e4a5 100644
>> --- a/include/linux/usb.h
>> +++ b/include/linux/usb.h
>> @@ -583,7 +583,6 @@ struct usb_device {
>> unsigned usb2_hw_lpm_besl_capable:1;
>> unsigned usb2_hw_lpm_enabled:1;
>> unsigned usb2_hw_lpm_allowed:1;
>> - unsigned usb3_lpm_enabled:1;
>> unsigned usb3_lpm_u1_enabled:1;
>> unsigned usb3_lpm_u2_enabled:1;
>> int string_langid;
> You forgot to remove the kerneldoc for this field. And you forgot to
> add kerneldoc for usb3_lpm_u[12]_enabled.
Yes. I will fix this in v2.
>
> Alan Stern
Thanks,
Baolu
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web