Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1267241

Re: [PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device

Show all headers | View raw

On Wed, 11 Nov 2015, Lu Baolu wrote:

> Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.")
> adds usb3_lpm_enabled member to struct usb_device. There is no reference
> to this member now. Hence, it could be removed.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>  include/linux/usb.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/usb.h b/include/linux/usb.h
> index 211664f..036e4a5 100644
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -583,7 +583,6 @@ struct usb_device {
>  	unsigned usb2_hw_lpm_besl_capable:1;
>  	unsigned usb2_hw_lpm_enabled:1;
>  	unsigned usb2_hw_lpm_allowed:1;
> -	unsigned usb3_lpm_enabled:1;
>  	unsigned usb3_lpm_u1_enabled:1;
>  	unsigned usb3_lpm_u2_enabled:1;
>  	int string_langid;

You forgot to remove the kerneldoc for this field.  And you forgot to 
add kerneldoc for usb3_lpm_u[12]_enabled.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device Lu Baolu <baolu.lu@linux.intel.com> - 2015-11-11 09:10 +0100
  Re: [PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device kbuild test robot <lkp@intel.com> - 2015-11-11 10:50 +0100
  Re: [PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device Alan Stern <stern@rowland.harvard.edu> - 2015-11-11 16:20 +0100
    Re: [PATCH 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device "Lu, Baolu" <baolu.lu@linux.intel.com> - 2015-11-12 03:20 +0100

csiph-web