Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1265900 > unrolled thread
| Started by | Ranjith T <ranjithece24@gmail.com> |
|---|---|
| First post | 2015-11-09 18:50 +0100 |
| Last post | 2015-11-11 15:20 +0100 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ranjith T <ranjithece24@gmail.com> - 2015-11-09 18:50 +0100
Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ranjith T <ranjithece24@gmail.com> - 2015-11-11 14:50 +0100
Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ranjith T <ranjithece24@gmail.com> - 2015-11-11 15:20 +0100
Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ian Abbott <abbotti@mev.co.uk> - 2015-11-11 15:40 +0100
Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ian Abbott <abbotti@mev.co.uk> - 2015-11-11 15:20 +0100
| From | Ranjith T <ranjithece24@gmail.com> |
|---|---|
| Date | 2015-11-09 18:50 +0100 |
| Subject | [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro |
| Message-ID | <qsYJP-15E-5@gated-at.bofh.it> |
BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith T <ranjithece24@gmail.com> --- drivers/staging/comedi/drivers/comedi_parport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c index 15a4093..1bf8ddc 100644 --- a/drivers/staging/comedi/drivers/comedi_parport.c +++ b/drivers/staging/comedi/drivers/comedi_parport.c @@ -75,8 +75,8 @@ #define PARPORT_DATA_REG 0x00 #define PARPORT_STATUS_REG 0x01 #define PARPORT_CTRL_REG 0x02 -#define PARPORT_CTRL_IRQ_ENA (1 << 4) -#define PARPORT_CTRL_BIDIR_ENA (1 << 5) +#define PARPORT_CTRL_IRQ_ENA BIT(4) +#define PARPORT_CTRL_BIDIR_ENA BIT(5) static int parport_data_reg_insn_bits(struct comedi_device *dev, struct comedi_subdevice *s, -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Ranjith T <ranjithece24@gmail.com> |
|---|---|
| Date | 2015-11-11 14:50 +0100 |
| Message-ID | <qtDWG-3rN-1@gated-at.bofh.it> |
| In reply to | #1265900 |
Is this patch is fine?. Thanks, Ranjith T. On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <ranjithece24@gmail.com> wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith T <ranjithece24@gmail.com> > --- > drivers/staging/comedi/drivers/comedi_parport.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c > index 15a4093..1bf8ddc 100644 > --- a/drivers/staging/comedi/drivers/comedi_parport.c > +++ b/drivers/staging/comedi/drivers/comedi_parport.c > @@ -75,8 +75,8 @@ > #define PARPORT_DATA_REG 0x00 > #define PARPORT_STATUS_REG 0x01 > #define PARPORT_CTRL_REG 0x02 > -#define PARPORT_CTRL_IRQ_ENA (1 << 4) > -#define PARPORT_CTRL_BIDIR_ENA (1 << 5) > +#define PARPORT_CTRL_IRQ_ENA BIT(4) > +#define PARPORT_CTRL_BIDIR_ENA BIT(5) > > static int parport_data_reg_insn_bits(struct comedi_device *dev, > struct comedi_subdevice *s, > -- > 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ranjith T <ranjithece24@gmail.com> |
|---|---|
| Date | 2015-11-11 15:20 +0100 |
| Message-ID | <qtEpH-3Sx-1@gated-at.bofh.it> |
| In reply to | #1267191 |
Actually my name is Ranjith and father name is Thangavel. So I used to mention my name as Ranjith T. Thanks, Ranjith T On Wed, Nov 11, 2015 at 7:41 PM, Ian Abbott <abbotti@mev.co.uk> wrote: > On 11/11/2015 13:44, Ranjith T wrote: >> >> Is this patch is fine?. >> >> Thanks, >> Ranjith T. > > > Fine apart from the "Signed-off-by" line. I'm guessing your last name isn't > really "T". > > >> On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <ranjithece24@gmail.com> wrote: >>> >>> BIT macro is used for defining BIT location instead of >>> shifting operator - coding style issue >>> >>> Signed-off-by: Ranjith T <ranjithece24@gmail.com> >>> --- >>> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c >>> b/drivers/staging/comedi/drivers/comedi_parport.c >>> index 15a4093..1bf8ddc 100644 >>> --- a/drivers/staging/comedi/drivers/comedi_parport.c >>> +++ b/drivers/staging/comedi/drivers/comedi_parport.c >>> @@ -75,8 +75,8 @@ >>> #define PARPORT_DATA_REG 0x00 >>> #define PARPORT_STATUS_REG 0x01 >>> #define PARPORT_CTRL_REG 0x02 >>> -#define PARPORT_CTRL_IRQ_ENA (1 << 4) >>> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5) >>> +#define PARPORT_CTRL_IRQ_ENA BIT(4) >>> +#define PARPORT_CTRL_BIDIR_ENA BIT(5) >>> >>> static int parport_data_reg_insn_bits(struct comedi_device *dev, >>> struct comedi_subdevice *s, >>> -- >>> 1.7.10.4 > > > -- > -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- > -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ian Abbott <abbotti@mev.co.uk> |
|---|---|
| Date | 2015-11-11 15:40 +0100 |
| Message-ID | <qtEJ4-3Zk-5@gated-at.bofh.it> |
| In reply to | #1267210 |
On 11/11/15 14:18, Ranjith T wrote: > Actually my name is Ranjith and father name is Thangavel. So I used to > mention my name as Ranjith T. How do you write your name on legal documents? That is what you should use on the patch's "Signed-off-by:" line, and on the email's "From:" line. Thanks. -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ian Abbott <abbotti@mev.co.uk> |
|---|---|
| Date | 2015-11-11 15:20 +0100 |
| Message-ID | <qtEpH-3Sx-3@gated-at.bofh.it> |
| In reply to | #1267191 |
On 11/11/2015 13:44, Ranjith T wrote: > Is this patch is fine?. > > Thanks, > Ranjith T. Fine apart from the "Signed-off-by" line. I'm guessing your last name isn't really "T". > On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <ranjithece24@gmail.com> wrote: >> BIT macro is used for defining BIT location instead of >> shifting operator - coding style issue >> >> Signed-off-by: Ranjith T <ranjithece24@gmail.com> >> --- >> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c >> index 15a4093..1bf8ddc 100644 >> --- a/drivers/staging/comedi/drivers/comedi_parport.c >> +++ b/drivers/staging/comedi/drivers/comedi_parport.c >> @@ -75,8 +75,8 @@ >> #define PARPORT_DATA_REG 0x00 >> #define PARPORT_STATUS_REG 0x01 >> #define PARPORT_CTRL_REG 0x02 >> -#define PARPORT_CTRL_IRQ_ENA (1 << 4) >> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5) >> +#define PARPORT_CTRL_IRQ_ENA BIT(4) >> +#define PARPORT_CTRL_BIDIR_ENA BIT(5) >> >> static int parport_data_reg_insn_bits(struct comedi_device *dev, >> struct comedi_subdevice *s, >> -- >> 1.7.10.4 -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web