Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

From	Ian Abbott <abbotti@mev.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro
Date	2015-11-11 15:20 +0100
Message-ID	<qtEpH-3Sx-3@gated-at.bofh.it> (permalink)
References	<qsYJP-15E-5@gated-at.bofh.it> <qtDWG-3rN-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/11/2015 13:44, Ranjith T wrote:
> Is this patch is fine?.
>
> Thanks,
> Ranjith T.

Fine apart from the "Signed-off-by" line.  I'm guessing your last name 
isn't really "T".

> On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <ranjithece24@gmail.com> wrote:
>> BIT macro is used for defining BIT location instead of
>> shifting operator - coding style issue
>>
>> Signed-off-by: Ranjith T <ranjithece24@gmail.com>
>> ---
>>   drivers/staging/comedi/drivers/comedi_parport.c |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
>> index 15a4093..1bf8ddc 100644
>> --- a/drivers/staging/comedi/drivers/comedi_parport.c
>> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
>> @@ -75,8 +75,8 @@
>>   #define PARPORT_DATA_REG       0x00
>>   #define PARPORT_STATUS_REG     0x01
>>   #define PARPORT_CTRL_REG       0x02
>> -#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
>> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
>> +#define PARPORT_CTRL_IRQ_ENA   BIT(4)
>> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>>
>>   static int parport_data_reg_insn_bits(struct comedi_device *dev,
>>                                        struct comedi_subdevice *s,
>> --
>> 1.7.10.4

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ranjith T <ranjithece24@gmail.com> - 2015-11-09 18:50 +0100
  Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ranjith T <ranjithece24@gmail.com> - 2015-11-11 14:50 +0100
    Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ranjith T <ranjithece24@gmail.com> - 2015-11-11 15:20 +0100
      Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ian Abbott <abbotti@mev.co.uk> - 2015-11-11 15:40 +0100
    Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro Ian Abbott <abbotti@mev.co.uk> - 2015-11-11 15:20 +0100

csiph-web