Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1264011 > unrolled thread

[PATCH] x86/setup: fix low identity map for >= 2GB kernel range

Started byKrzysztof Mazur <krzysiek@podlesie.net>
First post2015-11-06 14:30 +0100
Last post2015-11-07 10:50 +0100
Articles 6 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] x86/setup: fix low identity map for >= 2GB kernel range Krzysztof Mazur <krzysiek@podlesie.net> - 2015-11-06 14:30 +0100
    Re: [PATCH] x86/setup: fix low identity map for >= 2GB kernel range Borislav Petkov <bp@alien8.de> - 2015-11-06 14:30 +0100
      Re: [PATCH] x86/setup: fix low identity map for >= 2GB kernel range Krzysztof Mazur <krzysiek@podlesie.net> - 2015-11-06 15:20 +0100
        Re: [PATCH] x86/setup: fix low identity map for >= 2GB kernel range Paolo Bonzini <pbonzini@redhat.com> - 2015-11-06 16:10 +0100
        Re: [PATCH] x86/setup: fix low identity map for >= 2GB kernel range Matt Fleming <matt@codeblueprint.co.uk> - 2015-11-07 10:50 +0100
    [tip:x86/urgent] x86/setup: Fix low identity map for >=   2GB kernel range tip-bot for Krzysztof Mazur <tipbot@zytor.com> - 2015-11-07 10:50 +0100

#1264011 — [PATCH] x86/setup: fix low identity map for >= 2GB kernel range

FromKrzysztof Mazur <krzysiek@podlesie.net>
Date2015-11-06 14:30 +0100
Subject[PATCH] x86/setup: fix low identity map for >= 2GB kernel range
Message-ID<qrPfC-52O-35@gated-at.bofh.it>
The commit f5f3497cad8c8416a74b9aaceb127908755d020a (x86/setup: Extend
low identity map to cover whole kernel range) extended the low identity
mapping. However, if the kernel uses more than 2 GB (VMSPLIT_2G_OPT or
VMSPLIT_1G memory split), the normal memory mapping is overwritten by
the low identity mapping causing crash. To avoid overwritting, limit the
low identity map to cover only memory before kernel range (PAGE_OFFSET).

Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
---
The bug can be also fixed by copying identity mapping before copying
kernel address range, but this fix is smaller.

It might be also helpful to add a warning, if the low identity mapping
is truncated due to kernel mapping (KERNEL_PGD_BOUNDARY < KERNEL_PGD_PTRS).

 arch/x86/kernel/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index a3cccbf..37c8ea8 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1180,7 +1180,7 @@ void __init setup_arch(char **cmdline_p)
 	 */
 	clone_pgd_range(initial_page_table,
 			swapper_pg_dir     + KERNEL_PGD_BOUNDARY,
-			KERNEL_PGD_PTRS);
+			min(KERNEL_PGD_PTRS, KERNEL_PGD_BOUNDARY));
 #endif
 
 	tboot_probe();
-- 
2.6.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1264014

FromBorislav Petkov <bp@alien8.de>
Date2015-11-06 14:30 +0100
Message-ID<qrPfC-52O-41@gated-at.bofh.it>
In reply to#1264011
On Fri, Nov 06, 2015 at 02:18:36PM +0100, Krzysztof Mazur wrote:
> The commit f5f3497cad8c8416a74b9aaceb127908755d020a (x86/setup: Extend
> low identity map to cover whole kernel range) extended the low identity
> mapping. However, if the kernel uses more than 2 GB (VMSPLIT_2G_OPT or
> VMSPLIT_1G memory split), the normal memory mapping is overwritten by
> the low identity mapping causing crash. To avoid overwritting, limit the
> low identity map to cover only memory before kernel range (PAGE_OFFSET).
> 
> Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
> ---
> The bug can be also fixed by copying identity mapping before copying
> kernel address range, but this fix is smaller.
> 
> It might be also helpful to add a warning, if the low identity mapping
> is truncated due to kernel mapping (KERNEL_PGD_BOUNDARY < KERNEL_PGD_PTRS).
> 
>  arch/x86/kernel/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index a3cccbf..37c8ea8 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -1180,7 +1180,7 @@ void __init setup_arch(char **cmdline_p)
>  	 */
>  	clone_pgd_range(initial_page_table,
>  			swapper_pg_dir     + KERNEL_PGD_BOUNDARY,
> -			KERNEL_PGD_PTRS);
> +			min(KERNEL_PGD_PTRS, KERNEL_PGD_BOUNDARY));
>  #endif
>  
>  	tboot_probe();

http://git.kernel.org/tip/1c5dac914794f0170e1582d8ffdee52d30e0e4dd

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1264050

FromKrzysztof Mazur <krzysiek@podlesie.net>
Date2015-11-06 15:20 +0100
Message-ID<qrQ1Y-5z3-9@gated-at.bofh.it>
In reply to#1264014
On Fri, Nov 06, 2015 at 02:27:33PM +0100, Borislav Petkov wrote:
> On Fri, Nov 06, 2015 at 02:18:36PM +0100, Krzysztof Mazur wrote:
> > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> > index a3cccbf..37c8ea8 100644
> > --- a/arch/x86/kernel/setup.c
> > +++ b/arch/x86/kernel/setup.c
> > @@ -1180,7 +1180,7 @@ void __init setup_arch(char **cmdline_p)
> >  	 */
> >  	clone_pgd_range(initial_page_table,
> >  			swapper_pg_dir     + KERNEL_PGD_BOUNDARY,
> > -			KERNEL_PGD_PTRS);
> > +			min(KERNEL_PGD_PTRS, KERNEL_PGD_BOUNDARY));
> >  #endif
> >  
> >  	tboot_probe();
> 
> http://git.kernel.org/tip/1c5dac914794f0170e1582d8ffdee52d30e0e4dd
> 

Thanks and sorry. Yes, it has been already fixed. I've rechecked only
mainline.

However, I think that there should be
min(KERNEL_PGD_PTRS, KERNEL_PGD_BOUNDARY), not just KERNEL_PGD_BOUNDARY
(usually 768 for normal 1G/3G split), because swapper_pg_dir has only
1024 entries and 768+768 is 1536.

Krzysiek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1264076

FromPaolo Bonzini <pbonzini@redhat.com>
Date2015-11-06 16:10 +0100
Message-ID<qrQOl-68f-7@gated-at.bofh.it>
In reply to#1264050

On 06/11/2015 15:11, Krzysztof Mazur wrote:
>> > 
>> > http://git.kernel.org/tip/1c5dac914794f0170e1582d8ffdee52d30e0e4dd
>> > 
> Thanks and sorry. Yes, it has been already fixed. I've rechecked only
> mainline.
> 
> However, I think that there should be
> min(KERNEL_PGD_PTRS, KERNEL_PGD_BOUNDARY), not just KERNEL_PGD_BOUNDARY
> (usually 768 for normal 1G/3G split), because swapper_pg_dir has only
> 1024 entries and 768+768 is 1536.

You are right.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1264779

FromMatt Fleming <matt@codeblueprint.co.uk>
Date2015-11-07 10:50 +0100
Message-ID<qs8ie-xb-11@gated-at.bofh.it>
In reply to#1264050
On Fri, 06 Nov, at 03:11:39PM, Krzysztof Mazur wrote:
> On Fri, Nov 06, 2015 at 02:27:33PM +0100, Borislav Petkov wrote:
> > On Fri, Nov 06, 2015 at 02:18:36PM +0100, Krzysztof Mazur wrote:
> > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> > > index a3cccbf..37c8ea8 100644
> > > --- a/arch/x86/kernel/setup.c
> > > +++ b/arch/x86/kernel/setup.c
> > > @@ -1180,7 +1180,7 @@ void __init setup_arch(char **cmdline_p)
> > >  	 */
> > >  	clone_pgd_range(initial_page_table,
> > >  			swapper_pg_dir     + KERNEL_PGD_BOUNDARY,
> > > -			KERNEL_PGD_PTRS);
> > > +			min(KERNEL_PGD_PTRS, KERNEL_PGD_BOUNDARY));
> > >  #endif
> > >  
> > >  	tboot_probe();
> > 
> > http://git.kernel.org/tip/1c5dac914794f0170e1582d8ffdee52d30e0e4dd
> > 
> 
> Thanks and sorry. Yes, it has been already fixed. I've rechecked only
> mainline.
> 
> However, I think that there should be
> min(KERNEL_PGD_PTRS, KERNEL_PGD_BOUNDARY), not just KERNEL_PGD_BOUNDARY
> (usually 768 for normal 1G/3G split), because swapper_pg_dir has only
> 1024 entries and 768+768 is 1536.

Yeah, this fix is preferable to the one that is currently sitting in
tip/x86/urgent. Curse you VMSPLIT!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1264783 — [tip:x86/urgent] x86/setup: Fix low identity map for >= 2GB kernel range

Fromtip-bot for Krzysztof Mazur <tipbot@zytor.com>
Date2015-11-07 10:50 +0100
Subject[tip:x86/urgent] x86/setup: Fix low identity map for >= 2GB kernel range
Message-ID<qs8ie-xb-19@gated-at.bofh.it>
In reply to#1264011
Commit-ID:  68accac392d859d24adcf1be3a90e41f978bd54c
Gitweb:     http://git.kernel.org/tip/68accac392d859d24adcf1be3a90e41f978bd54c
Author:     Krzysztof Mazur <krzysiek@podlesie.net>
AuthorDate: Fri, 6 Nov 2015 14:18:36 +0100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sat, 7 Nov 2015 10:39:40 +0100

x86/setup: Fix low identity map for >= 2GB kernel range

The commit f5f3497cad8c extended the low identity mapping. However, if
the kernel uses more than 2 GB (VMSPLIT_2G_OPT or VMSPLIT_1G memory
split), the normal memory mapping is overwritten by the low identity
mapping causing a crash. To avoid overwritting, limit the low identity
map to cover only memory before kernel range (PAGE_OFFSET).

Fixes: f5f3497cad8c "x86/setup: Extend low identity map to cover whole kernel range
Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Matt Fleming <matt.fleming@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1446815916-22105-1-git-send-email-krzysiek@podlesie.net
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/kernel/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index a1e4da9..29db25f 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1188,7 +1188,7 @@ void __init setup_arch(char **cmdline_p)
 	 */
 	clone_pgd_range(initial_page_table,
 			swapper_pg_dir     + KERNEL_PGD_BOUNDARY,
-			KERNEL_PGD_PTRS);
+			min(KERNEL_PGD_PTRS, KERNEL_PGD_BOUNDARY));
 #endif
 
 	tboot_probe();
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web