Re: [PATCH] x86/setup: fix low identity map for >= 2GB kernel range

From	Matt Fleming <matt@codeblueprint.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/setup: fix low identity map for >= 2GB kernel range
Date	2015-11-07 10:50 +0100
Message-ID	<qs8ie-xb-11@gated-at.bofh.it> (permalink)
References	<qrPfC-52O-35@gated-at.bofh.it> <qrPfC-52O-41@gated-at.bofh.it> <qrQ1Y-5z3-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 06 Nov, at 03:11:39PM, Krzysztof Mazur wrote:
> On Fri, Nov 06, 2015 at 02:27:33PM +0100, Borislav Petkov wrote:
> > On Fri, Nov 06, 2015 at 02:18:36PM +0100, Krzysztof Mazur wrote:
> > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> > > index a3cccbf..37c8ea8 100644
> > > --- a/arch/x86/kernel/setup.c
> > > +++ b/arch/x86/kernel/setup.c
> > > @@ -1180,7 +1180,7 @@ void __init setup_arch(char **cmdline_p)
> > >  	 */
> > >  	clone_pgd_range(initial_page_table,
> > >  			swapper_pg_dir     + KERNEL_PGD_BOUNDARY,
> > > -			KERNEL_PGD_PTRS);
> > > +			min(KERNEL_PGD_PTRS, KERNEL_PGD_BOUNDARY));
> > >  #endif
> > >  
> > >  	tboot_probe();
> > 
> > http://git.kernel.org/tip/1c5dac914794f0170e1582d8ffdee52d30e0e4dd
> > 
> 
> Thanks and sorry. Yes, it has been already fixed. I've rechecked only
> mainline.
> 
> However, I think that there should be
> min(KERNEL_PGD_PTRS, KERNEL_PGD_BOUNDARY), not just KERNEL_PGD_BOUNDARY
> (usually 768 for normal 1G/3G split), because swapper_pg_dir has only
> 1024 entries and 768+768 is 1536.

Yeah, this fix is preferable to the one that is currently sitting in
tip/x86/urgent. Curse you VMSPLIT!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] x86/setup: fix low identity map for >= 2GB kernel range Krzysztof Mazur <krzysiek@podlesie.net> - 2015-11-06 14:30 +0100
  Re: [PATCH] x86/setup: fix low identity map for >= 2GB kernel range Borislav Petkov <bp@alien8.de> - 2015-11-06 14:30 +0100
    Re: [PATCH] x86/setup: fix low identity map for >= 2GB kernel range Krzysztof Mazur <krzysiek@podlesie.net> - 2015-11-06 15:20 +0100
      Re: [PATCH] x86/setup: fix low identity map for >= 2GB kernel range Paolo Bonzini <pbonzini@redhat.com> - 2015-11-06 16:10 +0100
      Re: [PATCH] x86/setup: fix low identity map for >= 2GB kernel range Matt Fleming <matt@codeblueprint.co.uk> - 2015-11-07 10:50 +0100
  [tip:x86/urgent] x86/setup: Fix low identity map for >=   2GB kernel range tip-bot for Krzysztof Mazur <tipbot@zytor.com> - 2015-11-07 10:50 +0100

csiph-web