Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1263519 > unrolled thread
| Started by | Robert Jarzmik <robert.jarzmik@free.fr> |
|---|---|
| First post | 2015-11-05 21:00 +0100 |
| Last post | 2015-11-06 10:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mmc: pxamci: fix read-only gpio detection polarity Robert Jarzmik <robert.jarzmik@free.fr> - 2015-11-05 21:00 +0100
Re: [PATCH] mmc: pxamci: fix read-only gpio detection polarity Ulf Hansson <ulf.hansson@linaro.org> - 2015-11-06 10:10 +0100
| From | Robert Jarzmik <robert.jarzmik@free.fr> |
|---|---|
| Date | 2015-11-05 21:00 +0100 |
| Subject | [PATCH] mmc: pxamci: fix read-only gpio detection polarity |
| Message-ID | <qryRs-2yw-7@gated-at.bofh.it> |
The commit converting pxamci to slot-gpio API inverted the logic of the
read-only gpio. Fix it by inverting the logic again.
Fixes: fd546ee6a7dc ("mmc: pxamci: fix card detect with slot-gpio API")
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: stable@vger.kernel.org
---
drivers/mmc/host/pxamci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
index 8cadd74e8407..ce08896b9d69 100644
--- a/drivers/mmc/host/pxamci.c
+++ b/drivers/mmc/host/pxamci.c
@@ -805,7 +805,7 @@ static int pxamci_probe(struct platform_device *pdev)
goto out;
} else {
mmc->caps |= host->pdata->gpio_card_ro_invert ?
- MMC_CAP2_RO_ACTIVE_HIGH : 0;
+ 0 : MMC_CAP2_RO_ACTIVE_HIGH;
}
if (gpio_is_valid(gpio_cd))
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2015-11-06 10:10 +0100 |
| Message-ID | <qrLbY-2xT-23@gated-at.bofh.it> |
| In reply to | #1263519 |
On 5 November 2015 at 20:46, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> The commit converting pxamci to slot-gpio API inverted the logic of the
> read-only gpio. Fix it by inverting the logic again.
>
> Fixes: fd546ee6a7dc ("mmc: pxamci: fix card detect with slot-gpio API")
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Cc: stable@vger.kernel.org
Thanks, applied for fixes!
Kind regards
Uffe
> ---
> drivers/mmc/host/pxamci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
> index 8cadd74e8407..ce08896b9d69 100644
> --- a/drivers/mmc/host/pxamci.c
> +++ b/drivers/mmc/host/pxamci.c
> @@ -805,7 +805,7 @@ static int pxamci_probe(struct platform_device *pdev)
> goto out;
> } else {
> mmc->caps |= host->pdata->gpio_card_ro_invert ?
> - MMC_CAP2_RO_ACTIVE_HIGH : 0;
> + 0 : MMC_CAP2_RO_ACTIVE_HIGH;
> }
>
> if (gpio_is_valid(gpio_cd))
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web