Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1263858

Re: [PATCH] mmc: pxamci: fix read-only gpio detection polarity

Show all headers | View raw

On 5 November 2015 at 20:46, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> The commit converting pxamci to slot-gpio API inverted the logic of the
> read-only gpio. Fix it by inverting the logic again.
>
> Fixes: fd546ee6a7dc ("mmc: pxamci: fix card detect with slot-gpio API")
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Cc: stable@vger.kernel.org

Thanks, applied for fixes!

Kind regards
Uffe

> ---
>  drivers/mmc/host/pxamci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
> index 8cadd74e8407..ce08896b9d69 100644
> --- a/drivers/mmc/host/pxamci.c
> +++ b/drivers/mmc/host/pxamci.c
> @@ -805,7 +805,7 @@ static int pxamci_probe(struct platform_device *pdev)
>                 goto out;
>         } else {
>                 mmc->caps |= host->pdata->gpio_card_ro_invert ?
> -                       MMC_CAP2_RO_ACTIVE_HIGH : 0;
> +                       0 : MMC_CAP2_RO_ACTIVE_HIGH;
>         }
>
>         if (gpio_is_valid(gpio_cd))
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: pxamci: fix read-only gpio detection polarity Robert Jarzmik <robert.jarzmik@free.fr> - 2015-11-05 21:00 +0100
  Re: [PATCH] mmc: pxamci: fix read-only gpio detection polarity Ulf Hansson <ulf.hansson@linaro.org> - 2015-11-06 10:10 +0100

csiph-web