Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1263217 > unrolled thread

[PATCH 0/7] Add Support for Hi6220 PMIC Hi6553 MFD Core

Started byChen Feng <puck.chen@hisilicon.com>
First post2015-11-05 14:50 +0100
Last post2015-11-05 21:40 +0100
Articles 7 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/7] Add Support for Hi6220 PMIC Hi6553 MFD Core Chen Feng <puck.chen@hisilicon.com> - 2015-11-05 14:50 +0100
    [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage regulator driver Chen Feng <puck.chen@hisilicon.com> - 2015-11-05 15:00 +0100
      Re: [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage  regulator driver Mark Brown <broonie@kernel.org> - 2015-11-05 16:30 +0100
      Re: [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage  regulator driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-06 22:30 +0100
    [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC Chen Feng <puck.chen@hisilicon.com> - 2015-11-05 15:00 +0100
      Re: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220  SoC Mark Brown <broonie@kernel.org> - 2015-11-05 15:20 +0100
      Re: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220  SoC Rob Herring <robh@kernel.org> - 2015-11-05 21:40 +0100

#1263217 — [PATCH 0/7] Add Support for Hi6220 PMIC Hi6553 MFD Core

FromChen Feng <puck.chen@hisilicon.com>
Date2015-11-05 14:50 +0100
Subject[PATCH 0/7] Add Support for Hi6220 PMIC Hi6553 MFD Core
Message-ID<qrsVH-7i3-9@gated-at.bofh.it>
  The patch sets add support for Hi6220 PMIC Hi655x MFD core and its
regulator driver.
  Current testing and support board is Hikey which is one of 96boards.
It is an arm64 open source board. For more information about this board,
please access https://www.96boards.org.

This is hardware layout for access PMIC Hi655x from AP SoC Hi6220.
Between PMIC Hi655x and Hi6220, the physical signal channel is SSI.
We can use memory-mapped I/O to communicate.

+----------------+             +-------------+
|                |             |             |
|    Hi6220      |   SSI bus   |   Hi655x    |
|                |-------------|             |
|                |(REGMAP_MMIO)|             |
+----------------+             +-------------+

The patch sets are based on 4.3-rc7.

Chen Feng (7):
  doc:bindings:Add document for mfd hi665x PMIC
  doc:bindings:Document for mtcmos regulator on hi6220 SoC
  doc:bindings:Document for hi655x pmic driver
  mfd: hi655x: Add hi665x pmic driver
  regulator: add driver for mtcmos voltage regulator on hi6220 SoC
  regulator: hisilicon: Add hi655x pmic voltage regulator driver
  arm64: dts: Add mtcmos and pmic node for hi6220 HiKey board

 .../devicetree/bindings/mfd/hisilicon,hi655x.txt   |  18 ++
 .../bindings/regulator/hisilicon,hi6220-mtcmos.txt |  32 +++
 .../regulator/hisilicon,hi655x-regulator.txt       |  50 ++++
 arch/arm64/boot/dts/hisilicon/hi6220.dtsi          | 210 ++++++++++++++
 drivers/mfd/Kconfig                                |   9 +
 drivers/mfd/Makefile                               |   1 +
 drivers/mfd/hi655x-pmic.c                          | 315 +++++++++++++++++++++
 drivers/regulator/Kconfig                          |  13 +
 drivers/regulator/Makefile                         |   2 +
 drivers/regulator/hi6220-mtcmos.c                  | 245 ++++++++++++++++
 drivers/regulator/hi655x-regulator.c               | 246 ++++++++++++++++
 include/linux/mfd/hi655x-pmic.h                    |  50 ++++
 include/linux/regulator/hi655x-regulator.h         |  63 +++++
 13 files changed, 1254 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt
 create mode 100644 drivers/mfd/hi655x-pmic.c
 create mode 100644 drivers/regulator/hi6220-mtcmos.c
 create mode 100644 drivers/regulator/hi655x-regulator.c
 create mode 100644 include/linux/mfd/hi655x-pmic.h
 create mode 100644 include/linux/regulator/hi655x-regulator.h

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1263223 — [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage regulator driver

FromChen Feng <puck.chen@hisilicon.com>
Date2015-11-05 15:00 +0100
Subject[PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage regulator driver
Message-ID<qrtf4-7pc-11@gated-at.bofh.it>
In reply to#1263217
Add driver support for HiSilicon Hi655x voltage regulators.

Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Fei Wang <w.f@huawei.com>
---
 drivers/regulator/Kconfig                  |  13 ++
 drivers/regulator/Makefile                 |   2 +
 drivers/regulator/hi655x-regulator.c       | 246 +++++++++++++++++++++++++++++
 include/linux/regulator/hi655x-regulator.h |  63 ++++++++
 4 files changed, 324 insertions(+)
 create mode 100644 drivers/regulator/hi655x-regulator.c
 create mode 100644 include/linux/regulator/hi655x-regulator.h

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 64bccff..9bbd43c 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -261,6 +261,19 @@ config REGULATOR_HI6421
 	  21 general purpose LDOs, 3 dedicated LDOs, and 5 BUCKs. All
 	  of them come with support to either ECO (idle) or sleep mode.
 
+config REGULATOR_HI6220_MTCMOS
+        bool "Hisilicon Hi6220 mtcmos support"
+        depends on ARCH_HISI
+        help
+          This driver provides support for the mtcmos regulators of Hi6220 Soc.
+
+config REGULATOR_HI655X
+        bool "HiSilicon Hi655x PMIC voltage regulator support"
+        depends on ARCH_HISI
+        help
+	  This driver provides support for the voltage regulators on the
+	  HiSilicon hi655x PMIC.
+
 config REGULATOR_ISL9305
 	tristate "Intersil ISL9305 regulator"
 	depends on I2C
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 0f81749..7345d43 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -34,6 +34,8 @@ obj-$(CONFIG_REGULATOR_DB8500_PRCMU) += db8500-prcmu.o
 obj-$(CONFIG_REGULATOR_FAN53555) += fan53555.o
 obj-$(CONFIG_REGULATOR_GPIO) += gpio-regulator.o
 obj-$(CONFIG_REGULATOR_HI6421) += hi6421-regulator.o
+obj-$(CONFIG_REGULATOR_HI6220_MTCMOS) += hi6220-mtcmos.o
+obj-$(CONFIG_REGULATOR_HI655X) += hi655x-regulator.o
 obj-$(CONFIG_REGULATOR_ISL6271A) += isl6271a-regulator.o
 obj-$(CONFIG_REGULATOR_ISL9305) += isl9305.o
 obj-$(CONFIG_REGULATOR_LP3971) += lp3971.o
diff --git a/drivers/regulator/hi655x-regulator.c b/drivers/regulator/hi655x-regulator.c
new file mode 100644
index 0000000..b06c810
--- /dev/null
+++ b/drivers/regulator/hi655x-regulator.c
@@ -0,0 +1,246 @@
+/*
+ * Device driver for regulators in hi655x IC
+ *
+ * Copyright (c) 2015 Hisilicon.
+ *
+ * Fei Wang <w.f@huawei.com>
+ * Chen Feng <puck.chen@hisilicon.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/slab.h>
+#include <linux/device.h>
+#include <linux/module.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <linux/platform_device.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/of_address.h>
+#include <linux/regmap.h>
+#include <linux/regulator/driver.h>
+#include <linux/regulator/machine.h>
+#include <linux/regulator/of_regulator.h>
+#include <linux/delay.h>
+#include <linux/time.h>
+#include <linux/regulator/hi655x-regulator.h>
+#include <linux/mfd/hi655x-pmic.h>
+#include <linux/regmap.h>
+#include <linux/bitops.h>
+
+static int hi655x_is_enabled(struct regulator_dev *rdev)
+{
+	unsigned int value = 0;
+
+	struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
+	struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
+
+	regmap_read(rdev->regmap, ctrl_regs->status_reg, &value);
+	return (value & BIT(regulator->ctrl_mask));
+}
+
+static int hi655x_enable(struct regulator_dev *rdev)
+{
+	int ret = 0;
+	struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
+	struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
+
+	ret = regmap_update_bits(rdev->regmap, ctrl_regs->enable_reg,
+				 regulator->ctrl_mask, regulator->ctrl_mask);
+	return ret;
+}
+
+static int hi655x_disable(struct regulator_dev *rdev)
+{
+	int ret = 0;
+	struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
+
+	if (!regulator) {
+		pr_err("get driver data error!\n");
+		return -ENODEV;
+	}
+	struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
+
+	ret = regmap_update_bits(rdev->regmap, ctrl_regs->disable_reg,
+				 regulator->ctrl_mask, regulator->ctrl_mask);
+	return ret;
+}
+
+static int hi655x_get_voltage(struct regulator_dev *rdev)
+{
+	unsigned int value = 0;
+	struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
+
+	if (!regulator) {
+		pr_err("get driver data error!\n");
+		return -ENODEV;
+	}
+	struct hi655x_regulator_vset_regs *vset_regs = &regulator->vset_regs;
+
+	regmap_read(rdev->regmap, vset_regs->vset_reg, &value);
+
+	return regulator->vset_table[value];
+}
+
+static int hi655x_set_voltage(struct regulator_dev *rdev,
+			      int min_uV, int max_uV, unsigned *selector)
+{
+	int i = 0;
+	int ret = 0;
+	int vol = 0;
+	struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
+
+	if (!regulator) {
+		pr_err("get driver data error!\n");
+		return -ENODEV;
+	}
+
+	struct hi655x_regulator_vset_regs *vset_regs = &regulator->vset_regs;
+
+	/**
+	 * search the matched vol and get its index
+	 */
+	for (i = 0; i < regulator->vol_numb; i++) {
+		vol = regulator->vset_table[i];
+		if ((vol >= min_uV) && (vol <= max_uV))
+			break;
+	}
+
+	if (i == regulator->vol_numb)
+		return -1;
+
+	regmap_update_bits(rdev->regmap, vset_regs->vset_reg,
+			   regulator->vset_mask, i);
+	*selector = i;
+
+	return ret;
+}
+
+static unsigned int hi655x_map_mode(unsigned int mode)
+{
+	/* hi655x pmic on hi6220 SoC only support normal mode */
+	if (mode == REGULATOR_MODE_NORMAL)
+		return REGULATOR_MODE_NORMAL;
+	else
+		return -EINVAL;
+}
+
+static int hi655x_set_mode(struct regulator_dev *rdev,
+			   unsigned int mode)
+
+{
+	if (mode == REGULATOR_MODE_NORMAL)
+		return 0;
+	else
+		return -EINVAL;
+}
+
+static struct regulator_ops hi655x_regulator_ops = {
+	.is_enabled = hi655x_is_enabled,
+	.enable = hi655x_enable,
+	.disable = hi655x_disable,
+	.list_voltage = regulator_list_voltage_table,
+	.get_voltage = hi655x_get_voltage,
+	.set_voltage = hi655x_set_voltage,
+	.set_mode = hi655x_set_mode,
+};
+
+static const struct of_device_id of_hi655x_regulator_match_tbl[] = {
+	{
+		.compatible = "hisilicon,hi655x-regulator-pmic",
+	},
+};
+MODULE_DEVICE_TABLE(of, of_hi655x_regulator_match_tbl);
+
+/**
+ * get the hi655x specific data from dt node.
+ */
+static void of_get_hi655x_ctr(struct hi655x_regulator *regulator,
+			      struct device *dev, struct device_node *np)
+{
+	unsigned int *vset_table = NULL;
+
+	of_property_read_u32_array(np, "regulator-ctrl-regs",
+				   (u32 *)&regulator->ctrl_regs, 0x3);
+	of_property_read_u32(np, "regulator-ctrl-mask", &regulator->ctrl_mask);
+	of_property_read_u32(np, "regulator-vset-regs",
+			     (u32 *)&regulator->vset_regs);
+	of_property_read_u32(np, "regulator-vset-mask", &regulator->vset_mask);
+	of_property_read_u32(np, "regulator-n-vol", &regulator->vol_numb);
+	of_property_read_u32(np, "regulator-off-on-delay",
+			     &regulator->rdesc.off_on_delay);
+
+	vset_table = devm_kzalloc(dev, regulator->vol_numb * sizeof(int),
+				  GFP_KERNEL);
+
+	of_property_read_u32_array(np, "regulator-vset-table",
+				   vset_table,
+				   regulator->vol_numb);
+	regulator->vset_table = vset_table;
+	regulator->rdesc.volt_table = vset_table;
+	regulator->rdesc.n_voltages = regulator->vol_numb;
+}
+
+static int hi655x_regulator_probe(struct platform_device *pdev)
+{
+	int ret = 0;
+	struct hi655x_regulator *regulator;
+	struct hi655x_pmic *pmic;
+	struct regulator_init_data *init_data;
+	struct regulator_config config = { };
+	struct device_node *np = pdev->dev.of_node;
+
+	pmic = dev_get_drvdata(pdev->dev.parent);
+	if (!pmic) {
+		pr_err("no pmic in the regulator parent node\n");
+		return -ENODEV;
+	}
+
+	regulator = devm_kzalloc(&pdev->dev, sizeof(*regulator), GFP_KERNEL);
+	if (!regulator)
+		return -ENOMEM;
+	of_get_hi655x_ctr(regulator, &pdev->dev, np);
+
+	regulator->rdesc.name = dev_name(&pdev->dev);
+	regulator->rdesc.type = REGULATOR_VOLTAGE;
+	regulator->rdesc.owner = THIS_MODULE;
+	regulator->rdesc.of_map_mode = hi655x_map_mode;
+	regulator->rdesc.ops = &hi655x_regulator_ops;
+	init_data = of_get_regulator_init_data(&pdev->dev, pdev->dev.of_node,
+					       &regulator->rdesc);
+	if (!init_data) {
+		pr_err("get init data from dts error!\n");
+		return -EINVAL;
+	}
+	config.dev = &pdev->dev;
+	config.init_data = init_data;
+	config.driver_data = regulator;
+	config.regmap = pmic->regmap;
+
+	regulator->regdev = devm_regulator_register(&pdev->dev,
+						    &regulator->rdesc,
+						    &config);
+	if (IS_ERR(regulator->regdev)) {
+		pr_err("register regulator to system error!\n");
+		return PTR_ERR(regulator->regdev);
+	}
+
+	platform_set_drvdata(pdev, regulator);
+	return 0;
+}
+
+static struct platform_driver hi655x_regulator_driver = {
+	.driver = {
+		.name	= "hi655x_regulator",
+		.of_match_table = of_hi655x_regulator_match_tbl,
+	},
+	.probe	= hi655x_regulator_probe,
+};
+module_platform_driver(hi655x_regulator_driver);
+
+MODULE_AUTHOR("Chen Feng <puck.chen@hisilicon.com>");
+MODULE_DESCRIPTION("Hisi hi655x regulator driver");
+MODULE_LICENSE("GPL v2");
diff --git a/include/linux/regulator/hi655x-regulator.h b/include/linux/regulator/hi655x-regulator.h
new file mode 100644
index 0000000..4a32095
--- /dev/null
+++ b/include/linux/regulator/hi655x-regulator.h
@@ -0,0 +1,63 @@
+/*
+ * Device driver for regulators in HI6553 IC
+ *
+ * Copyright (c) 2015 Hisilicon.
+ *
+ * Fei Wang  <w.f@huawei.com>
+ * Chen Feng <puck.chen@hisilicon.com>
+ *
+ * this regulator's probe function will be called lots of times,,
+ * because of there are lots of regulator nodes in dtb.
+ * so,that's say, the driver must be inited before the regulator nodes
+ * registor to system.
+ *
+ * Makefile have proved my guess, please refor to the makefile.
+ * when the code is rebuild i hope we can build pmu sub_system.
+ * init order can not base on compile
+ */
+
+#ifndef __HISI_HI655X_REGULATOR_H__
+#define __HISI_HI655X_REGULATOR_H__
+
+enum hi655x_regulator_type {
+	PMIC_BUCK_TYPE = 0,
+	PMIC_LDO_TYPE = 1,
+	PMIC_LVS_TYPE = 2,
+	PMIC_BOOST_TYPE = 3,
+	MTCMOS_SC_ON_TYPE = 4,
+	MTCMOS_ACPU_ON_TYPE = 5,
+	SCHARGE_TYPE = 6,
+};
+
+struct hi655x_regulator_ctrl_regs {
+	unsigned int  enable_reg;
+	unsigned int  disable_reg;
+	unsigned int  status_reg;
+};
+
+struct hi655x_regulator_vset_regs {
+	unsigned int vset_reg;
+};
+
+struct hi655x_regulator_ctrl_data {
+	int          shift;
+	unsigned int val;
+};
+
+struct hi655x_regulator_vset_data {
+	int          shift;
+	unsigned int mask;
+};
+
+struct hi655x_regulator {
+	struct hi655x_regulator_ctrl_regs ctrl_regs;
+	struct hi655x_regulator_vset_regs vset_regs;
+	u32 ctrl_mask;
+	u32 vset_mask;
+	u32 vol_numb;
+	u32 *vset_table;
+	struct regulator_desc rdesc;
+	struct regulator_dev *regdev;
+};
+
+#endif
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1263330 — Re: [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage regulator driver

FromMark Brown <broonie@kernel.org>
Date2015-11-05 16:30 +0100
SubjectRe: [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage regulator driver
Message-ID<qruEa-8ru-17@gated-at.bofh.it>
In reply to#1263223

[Multipart message — attachments visible in raw view] — view raw

On Thu, Nov 05, 2015 at 09:34:47PM +0800, Chen Feng wrote:

> +config REGULATOR_HI6220_MTCMOS
> +        bool "Hisilicon Hi6220 mtcmos support"
> +        depends on ARCH_HISI
> +        help
> +          This driver provides support for the mtcmos regulators of Hi6220 Soc.
> +

The Kconfig and Makefile updates for MCTMOS should have been in the
patch adding the driver for that.

> +config REGULATOR_HI655X
> +        bool "HiSilicon Hi655x PMIC voltage regulator support"
> +        depends on ARCH_HISI

For both of these we should have an || COMPILE_TEST and there's no need
for either to be bool I can see, they should be tristate.

> +static int hi655x_is_enabled(struct regulator_dev *rdev)
> +{
> +	unsigned int value = 0;
> +
> +	struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
> +	struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
> +
> +	regmap_read(rdev->regmap, ctrl_regs->status_reg, &value);
> +	return (value & BIT(regulator->ctrl_mask));
> +}

Use the standard regmap helpers, don't open code them.

> +static int hi655x_set_voltage(struct regulator_dev *rdev,
> +			      int min_uV, int max_uV, unsigned *selector)

Use the standard helpers, including one of the map_voltage()s and
set_voltage_sel_regmap(), don't open code them.

> +static unsigned int hi655x_map_mode(unsigned int mode)
> +{
> +	/* hi655x pmic on hi6220 SoC only support normal mode */
> +	if (mode == REGULATOR_MODE_NORMAL)
> +		return REGULATOR_MODE_NORMAL;
> +	else
> +		return -EINVAL;
> +}

If the device only has one mode it should not have any mode operations,
they're only meaningful if there are multiple modes to set and they are
optional.

[toc] | [prev] | [next] | [standalone]

#1264576 — Re: [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage regulator driver

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2015-11-06 22:30 +0100
SubjectRe: [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage regulator driver
Message-ID<qrWK6-1yP-19@gated-at.bofh.it>
In reply to#1263223
On Thu, Nov 5, 2015 at 3:34 PM, Chen Feng <puck.chen@hisilicon.com> wrote:
> Add driver support for HiSilicon Hi655x voltage regulators.

> +#include <linux/slab.h>
> +#include <linux/device.h>
> +#include <linux/module.h>
> +#include <linux/err.h>
> +#include <linux/io.h>
> +#include <linux/platform_device.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> +#include <linux/of_address.h>
> +#include <linux/regmap.h>
> +#include <linux/regulator/driver.h>
> +#include <linux/regulator/machine.h>
> +#include <linux/regulator/of_regulator.h>
> +#include <linux/delay.h>
> +#include <linux/time.h>
> +#include <linux/regulator/hi655x-regulator.h>
> +#include <linux/mfd/hi655x-pmic.h>
> +#include <linux/regmap.h>
> +#include <linux/bitops.h>
> +
> +static int hi655x_is_enabled(struct regulator_dev *rdev)
> +{
> +       unsigned int value = 0;
> +
> +       struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
> +       struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
> +
> +       regmap_read(rdev->regmap, ctrl_regs->status_reg, &value);
> +       return (value & BIT(regulator->ctrl_mask));
> +}
> +
> +static int hi655x_enable(struct regulator_dev *rdev)
> +{
> +       int ret = 0;
> +       struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
> +       struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
> +
> +       ret = regmap_update_bits(rdev->regmap, ctrl_regs->enable_reg,
> +                                regulator->ctrl_mask, regulator->ctrl_mask);
> +       return ret;
> +}
> +
> +static int hi655x_disable(struct regulator_dev *rdev)
> +{
> +       int ret = 0;
> +       struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
> +
> +       if (!regulator) {
> +               pr_err("get driver data error!\n");
> +               return -ENODEV;
> +       }
> +       struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
> +
> +       ret = regmap_update_bits(rdev->regmap, ctrl_regs->disable_reg,
> +                                regulator->ctrl_mask, regulator->ctrl_mask);
> +       return ret;
> +}
> +
> +static int hi655x_get_voltage(struct regulator_dev *rdev)
> +{
> +       unsigned int value = 0;
> +       struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
> +
> +       if (!regulator) {
> +               pr_err("get driver data error!\n");
> +               return -ENODEV;
> +       }
> +       struct hi655x_regulator_vset_regs *vset_regs = &regulator->vset_regs;
> +
> +       regmap_read(rdev->regmap, vset_regs->vset_reg, &value);
> +
> +       return regulator->vset_table[value];
> +}
> +
> +static int hi655x_set_voltage(struct regulator_dev *rdev,
> +                             int min_uV, int max_uV, unsigned *selector)
> +{
> +       int i = 0;
> +       int ret = 0;
> +       int vol = 0;
> +       struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
> +
> +       if (!regulator) {
> +               pr_err("get driver data error!\n");
> +               return -ENODEV;
> +       }
> +
> +       struct hi655x_regulator_vset_regs *vset_regs = &regulator->vset_regs;
> +
> +       /**
> +        * search the matched vol and get its index
> +        */
> +       for (i = 0; i < regulator->vol_numb; i++) {
> +               vol = regulator->vset_table[i];
> +               if ((vol >= min_uV) && (vol <= max_uV))
> +                       break;
> +       }
> +
> +       if (i == regulator->vol_numb)
> +               return -1;
> +
> +       regmap_update_bits(rdev->regmap, vset_regs->vset_reg,
> +                          regulator->vset_mask, i);
> +       *selector = i;
> +
> +       return ret;
> +}
> +
> +static unsigned int hi655x_map_mode(unsigned int mode)
> +{
> +       /* hi655x pmic on hi6220 SoC only support normal mode */
> +       if (mode == REGULATOR_MODE_NORMAL)
> +               return REGULATOR_MODE_NORMAL;
> +       else
> +               return -EINVAL;
> +}
> +
> +static int hi655x_set_mode(struct regulator_dev *rdev,
> +                          unsigned int mode)
> +
> +{
> +       if (mode == REGULATOR_MODE_NORMAL)
> +               return 0;
> +       else
> +               return -EINVAL;
> +}
> +
> +static struct regulator_ops hi655x_regulator_ops = {
> +       .is_enabled = hi655x_is_enabled,
> +       .enable = hi655x_enable,
> +       .disable = hi655x_disable,
> +       .list_voltage = regulator_list_voltage_table,
> +       .get_voltage = hi655x_get_voltage,
> +       .set_voltage = hi655x_set_voltage,
> +       .set_mode = hi655x_set_mode,
> +};
> +
> +static const struct of_device_id of_hi655x_regulator_match_tbl[] = {
> +       {
> +               .compatible = "hisilicon,hi655x-regulator-pmic",
> +       },
> +};
> +MODULE_DEVICE_TABLE(of, of_hi655x_regulator_match_tbl);
> +
> +/**
> + * get the hi655x specific data from dt node.
> + */
> +static void of_get_hi655x_ctr(struct hi655x_regulator *regulator,
> +                             struct device *dev, struct device_node *np)
> +{
> +       unsigned int *vset_table = NULL;
> +
> +       of_property_read_u32_array(np, "regulator-ctrl-regs",

device property API?

> +                                  (u32 *)&regulator->ctrl_regs, 0x3);
> +       of_property_read_u32(np, "regulator-ctrl-mask", &regulator->ctrl_mask);
> +       of_property_read_u32(np, "regulator-vset-regs",
> +                            (u32 *)&regulator->vset_regs);
> +       of_property_read_u32(np, "regulator-vset-mask", &regulator->vset_mask);
> +       of_property_read_u32(np, "regulator-n-vol", &regulator->vol_numb);
> +       of_property_read_u32(np, "regulator-off-on-delay",
> +                            &regulator->rdesc.off_on_delay);
> +
> +       vset_table = devm_kzalloc(dev, regulator->vol_numb * sizeof(int),
> +                                 GFP_KERNEL);
> +
> +       of_property_read_u32_array(np, "regulator-vset-table",
> +                                  vset_table,
> +                                  regulator->vol_numb);
> +       regulator->vset_table = vset_table;
> +       regulator->rdesc.volt_table = vset_table;
> +       regulator->rdesc.n_voltages = regulator->vol_numb;
> +}
> +
> +static int hi655x_regulator_probe(struct platform_device *pdev)
> +{
> +       int ret = 0;

Is it used?

make W=1

> +       struct hi655x_regulator *regulator;
> +       struct hi655x_pmic *pmic;
> +       struct regulator_init_data *init_data;
> +       struct regulator_config config = { };
> +       struct device_node *np = pdev->dev.of_node;
> +
> +       pmic = dev_get_drvdata(pdev->dev.parent);
> +       if (!pmic) {
> +               pr_err("no pmic in the regulator parent node\n");

pr_err -> dev_err. Here and in other places.

> +               return -ENODEV;
> +       }
> +
> +       regulator = devm_kzalloc(&pdev->dev, sizeof(*regulator), GFP_KERNEL);
> +       if (!regulator)
> +               return -ENOMEM;
> +       of_get_hi655x_ctr(regulator, &pdev->dev, np);
> +
> +       regulator->rdesc.name = dev_name(&pdev->dev);
> +       regulator->rdesc.type = REGULATOR_VOLTAGE;
> +       regulator->rdesc.owner = THIS_MODULE;
> +       regulator->rdesc.of_map_mode = hi655x_map_mode;
> +       regulator->rdesc.ops = &hi655x_regulator_ops;
> +       init_data = of_get_regulator_init_data(&pdev->dev, pdev->dev.of_node,
> +                                              &regulator->rdesc);
> +       if (!init_data) {
> +               pr_err("get init data from dts error!\n");
> +               return -EINVAL;
> +       }
> +       config.dev = &pdev->dev;
> +       config.init_data = init_data;
> +       config.driver_data = regulator;
> +       config.regmap = pmic->regmap;
> +
> +       regulator->regdev = devm_regulator_register(&pdev->dev,
> +                                                   &regulator->rdesc,
> +                                                   &config);
> +       if (IS_ERR(regulator->regdev)) {
> +               pr_err("register regulator to system error!\n");
> +               return PTR_ERR(regulator->regdev);
> +       }
> +
> +       platform_set_drvdata(pdev, regulator);
> +       return 0;
> +}
> +
> +static struct platform_driver hi655x_regulator_driver = {
> +       .driver = {
> +               .name   = "hi655x_regulator",
> +               .of_match_table = of_hi655x_regulator_match_tbl,
> +       },
> +       .probe  = hi655x_regulator_probe,
> +};
> +module_platform_driver(hi655x_regulator_driver);
> +
> +MODULE_AUTHOR("Chen Feng <puck.chen@hisilicon.com>");
> +MODULE_DESCRIPTION("Hisi hi655x regulator driver");
> +MODULE_LICENSE("GPL v2");
> diff --git a/include/linux/regulator/hi655x-regulator.h b/include/linux/regulator/hi655x-regulator.h
> new file mode 100644
> index 0000000..4a32095
> --- /dev/null
> +++ b/include/linux/regulator/hi655x-regulator.h
> @@ -0,0 +1,63 @@
> +/*
> + * Device driver for regulators in HI6553 IC
> + *
> + * Copyright (c) 2015 Hisilicon.
> + *
> + * Fei Wang  <w.f@huawei.com>
> + * Chen Feng <puck.chen@hisilicon.com>
> + *
> + * this regulator's probe function will be called lots of times,,
> + * because of there are lots of regulator nodes in dtb.
> + * so,that's say, the driver must be inited before the regulator nodes
> + * registor to system.

Something with spelling is broken here.

> + *
> + * Makefile have proved my guess, please refor to the makefile.
> + * when the code is rebuild i hope we can build pmu sub_system.
> + * init order can not base on compile

And here.




-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1263227 — [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC

FromChen Feng <puck.chen@hisilicon.com>
Date2015-11-05 15:00 +0100
Subject[PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC
Message-ID<qrtf5-7pc-27@gated-at.bofh.it>
In reply to#1263217
Add Document for mtcmos driver on hi6220 SoC

Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Fei Wang <w.f@huawei.com>
---
 .../bindings/regulator/hisilicon,hi6220-mtcmos.txt | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt

diff --git a/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt b/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt
new file mode 100644
index 0000000..bb06e1b
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt
@@ -0,0 +1,32 @@
+Hi6220 mtcmos Voltage regulators
+
+Required parent device properties:
+- compatible: Must be "hisilicon,hi6220-mtcmos-driver"
+- hisilicon,mtcmos-steady-us: The time to wait for power steady
+- hisilicon,mtcmos-sc-on-base: address of mtcmos on hi6220 SoC
+
+Required child device properties:
+- regulator-name: The name of mtcmos
+- hisilicon,ctrl-regs: Offset of ctrl-regs
+- hisilicon,ctrl-data: The bit to ctrl the regulator
+
+Example:
+        mtcmos {
+                compatible = "hisilicon,hi6220-mtcmos-driver";
+                hisilicon,mtcmos-steady-us = <10>;
+                hisilicon,mtcmos-sc-on-base  = <0xf7800000>;
+                hisilicon,mtcmos-acpu-on-base = <0xf65a0000>;
+
+                mtcmos1: regulator@a1{
+                        regulator-name = "G3D_PD_VDD";
+                        regulator-compatible = "mtcmos1";
+                        hisilicon,ctrl-regs = <0x830 0x834 0x83c>;
+                        hisilicon,ctrl-data = <1 0x1>;
+                };
+                mtcmos2: regulator@a2{
+                        regulator-name = "SOC_MED";
+                        regulator-compatible = "mtcmos2";
+                        hisilicon,ctrl-regs = <0x830 0x834 0x83c>;
+                        hisilicon,ctrl-data = <2 0x1>;
+                };
+        };
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1263240 — Re: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC

FromMark Brown <broonie@kernel.org>
Date2015-11-05 15:20 +0100
SubjectRe: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC
Message-ID<qrtyp-7M9-11@gated-at.bofh.it>
In reply to#1263227

[Multipart message — attachments visible in raw view] — view raw

On Thu, Nov 05, 2015 at 09:34:43PM +0800, Chen Feng wrote:

> +- hisilicon,mtcmos-steady-us: The time to wait for power steady
> +- hisilicon,mtcmos-sc-on-base: address of mtcmos on hi6220 SoC
> +
> +Required child device properties:
> +- regulator-name: The name of mtcmos
> +- hisilicon,ctrl-regs: Offset of ctrl-regs
> +- hisilicon,ctrl-data: The bit to ctrl the regulator

This doesn't look like a regulator binding at all...  for one thing
there's no reference to the generic regulator bindings, and having a
mandatory regulator-name seems like there's a problem somewhere.

[toc] | [prev] | [next] | [standalone]

#1263542 — Re: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC

FromRob Herring <robh@kernel.org>
Date2015-11-05 21:40 +0100
SubjectRe: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC
Message-ID<qrzua-30u-5@gated-at.bofh.it>
In reply to#1263227
On Thu, Nov 05, 2015 at 09:34:43PM +0800, Chen Feng wrote:
> Add Document for mtcmos driver on hi6220 SoC
> 
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Fei Wang <w.f@huawei.com>
> ---
>  .../bindings/regulator/hisilicon,hi6220-mtcmos.txt | 32 ++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt
> 
> diff --git a/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt b/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt
> new file mode 100644
> index 0000000..bb06e1b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt
> @@ -0,0 +1,32 @@
> +Hi6220 mtcmos Voltage regulators
> +
> +Required parent device properties:
> +- compatible: Must be "hisilicon,hi6220-mtcmos-driver"

What does "driver" refer to?

> +- hisilicon,mtcmos-steady-us: The time to wait for power steady

Wouldn't regulator-enable-ramp-delay be equivalent?


> +- hisilicon,mtcmos-sc-on-base: address of mtcmos on hi6220 SoC
> +
> +Required child device properties:
> +- regulator-name: The name of mtcmos
> +- hisilicon,ctrl-regs: Offset of ctrl-regs
> +- hisilicon,ctrl-data: The bit to ctrl the regulator
> +
> +Example:
> +        mtcmos {
> +                compatible = "hisilicon,hi6220-mtcmos-driver";
> +                hisilicon,mtcmos-steady-us = <10>;
> +                hisilicon,mtcmos-sc-on-base  = <0xf7800000>;
> +                hisilicon,mtcmos-acpu-on-base = <0xf65a0000>;
> +
> +                mtcmos1: regulator@a1{
> +                        regulator-name = "G3D_PD_VDD";
> +                        regulator-compatible = "mtcmos1";

regulator-compatible is deprecated. Please drop.

> +                        hisilicon,ctrl-regs = <0x830 0x834 0x83c>;
> +                        hisilicon,ctrl-data = <1 0x1>;
> +                };
> +                mtcmos2: regulator@a2{
> +                        regulator-name = "SOC_MED";
> +                        regulator-compatible = "mtcmos2";
> +                        hisilicon,ctrl-regs = <0x830 0x834 0x83c>;
> +                        hisilicon,ctrl-data = <2 0x1>;
> +                };
> +        };
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web