Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1263240

Re: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC
Date 2015-11-05 15:20 +0100
Message-ID <qrtyp-7M9-11@gated-at.bofh.it> (permalink)
References <qrsVH-7i3-9@gated-at.bofh.it> <qrtf5-7pc-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Nov 05, 2015 at 09:34:43PM +0800, Chen Feng wrote:

> +- hisilicon,mtcmos-steady-us: The time to wait for power steady
> +- hisilicon,mtcmos-sc-on-base: address of mtcmos on hi6220 SoC
> +
> +Required child device properties:
> +- regulator-name: The name of mtcmos
> +- hisilicon,ctrl-regs: Offset of ctrl-regs
> +- hisilicon,ctrl-data: The bit to ctrl the regulator

This doesn't look like a regulator binding at all...  for one thing
there's no reference to the generic regulator bindings, and having a
mandatory regulator-name seems like there's a problem somewhere.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/7] Add Support for Hi6220 PMIC Hi6553 MFD Core Chen Feng <puck.chen@hisilicon.com> - 2015-11-05 14:50 +0100
  [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage regulator driver Chen Feng <puck.chen@hisilicon.com> - 2015-11-05 15:00 +0100
    Re: [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage  regulator driver Mark Brown <broonie@kernel.org> - 2015-11-05 16:30 +0100
    Re: [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage  regulator driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-06 22:30 +0100
  [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC Chen Feng <puck.chen@hisilicon.com> - 2015-11-05 15:00 +0100
    Re: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220  SoC Mark Brown <broonie@kernel.org> - 2015-11-05 15:20 +0100
    Re: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220  SoC Rob Herring <robh@kernel.org> - 2015-11-05 21:40 +0100

csiph-web