Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1263103 > unrolled thread

[RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

Started byMasahiro Yamada <yamada.masahiro@socionext.com>
First post2015-11-05 12:20 +0100
Last post2015-11-06 11:30 +0100
Articles 8 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-05 12:20 +0100
    Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on  RESET_CONTROLLER" Mark Brown <broonie@kernel.org> - 2015-11-05 13:10 +0100
      Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-05 13:20 +0100
        Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on  RESET_CONTROLLER" Mark Brown <broonie@kernel.org> - 2015-11-05 13:30 +0100
          Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-05 13:40 +0100
            Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on  RESET_CONTROLLER" Mark Brown <broonie@kernel.org> - 2015-11-05 16:10 +0100
              Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-06 07:10 +0100
                Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on  RESET_CONTROLLER" Mark Brown <broonie@kernel.org> - 2015-11-06 11:30 +0100

#1263103 — [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2015-11-05 12:20 +0100
Subject[RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"
Message-ID<qrqKe-5R7-9@gated-at.bofh.it>
ARCH_SUNXI selects RESET_CONTROLLER.
The dependency "depends on RESET_CONTROLLER" is already met.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/spi/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 4887f31..604ffab 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -536,7 +536,6 @@ config SPI_SUN4I
 config SPI_SUN6I
 	tristate "Allwinner A31 SPI controller"
 	depends on ARCH_SUNXI || COMPILE_TEST
-	depends on RESET_CONTROLLER
 	help
 	  This enables using the SPI controller on the Allwinner A31 SoCs.
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1263157 — Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

FromMark Brown <broonie@kernel.org>
Date2015-11-05 13:10 +0100
SubjectRe: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"
Message-ID<qrrwB-6v5-11@gated-at.bofh.it>
In reply to#1263103

[Multipart message — attachments visible in raw view] — view raw

On Thu, Nov 05, 2015 at 08:15:23PM +0900, Masahiro Yamada wrote:
> ARCH_SUNXI selects RESET_CONTROLLER.
> The dependency "depends on RESET_CONTROLLER" is already met.

No, it isn't.

>  config SPI_SUN6I
>  	tristate "Allwinner A31 SPI controller"
>  	depends on ARCH_SUNXI || COMPILE_TEST
> -	depends on RESET_CONTROLLER

The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
ARCH_SUNXI.

[toc] | [prev] | [next] | [standalone]

#1263164

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2015-11-05 13:20 +0100
Message-ID<qrrGi-6Az-7@gated-at.bofh.it>
In reply to#1263157
2015-11-05 20:28 GMT+09:00 Mark Brown <broonie@kernel.org>:
> On Thu, Nov 05, 2015 at 08:15:23PM +0900, Masahiro Yamada wrote:
>> ARCH_SUNXI selects RESET_CONTROLLER.
>> The dependency "depends on RESET_CONTROLLER" is already met.
>
> No, it isn't.
>
>>  config SPI_SUN6I
>>       tristate "Allwinner A31 SPI controller"
>>       depends on ARCH_SUNXI || COMPILE_TEST
>> -     depends on RESET_CONTROLLER
>
> The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
> ARCH_SUNXI.


The compile test of this driver should pass even if RESET_CONTROLLER
is not defined.
So, it does not matter for COMPILE_TEST.




-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1263172 — Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

FromMark Brown <broonie@kernel.org>
Date2015-11-05 13:30 +0100
SubjectRe: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"
Message-ID<qrrPY-6Ed-13@gated-at.bofh.it>
In reply to#1263164

[Multipart message — attachments visible in raw view] — view raw

On Thu, Nov 05, 2015 at 09:11:47PM +0900, Masahiro Yamada wrote:
> 2015-11-05 20:28 GMT+09:00 Mark Brown <broonie@kernel.org>:

> > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
> > ARCH_SUNXI.

> The compile test of this driver should pass even if RESET_CONTROLLER
> is not defined.
> So, it does not matter for COMPILE_TEST.

If that is the case then the change here is that the dependency on
RESET_CONTROLLER is just redundant which isn't what the commit message
says.

[toc] | [prev] | [next] | [standalone]

#1263177

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2015-11-05 13:40 +0100
Message-ID<qrrZE-6Hq-15@gated-at.bofh.it>
In reply to#1263172
2015-11-05 21:20 GMT+09:00 Mark Brown <broonie@kernel.org>:
> On Thu, Nov 05, 2015 at 09:11:47PM +0900, Masahiro Yamada wrote:
>> 2015-11-05 20:28 GMT+09:00 Mark Brown <broonie@kernel.org>:
>
>> > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
>> > ARCH_SUNXI.
>
>> The compile test of this driver should pass even if RESET_CONTROLLER
>> is not defined.
>> So, it does not matter for COMPILE_TEST.
>
> If that is the case then the change here is that the dependency on
> RESET_CONTROLLER is just redundant which isn't what the commit message
> says.

For compile test, right, "depends on RESET_CONTROLLER" is
redundant in the first place.

For run-time on real SoCs,the driver failed at the following point
without the reset-controller sub-system.


    sspi->rstc = devm_reset_control_get(&pdev->dev, NULL);
    if (IS_ERR(sspi->rstc)) {
            dev_err(&pdev->dev, "Couldn't get reset controller\n");
            ret = PTR_ERR(sspi->rstc);
            goto err_free_master;
    }




-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1263314 — Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

FromMark Brown <broonie@kernel.org>
Date2015-11-05 16:10 +0100
SubjectRe: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"
Message-ID<qrukO-8kv-19@gated-at.bofh.it>
In reply to#1263177

[Multipart message — attachments visible in raw view] — view raw

On Thu, Nov 05, 2015 at 09:32:15PM +0900, Masahiro Yamada wrote:

> For compile test, right, "depends on RESET_CONTROLLER" is
> redundant in the first place.

> For run-time on real SoCs,the driver failed at the following point
> without the reset-controller sub-system.

Your changelog needs to say this clearly, right now what it's saying
clearly doesn't correspond to what the change does.

[toc] | [prev] | [next] | [standalone]

#1263754

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2015-11-06 07:10 +0100
Message-ID<qrInL-JI-7@gated-at.bofh.it>
In reply to#1263314
2015-11-06 0:05 GMT+09:00 Mark Brown <broonie@kernel.org>:
> On Thu, Nov 05, 2015 at 09:32:15PM +0900, Masahiro Yamada wrote:
>
>> For compile test, right, "depends on RESET_CONTROLLER" is
>> redundant in the first place.
>
>> For run-time on real SoCs,the driver failed at the following point
>> without the reset-controller sub-system.
>
> Your changelog needs to say this clearly, right now what it's saying
> clearly doesn't correspond to what the change does.

OK.

This series is RFC and my main focus in on the 1/7.
I will wait for more comments against the first one.


-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1263902 — Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

FromMark Brown <broonie@kernel.org>
Date2015-11-06 11:30 +0100
SubjectRe: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"
Message-ID<qrMro-3f3-21@gated-at.bofh.it>
In reply to#1263754

[Multipart message — attachments visible in raw view] — view raw

On Fri, Nov 06, 2015 at 03:00:04PM +0900, Masahiro Yamada wrote:
> 2015-11-06 0:05 GMT+09:00 Mark Brown <broonie@kernel.org>:

> > Your changelog needs to say this clearly, right now what it's saying
> > clearly doesn't correspond to what the change does.

> OK.

> This series is RFC and my main focus in on the 1/7.
> I will wait for more comments against the first one.

You didn't send that patch to most of the recipients so I've no idea
what that is...

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web