Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1263164

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

From Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"
Date 2015-11-05 13:20 +0100
Message-ID <qrrGi-6Az-7@gated-at.bofh.it> (permalink)
References <qrqKe-5R7-5@gated-at.bofh.it> <qrqKe-5R7-9@gated-at.bofh.it> <qrrwB-6v5-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


2015-11-05 20:28 GMT+09:00 Mark Brown <broonie@kernel.org>:
> On Thu, Nov 05, 2015 at 08:15:23PM +0900, Masahiro Yamada wrote:
>> ARCH_SUNXI selects RESET_CONTROLLER.
>> The dependency "depends on RESET_CONTROLLER" is already met.
>
> No, it isn't.
>
>>  config SPI_SUN6I
>>       tristate "Allwinner A31 SPI controller"
>>       depends on ARCH_SUNXI || COMPILE_TEST
>> -     depends on RESET_CONTROLLER
>
> The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
> ARCH_SUNXI.


The compile test of this driver should pass even if RESET_CONTROLLER
is not defined.
So, it does not matter for COMPILE_TEST.




-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-05 12:20 +0100
  Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on  RESET_CONTROLLER" Mark Brown <broonie@kernel.org> - 2015-11-05 13:10 +0100
    Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-05 13:20 +0100
      Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on  RESET_CONTROLLER" Mark Brown <broonie@kernel.org> - 2015-11-05 13:30 +0100
        Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-05 13:40 +0100
          Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on  RESET_CONTROLLER" Mark Brown <broonie@kernel.org> - 2015-11-05 16:10 +0100
            Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-06 07:10 +0100
              Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on  RESET_CONTROLLER" Mark Brown <broonie@kernel.org> - 2015-11-06 11:30 +0100

csiph-web