Groups > linux.kernel > #1260322 > unrolled thread

Re: make xconfig no longer works in Fedora

Started by	Thiago Macieira <thiago.macieira@intel.com>
First post	2015-11-02 04:30 +0100
Last post	2015-11-02 21:50 +0100
Articles	9 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

  Re: make xconfig no longer works in Fedora Thiago Macieira <thiago.macieira@intel.com> - 2015-11-02 04:30 +0100
    Re: make xconfig no longer works in Fedora Michal Marek <mmarek@suse.com> - 2015-11-02 11:40 +0100
      Re: make xconfig no longer works in Fedora Thiago Macieira <thiago.macieira@intel.com> - 2015-11-02 14:50 +0100
        Re: make xconfig no longer works in Fedora Michal Marek <mmarek@suse.com> - 2015-11-02 17:00 +0100
          Re: make xconfig no longer works in Fedora Michal Marek <mmarek@suse.com> - 2015-11-02 17:10 +0100
          Re: make xconfig no longer works in Fedora Thiago Macieira <thiago.macieira@intel.com> - 2015-11-02 17:10 +0100
            Re: make xconfig no longer works in Fedora Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-11-02 17:30 +0100
              Re: make xconfig no longer works in Fedora Michal Marek <mmarek@suse.com> - 2015-11-02 21:40 +0100
                Re: make xconfig no longer works in Fedora Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-11-02 21:50 +0100

#1260322 — Re: make xconfig no longer works in Fedora

From	Thiago Macieira <thiago.macieira@intel.com>
Date	2015-11-02 04:30 +0100
Subject	Re: make xconfig no longer works in Fedora
Message-ID	<qqdYK-cb-1@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On Saturday 31 October 2015 12:39:21 Alexey Brodkin wrote:
> Hi Thiago,
> 
> I noticed that with your patch "Update the buildsystem for KConfig finding
> Qt"
> I cannot use "make xconfig" in Fedora 22 any longer.

Hello Alexey

> The reason why xconfig target fails is in Fedora (at least its recent
> versions)
> there's no "qmake". Instead there're "qmake-qt4" and/or
> "qmake-qt5" depending on which Qt packages are installed.

Hmm... you're right. There's no check for a program with a different name in 
the new Makefile. I apologise, I never tested that case.

Fedora is knowingly deviating from Qt Project recommendations. I will fix 
this, but please file a bug report against their Qt packages so there's some 
pressure to adopt a standard solution that everyone else already does.

> But IMHO it would be really nice if we don't break things that used to
> work.

Right. Can you try the attached patch to see if it solves the problem for you?

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

[toc] | [next] | [standalone]

#1260524

From	Michal Marek <mmarek@suse.com>
Date	2015-11-02 11:40 +0100
Message-ID	<qqkGR-4bJ-5@gated-at.bofh.it>
In reply to	#1260322

On 2015-11-02 04:20, Thiago Macieira wrote:
> -	qtver=`qmake -query QT_VERSION` || { \
> +	qtver=`qmake -query QT_VERSION` || \
> +	qtver=`qmake-qt5 -query QT_VERSION` || \
> +	qtver=`qmake-qt4 -query QT_VERSION` || { \

The qtlibdir= etc assignments below still use qmake directly, plus this
will print an error if the command is not called "qmake." As Alexey
says, we do not need qmake, we need moc and the cflags / ldflags. Since
pkg-config worked for us previously, I suggest to use pkg-config again
and just check which of QtGui or Qt5Widgets is available.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260652

From	Thiago Macieira <thiago.macieira@intel.com>
Date	2015-11-02 14:50 +0100
Message-ID	<qqnEK-5VS-11@gated-at.bofh.it>
In reply to	#1260524

[Multipart message — attachments visible in raw view] — view raw

On Monday 02 November 2015 11:36:43 Michal Marek wrote:
> On 2015-11-02 04:20, Thiago Macieira wrote:
> > -	qtver=`qmake -query QT_VERSION` || { \
> > +	qtver=`qmake -query QT_VERSION` || \
> > +	qtver=`qmake-qt5 -query QT_VERSION` || \
> > +	qtver=`qmake-qt4 -query QT_VERSION` || { \
> 
> The qtlibdir= etc assignments below still use qmake directly, plus this
> will print an error if the command is not called "qmake." As Alexey
> says, we do not need qmake, we need moc and the cflags / ldflags. Since
> pkg-config worked for us previously, I suggest to use pkg-config again
> and just check which of QtGui or Qt5Widgets is available.

Here's an attempt using pkg-config.
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1260745

From	Michal Marek <mmarek@suse.com>
Date	2015-11-02 17:00 +0100
Message-ID	<qqpGy-77v-21@gated-at.bofh.it>
In reply to	#1260652

On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote:
> On Monday 02 November 2015 11:36:43 Michal Marek wrote:
> > On 2015-11-02 04:20, Thiago Macieira wrote:
> > > -	qtver=`qmake -query QT_VERSION` || { \
> > > +	qtver=`qmake -query QT_VERSION` || \
> > > +	qtver=`qmake-qt5 -query QT_VERSION` || \
> > > +	qtver=`qmake-qt4 -query QT_VERSION` || { \
> > 
> > The qtlibdir= etc assignments below still use qmake directly, plus this
> > will print an error if the command is not called "qmake." As Alexey
> > says, we do not need qmake, we need moc and the cflags / ldflags. Since
> > pkg-config worked for us previously, I suggest to use pkg-config again
> > and just check which of QtGui or Qt5Widgets is available.
> 
> Here's an attempt using pkg-config.

Works for me on openSUSE, it just started to prefer Qt5 now. But it
correctly builds against Qt4 if Qt5 is not available.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260749

From	Michal Marek <mmarek@suse.com>
Date	2015-11-02 17:10 +0100
Message-ID	<qqpQe-7rc-7@gated-at.bofh.it>
In reply to	#1260745

On 2015-11-02 17:01, Thiago Macieira wrote:
> On Monday 02 November 2015 16:50:33 Michal Marek wrote:
>> On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote:
>>> On Monday 02 November 2015 11:36:43 Michal Marek wrote:
>>>> On 2015-11-02 04:20, Thiago Macieira wrote:
>>>>> -	qtver=`qmake -query QT_VERSION` || { \
>>>>> +	qtver=`qmake -query QT_VERSION` || \
>>>>> +	qtver=`qmake-qt5 -query QT_VERSION` || \
>>>>> +	qtver=`qmake-qt4 -query QT_VERSION` || { \
>>>>
>>>> The qtlibdir= etc assignments below still use qmake directly, plus this
>>>> will print an error if the command is not called "qmake." As Alexey
>>>> says, we do not need qmake, we need moc and the cflags / ldflags. Since
>>>> pkg-config worked for us previously, I suggest to use pkg-config again
>>>> and just check which of QtGui or Qt5Widgets is available.
>>>
>>> Here's an attempt using pkg-config.
>>
>> Works for me on openSUSE, it just started to prefer Qt5 now. But it
>> correctly builds against Qt4 if Qt5 is not available.
> 
> That's a consequence of using pkg-config. Now you can no longer choose your 
> preferred Qt version by setting QT_SELECT, like the qmake solution would have 
> allowed, as recommended by the Qt Project.

Yeah, but I think this is acceptable for an application like qconf. Use
best effort to build against some Qt version to let the user configure
their kernel.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260754

From	Thiago Macieira <thiago.macieira@intel.com>
Date	2015-11-02 17:10 +0100
Message-ID	<qqpQe-7rc-9@gated-at.bofh.it>
In reply to	#1260745

On Monday 02 November 2015 16:50:33 Michal Marek wrote:
> On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote:
> > On Monday 02 November 2015 11:36:43 Michal Marek wrote:
> > > On 2015-11-02 04:20, Thiago Macieira wrote:
> > > > -	qtver=`qmake -query QT_VERSION` || { \
> > > > +	qtver=`qmake -query QT_VERSION` || \
> > > > +	qtver=`qmake-qt5 -query QT_VERSION` || \
> > > > +	qtver=`qmake-qt4 -query QT_VERSION` || { \
> > > 
> > > The qtlibdir= etc assignments below still use qmake directly, plus this
> > > will print an error if the command is not called "qmake." As Alexey
> > > says, we do not need qmake, we need moc and the cflags / ldflags. Since
> > > pkg-config worked for us previously, I suggest to use pkg-config again
> > > and just check which of QtGui or Qt5Widgets is available.
> > 
> > Here's an attempt using pkg-config.
> 
> Works for me on openSUSE, it just started to prefer Qt5 now. But it
> correctly builds against Qt4 if Qt5 is not available.

That's a consequence of using pkg-config. Now you can no longer choose your 
preferred Qt version by setting QT_SELECT, like the qmake solution would have 
allowed, as recommended by the Qt Project. At least, the qtchooser shell 
function extension does set PKG_CONFIG_PATH, so if you  install a different 
version elsewhere, that version should be picked up.

It would have been the same with CMake too, btw.

Alexey, did this solve the problem for you?
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260772

From	Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Date	2015-11-02 17:30 +0100
Message-ID	<qqq9B-7xI-23@gated-at.bofh.it>
In reply to	#1260754

SGkgVGhpYWdvLA0KDQpPbiBNb24sIDIwMTUtMTEtMDIgYXQgMTE6MDEgLTA1MDAsIFRoaWFnbyBN
YWNpZWlyYSB3cm90ZToNCj4gT24gTW9uZGF5IDAyIE5vdmVtYmVyIDIwMTUgMTY6NTA6MzMgTWlj
aGFsIE1hcmVrIHdyb3RlOg0KPiA+IE9uIE1vbiwgTm92IDAyLCAyMDE1IGF0IDA4OjQ2OjU1QU0g
LTA1MDAsIFRoaWFnbyBNYWNpZWlyYSB3cm90ZToNCj4gPiA+IE9uIE1vbmRheSAwMiBOb3ZlbWJl
ciAyMDE1IDExOjM2OjQzIE1pY2hhbCBNYXJlayB3cm90ZToNCj4gPiA+ID4gT24gMjAxNS0xMS0w
MiAwNDoyMCwgVGhpYWdvIE1hY2llaXJhIHdyb3RlOg0KPiA+ID4gPiA+IC0JcXR2ZXI9YHFtYWtl
IC1xdWVyeSBRVF9WRVJTSU9OYCB8fCB7IFwNCj4gPiA+ID4gPiArCXF0dmVyPWBxbWFrZSAtcXVl
cnkgUVRfVkVSU0lPTmAgfHwgXA0KPiA+ID4gPiA+ICsJcXR2ZXI9YHFtYWtlLXF0NSAtcXVlcnkg
UVRfVkVSU0lPTmAgfHwgXA0KPiA+ID4gPiA+ICsJcXR2ZXI9YHFtYWtlLXF0NCAtcXVlcnkgUVRf
VkVSU0lPTmAgfHwgeyBcDQo+ID4gPiA+IA0KPiA+ID4gPiBUaGUgcXRsaWJkaXI9IGV0YyBhc3Np
Z25tZW50cyBiZWxvdyBzdGlsbCB1c2UgcW1ha2UgZGlyZWN0bHksIHBsdXMgdGhpcw0KPiA+ID4g
PiB3aWxsIHByaW50IGFuIGVycm9yIGlmIHRoZSBjb21tYW5kIGlzIG5vdCBjYWxsZWQgInFtYWtl
LiIgQXMgQWxleGV5DQo+ID4gPiA+IHNheXMsIHdlIGRvIG5vdCBuZWVkIHFtYWtlLCB3ZSBuZWVk
IG1vYyBhbmQgdGhlIGNmbGFncyAvIGxkZmxhZ3MuIFNpbmNlDQo+ID4gPiA+IHBrZy1jb25maWcg
d29ya2VkIGZvciB1cyBwcmV2aW91c2x5LCBJIHN1Z2dlc3QgdG8gdXNlIHBrZy1jb25maWcgYWdh
aW4NCj4gPiA+ID4gYW5kIGp1c3QgY2hlY2sgd2hpY2ggb2YgUXRHdWkgb3IgUXQ1V2lkZ2V0cyBp
cyBhdmFpbGFibGUuDQo+ID4gPiANCj4gPiA+IEhlcmUncyBhbiBhdHRlbXB0IHVzaW5nIHBrZy1j
b25maWcuDQo+ID4gDQo+ID4gV29ya3MgZm9yIG1lIG9uIG9wZW5TVVNFLCBpdCBqdXN0IHN0YXJ0
ZWQgdG8gcHJlZmVyIFF0NSBub3cuIEJ1dCBpdA0KPiA+IGNvcnJlY3RseSBidWlsZHMgYWdhaW5z
dCBRdDQgaWYgUXQ1IGlzIG5vdCBhdmFpbGFibGUuDQo+IA0KPiBUaGF0J3MgYSBjb25zZXF1ZW5j
ZSBvZiB1c2luZyBwa2ctY29uZmlnLiBOb3cgeW91IGNhbiBubyBsb25nZXIgY2hvb3NlIHlvdXIg
DQo+IHByZWZlcnJlZCBRdCB2ZXJzaW9uIGJ5IHNldHRpbmcgUVRfU0VMRUNULCBsaWtlIHRoZSBx
bWFrZSBzb2x1dGlvbiB3b3VsZCBoYXZlIA0KPiBhbGxvd2VkLCBhcyByZWNvbW1lbmRlZCBieSB0
aGUgUXQgUHJvamVjdC4gQXQgbGVhc3QsIHRoZSBxdGNob29zZXIgc2hlbGwgDQo+IGZ1bmN0aW9u
IGV4dGVuc2lvbiBkb2VzIHNldCBQS0dfQ09ORklHX1BBVEgsIHNvIGlmIHlvdSAgaW5zdGFsbCBh
IGRpZmZlcmVudCANCj4gdmVyc2lvbiBlbHNld2hlcmUsIHRoYXQgdmVyc2lvbiBzaG91bGQgYmUg
cGlja2VkIHVwLg0KPiANCj4gSXQgd291bGQgaGF2ZSBiZWVuIHRoZSBzYW1lIHdpdGggQ01ha2Ug
dG9vLCBidHcuDQo+IA0KPiBBbGV4ZXksIGRpZCB0aGlzIHNvbHZlIHRoZSBwcm9ibGVtIGZvciB5
b3U/DQoNClllcCwgdGhhbmtzIGEgbG90Lg0KIm1ha2UgeGNvbmZpZyIgbm93IHdvcmtzIGZvciBt
ZSENCg0KLUFsZXhleQ==
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260951

From	Michal Marek <mmarek@suse.com>
Date	2015-11-02 21:40 +0100
Message-ID	<qqu3w-1uH-17@gated-at.bofh.it>
In reply to	#1260772

Dne 2.11.2015 v 17:28 Alexey Brodkin napsal(a):
> On Mon, 2015-11-02 at 11:01 -0500, Thiago Macieira wrote:
>> Alexey, did this solve the problem for you?
> 
> Yep, thanks a lot.
> "make xconfig" now works for me!

Thanks for testing, I will apply it to kbuild.git#kconfig.

Thanks,
Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260960

From	Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Date	2015-11-02 21:50 +0100
Message-ID	<qqudc-1yk-9@gated-at.bofh.it>
In reply to	#1260951

SGkgTWljaGFsLA0KDQpPbiBNb24sIDIwMTUtMTEtMDIgYXQgMjE6MzggKzAxMDAsIE1pY2hhbCBN
YXJlayB3cm90ZToNCj4gRG5lIDIuMTEuMjAxNSB2IDE3OjI4IEFsZXhleSBCcm9ka2luIG5hcHNh
bChhKToNCj4gPiBPbiBNb24sIDIwMTUtMTEtMDIgYXQgMTE6MDEgLTA1MDAsIFRoaWFnbyBNYWNp
ZWlyYSB3cm90ZToNCj4gPiA+IEFsZXhleSwgZGlkIHRoaXMgc29sdmUgdGhlIHByb2JsZW0gZm9y
IHlvdT8NCj4gPiANCj4gPiBZZXAsIHRoYW5rcyBhIGxvdC4NCj4gPiAibWFrZSB4Y29uZmlnIiBu
b3cgd29ya3MgZm9yIG1lIQ0KPiANCj4gVGhhbmtzIGZvciB0ZXN0aW5nLCBJIHdpbGwgYXBwbHkg
aXQgdG8ga2J1aWxkLmdpdCNrY29uZmlnLg0KDQpUaGFuayB5b3UgZm9yIGRvaW5nIHRoaXMuDQoN
CkZlZWwgZnJlZSB0byBhZGQgIkFja2VkLWJ5OiBBbGV4ZXkgQnJvZGtpbiA8YWJyb2RraW5Ac3lu
b3BzeXMuY29tPiINCg0KLUFsZXhleQ==
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

csiph-web

Re: make xconfig no longer works in Fedora

Contents

#1260322 — Re: make xconfig no longer works in Fedora

#1260524

#1260652

#1260745

#1260749

#1260754

#1260772

#1260951

#1260960