Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1260749

Re: make xconfig no longer works in Fedora

Show all headers | View raw

On 2015-11-02 17:01, Thiago Macieira wrote:
> On Monday 02 November 2015 16:50:33 Michal Marek wrote:
>> On Mon, Nov 02, 2015 at 08:46:55AM -0500, Thiago Macieira wrote:
>>> On Monday 02 November 2015 11:36:43 Michal Marek wrote:
>>>> On 2015-11-02 04:20, Thiago Macieira wrote:
>>>>> -	qtver=`qmake -query QT_VERSION` || { \
>>>>> +	qtver=`qmake -query QT_VERSION` || \
>>>>> +	qtver=`qmake-qt5 -query QT_VERSION` || \
>>>>> +	qtver=`qmake-qt4 -query QT_VERSION` || { \
>>>>
>>>> The qtlibdir= etc assignments below still use qmake directly, plus this
>>>> will print an error if the command is not called "qmake." As Alexey
>>>> says, we do not need qmake, we need moc and the cflags / ldflags. Since
>>>> pkg-config worked for us previously, I suggest to use pkg-config again
>>>> and just check which of QtGui or Qt5Widgets is available.
>>>
>>> Here's an attempt using pkg-config.
>>
>> Works for me on openSUSE, it just started to prefer Qt5 now. But it
>> correctly builds against Qt4 if Qt5 is not available.
> 
> That's a consequence of using pkg-config. Now you can no longer choose your 
> preferred Qt version by setting QT_SELECT, like the qmake solution would have 
> allowed, as recommended by the Qt Project.

Yeah, but I think this is acceptable for an application like qconf. Use
best effort to build against some Qt version to let the user configure
their kernel.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: make xconfig no longer works in Fedora Thiago Macieira <thiago.macieira@intel.com> - 2015-11-02 04:30 +0100
  Re: make xconfig no longer works in Fedora Michal Marek <mmarek@suse.com> - 2015-11-02 11:40 +0100
    Re: make xconfig no longer works in Fedora Thiago Macieira <thiago.macieira@intel.com> - 2015-11-02 14:50 +0100
      Re: make xconfig no longer works in Fedora Michal Marek <mmarek@suse.com> - 2015-11-02 17:00 +0100
        Re: make xconfig no longer works in Fedora Michal Marek <mmarek@suse.com> - 2015-11-02 17:10 +0100
        Re: make xconfig no longer works in Fedora Thiago Macieira <thiago.macieira@intel.com> - 2015-11-02 17:10 +0100
          Re: make xconfig no longer works in Fedora Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-11-02 17:30 +0100
            Re: make xconfig no longer works in Fedora Michal Marek <mmarek@suse.com> - 2015-11-02 21:40 +0100
              Re: make xconfig no longer works in Fedora Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-11-02 21:50 +0100

csiph-web