Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1260610 > unrolled thread

[PATCH 01/22] clocksource/drivers/pistachio: Add the COMPILE_TEST option

Started byDaniel Lezcano <daniel.lezcano@linaro.org>
First post2015-11-02 14:00 +0100
Last post2015-11-02 14:10 +0100
Articles 14 on this page of 34 — 6 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 01/22] clocksource/drivers/pistachio: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
    [PATCH 02/22] clocksource/drivers/mediatek: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
    [PATCH 12/22] clocksource/drivers/tegra2: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
    [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
      Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 01:40 +0100
        Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 02:00 +0100
          Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 09:50 +0100
            Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Arnd Bergmann <arnd@arndb.de> - 2015-11-03 11:10 +0100
              Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 12:10 +0100
              Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 13:10 +0100
                Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 13:10 +0100
              Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option John Stultz <john.stultz@linaro.org> - 2015-11-03 17:10 +0100
      Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-03 02:00 +0100
    [PATCH 13/22] clocksource/drivers/vt8500: Remove unneeded header Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
    [PATCH 06/22] clocksource/drivers/meson6: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
    [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
      Re: [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add  COMPILE_TEST option Linus Walleij <linus.walleij@linaro.org> - 2015-11-02 15:50 +0100
        Re: [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add  COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 16:00 +0100
    [PATCH 08/22] clocksource/drivers/digicolor: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
    [PATCH 07/22] clocksource/drivers/orion: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
    [PATCH 15/22] clocksource/drivers/cadence_ttc: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
    [PATCH 17/22] clocksource/drivers/lpc32xx: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
    [PATCH 11/22] clocksource/drivers/sun5i: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
    [PATCH 22/22] clocksource/drivers/fsl-ftm: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
    [PATCH 16/22] clocksource/drivers/asm9260: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
    [PATCH 18/22] clocksource/drivers/nomadik_mtu: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
    [PATCH 04/22] clocksource/drivers/rockchip: Add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
    [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
      Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Arnd Bergmann <arnd@arndb.de> - 2015-11-02 16:40 +0100
        Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more  compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 17:40 +0100
          Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Arnd Bergmann <arnd@arndb.de> - 2015-11-02 22:50 +0100
    [PATCH 14/22] clocksource/drivers/vt8500: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
    [PATCH 09/22] clocksource/drivers/dw_apb: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
    [PATCH 21/22] clocksource/drivers/samsung-pwm: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100

Page 2 of 2 — ← Prev page 1 [2]

#1260622 — [PATCH 15/22] clocksource/drivers/cadence_ttc: Add the COMPILE_TEST option

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-02 14:10 +0100
Subject[PATCH 15/22] clocksource/drivers/cadence_ttc: Add the COMPILE_TEST option
Message-ID<qqn22-5Jb-19@gated-at.bofh.it>
In reply to#1260610
Increase the compilation test coverage by adding the COMPILE_TEST option.

The driver depends on the common clock framework, thus the dependency added
on COMMON_CLK.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index b0136fc..b631b14 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -86,7 +86,10 @@ config VT8500_TIMER
 	  Enables support for the VT8500 driver.
 
 config CADENCE_TTC_TIMER
-	bool
+	bool "Cadence TTC timer driver" if COMPILE_TEST
+	depends on COMMON_CLK
+	help
+	  Enables support for the cadence ttc driver.
 
 config ASM9260_TIMER
 	bool
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260623 — [PATCH 17/22] clocksource/drivers/lpc32xx: Add the COMPILE_TEST option

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-02 14:10 +0100
Subject[PATCH 17/22] clocksource/drivers/lpc32xx: Add the COMPILE_TEST option
Message-ID<qqn22-5Jb-25@gated-at.bofh.it>
In reply to#1260610
Increase the compilation test coverage by adding the COMPILE_TEST option.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index f6a1c3e..31ba1c2 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -137,9 +137,11 @@ config CLKSRC_EFM32
 	  event device.
 
 config CLKSRC_LPC32XX
-	bool
+	bool "Clocksource for LPC32XX" if COMPILE_TEST
 	select CLKSRC_MMIO
 	select CLKSRC_OF
+	help
+	  Support for the LPC32XX clocksource.
 
 config CLKSRC_PISTACHIO
 	bool "Clocksource for Pistachio SoC" if COMPILE_TEST
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260624 — [PATCH 11/22] clocksource/drivers/sun5i: Add the COMPILE_TEST option

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-02 14:10 +0100
Subject[PATCH 11/22] clocksource/drivers/sun5i: Add the COMPILE_TEST option
Message-ID<qqn22-5Jb-27@gated-at.bofh.it>
In reply to#1260610
Increase the compilation test coverage by adding the COMPILE_TEST option.

The driver depends on the common clock framework, thus the dependency added
on COMMON_CLK.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 4c0daae..58dabd3 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -68,8 +68,11 @@ config SUN4I_TIMER
 	  Enables support for the Sun4i timer.
 
 config SUN5I_HSTIMER
+	bool "Sun5i timer driver" if COMPILE_TEST
 	select CLKSRC_MMIO
-	bool
+	depends on COMMON_CLK
+	help
+	  Enables support the Sun5i timer.
 
 config TEGRA_TIMER
 	bool
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260626 — [PATCH 22/22] clocksource/drivers/fsl-ftm: Add the COMPILE_TEST option

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-02 14:10 +0100
Subject[PATCH 22/22] clocksource/drivers/fsl-ftm: Add the COMPILE_TEST option
Message-ID<qqn22-5Jb-33@gated-at.bofh.it>
In reply to#1260610
Increase the compilation test coverage by adding the COMPILE_TEST option.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 8f2a3fb..d199f48 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -227,7 +227,7 @@ config CLKSRC_SAMSUNG_PWM
 	  needed only on systems that do not have the Exynos MCT available.
 
 config FSL_FTM_TIMER
-	bool
+	bool "Freescale FlexTimer Module driver" if COMPILE_TEST
 	help
 	  Support for Freescale FlexTimer Module (FTM) timer.
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260628 — [PATCH 16/22] clocksource/drivers/asm9260: Add the COMPILE_TEST option

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-02 14:10 +0100
Subject[PATCH 16/22] clocksource/drivers/asm9260: Add the COMPILE_TEST option
Message-ID<qqn23-5Jb-43@gated-at.bofh.it>
In reply to#1260610
Increase the compilation test coverage by adding the COMPILE_TEST option.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index b631b14..f6a1c3e 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -92,9 +92,11 @@ config CADENCE_TTC_TIMER
 	  Enables support for the cadence ttc driver.
 
 config ASM9260_TIMER
-	bool
+	bool "ASM9260 timer driver" if COMPILE_TEST
 	select CLKSRC_MMIO
 	select CLKSRC_OF
+	help
+	  Enables support for the ASM9260 timer.
 
 config CLKSRC_NOMADIK_MTU
 	bool
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260629 — [PATCH 18/22] clocksource/drivers/nomadik_mtu: Add the COMPILE_TEST option

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-02 14:10 +0100
Subject[PATCH 18/22] clocksource/drivers/nomadik_mtu: Add the COMPILE_TEST option
Message-ID<qqn23-5Jb-45@gated-at.bofh.it>
In reply to#1260610
Increase the compilation test coverage by adding the COMPILE_TEST option.

Due to the non portable code for the delay timer, this option is only
available for the ARM architecture.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 31ba1c2..17674b4 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -99,8 +99,8 @@ config ASM9260_TIMER
 	  Enables support for the ASM9260 timer.
 
 config CLKSRC_NOMADIK_MTU
-	bool
-	depends on (ARCH_NOMADIK || ARCH_U8500)
+	bool "Nomakdik clocksource driver" if COMPILE_TEST
+	depends on ARM
 	select CLKSRC_MMIO
 	help
 	  Support for Multi Timer Unit. MTU provides access
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260630 — [PATCH 04/22] clocksource/drivers/rockchip: Add COMPILE_TEST option

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-02 14:10 +0100
Subject[PATCH 04/22] clocksource/drivers/rockchip: Add COMPILE_TEST option
Message-ID<qqn24-5Jb-49@gated-at.bofh.it>
In reply to#1260610
Increase the compilation test coverage by adding the COMPILE_TEST option.

Due to the dsb() usage in the driver, this driver is only compilable on
ARM and ARM64.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index dc79fde..6f85622 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -30,8 +30,11 @@ config DW_APB_TIMER_OF
 	select CLKSRC_OF
 
 config ROCKCHIP_TIMER
-	bool
+	bool "Rockchip timer driver" if COMPILE_TEST
+	depends on ARM || ARM64
 	select CLKSRC_OF
+	help
+	  Enables the support for the rockchip timer driver.
 
 config ARMADA_370_XP_TIMER
 	bool
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260632 — [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-02 14:10 +0100
Subject[PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible
Message-ID<qqn24-5Jb-61@gated-at.bofh.it>
In reply to#1260610
From: Caesar Wang <wxt@rock-chips.com>

Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform,
There are some failure with build up on timer driver for rockchip.

Says:
/tmp/ccdAnNy5.s:47: Error: missing immediate expression at  operand 1 --
`dsb`
...

The problem was different semantics of dsb on btw arm32 and arm64,
Here we can convert the dsb with insteading of dsb(sy).The "sy" param
is the default which you are allow to omit, so on arm32 dsb()and dsb(sy)
are the same.

Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/rockchip_timer.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c
index d3c1742..724c321 100644
--- a/drivers/clocksource/rockchip_timer.c
+++ b/drivers/clocksource/rockchip_timer.c
@@ -49,14 +49,14 @@ static inline void __iomem *rk_base(struct clock_event_device *ce)
 static inline void rk_timer_disable(struct clock_event_device *ce)
 {
 	writel_relaxed(TIMER_DISABLE, rk_base(ce) + TIMER_CONTROL_REG);
-	dsb();
+	dsb(sy);
 }
 
 static inline void rk_timer_enable(struct clock_event_device *ce, u32 flags)
 {
 	writel_relaxed(TIMER_ENABLE | TIMER_INT_UNMASK | flags,
 		       rk_base(ce) + TIMER_CONTROL_REG);
-	dsb();
+	dsb(sy);
 }
 
 static void rk_timer_update_counter(unsigned long cycles,
@@ -64,13 +64,13 @@ static void rk_timer_update_counter(unsigned long cycles,
 {
 	writel_relaxed(cycles, rk_base(ce) + TIMER_LOAD_COUNT0);
 	writel_relaxed(0, rk_base(ce) + TIMER_LOAD_COUNT1);
-	dsb();
+	dsb(sy);
 }
 
 static void rk_timer_interrupt_clear(struct clock_event_device *ce)
 {
 	writel_relaxed(1, rk_base(ce) + TIMER_INT_STATUS);
-	dsb();
+	dsb(sy);
 }
 
 static inline int rk_timer_set_next_event(unsigned long cycles,
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260728 — Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible

FromArnd Bergmann <arnd@arndb.de>
Date2015-11-02 16:40 +0100
SubjectRe: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible
Message-ID<qqpnb-70J-19@gated-at.bofh.it>
In reply to#1260632
On Monday 02 November 2015 13:56:31 Daniel Lezcano wrote:
>  static inline void rk_timer_disable(struct clock_event_device *ce)
>  {
>         writel_relaxed(TIMER_DISABLE, rk_base(ce) + TIMER_CONTROL_REG);
> -       dsb();
> +       dsb(sy);
>  }
>  
>  static inline void rk_timer_enable(struct clock_event_device *ce, u32 flags)
>  {
>         writel_relaxed(TIMER_ENABLE | TIMER_INT_UNMASK | flags,
>                        rk_base(ce) + TIMER_CONTROL_REG);
> -       dsb();
> +       dsb(sy);
>  }
>  
> 

This will fail the compile test, because dsb() is not available on non-ARM
architectures. Would it be enough to just use the normal writel() accessor
here?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260784 — Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-02 17:40 +0100
SubjectRe: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible
Message-ID<qqqjg-7AX-33@gated-at.bofh.it>
In reply to#1260728
On 11/02/2015 04:33 PM, Arnd Bergmann wrote:
> On Monday 02 November 2015 13:56:31 Daniel Lezcano wrote:
>>   static inline void rk_timer_disable(struct clock_event_device *ce)
>>   {
>>          writel_relaxed(TIMER_DISABLE, rk_base(ce) + TIMER_CONTROL_REG);
>> -       dsb();
>> +       dsb(sy);
>>   }
>>
>>   static inline void rk_timer_enable(struct clock_event_device *ce, u32 flags)
>>   {
>>          writel_relaxed(TIMER_ENABLE | TIMER_INT_UNMASK | flags,
>>                         rk_base(ce) + TIMER_CONTROL_REG);
>> -       dsb();
>> +       dsb(sy);
>>   }
>>
>>
>
> This will fail the compile test, because dsb() is not available on non-ARM
> architectures. Would it be enough to just use the normal writel() accessor
> here?

That's a good question and I believe we can remove it but I have to 
setup a rockchip board before doing the changes in order to test.

I the meantime added the COMPILE_TEST option but restricted it to ARM 
and ARM64.



-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1261006 — Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible

FromArnd Bergmann <arnd@arndb.de>
Date2015-11-02 22:50 +0100
SubjectRe: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible
Message-ID<qqv9g-28h-5@gated-at.bofh.it>
In reply to#1260784
On Monday 02 November 2015 17:32:22 Daniel Lezcano wrote:
> On 11/02/2015 04:33 PM, Arnd Bergmann wrote:
> > On Monday 02 November 2015 13:56:31 Daniel Lezcano wrote:
> >>   static inline void rk_timer_disable(struct clock_event_device *ce)
> >>   {
> >>          writel_relaxed(TIMER_DISABLE, rk_base(ce) + TIMER_CONTROL_REG);
> >> -       dsb();
> >> +       dsb(sy);
> >>   }
> >>
> >>   static inline void rk_timer_enable(struct clock_event_device *ce, u32 flags)
> >>   {
> >>          writel_relaxed(TIMER_ENABLE | TIMER_INT_UNMASK | flags,
> >>                         rk_base(ce) + TIMER_CONTROL_REG);
> >> -       dsb();
> >> +       dsb(sy);
> >>   }
> >>
> >>
> >
> > This will fail the compile test, because dsb() is not available on non-ARM
> > architectures. Would it be enough to just use the normal writel() accessor
> > here?
> 
> That's a good question and I believe we can remove it but I have to 
> setup a rockchip board before doing the changes in order to test.
> 
> I the meantime added the COMPILE_TEST option but restricted it to ARM 
> and ARM64.
> 

Ok. I saw that addition after commenting here, it looks correct this
way, I was just slightly confused by seeing patch 2 first and thought
it was for the same driver.

In general, it would of course be best to allow all drivers to be built
on x86, but your series is already a huge improvement as it is.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260634 — [PATCH 14/22] clocksource/drivers/vt8500: Add the COMPILE_TEST option

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-02 14:10 +0100
Subject[PATCH 14/22] clocksource/drivers/vt8500: Add the COMPILE_TEST option
Message-ID<qqn24-5Jb-65@gated-at.bofh.it>
In reply to#1260610
Increase the compilation test coverage by adding the COMPILE_TEST option.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 1af13c9..b0136fc 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -81,7 +81,9 @@ config TEGRA_TIMER
 	  Enables support for the Tegra driver.
 
 config VT8500_TIMER
-	bool
+	bool "VT8500 timer driver" if COMPILE_TEST
+	help
+	  Enables support for the VT8500 driver.
 
 config CADENCE_TTC_TIMER
 	bool
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260635 — [PATCH 09/22] clocksource/drivers/dw_apb: Add the COMPILE_TEST option

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-02 14:10 +0100
Subject[PATCH 09/22] clocksource/drivers/dw_apb: Add the COMPILE_TEST option
Message-ID<qqn25-5Jb-83@gated-at.bofh.it>
In reply to#1260610
Increase the compilation test coverage by adding the COMPILE_TEST option.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 5b0f63a..a8afd8a 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -24,7 +24,9 @@ config DIGICOLOR_TIMER
 	  Enables the support for the digicolor timer driver.
 
 config DW_APB_TIMER
-	bool
+	bool "DW APB timer driver" if COMPILE_TEST
+	help
+	  Enables the support for the dw_apb timer.
 
 config DW_APB_TIMER_OF
 	bool
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1260640 — [PATCH 21/22] clocksource/drivers/samsung-pwm: Add the COMPILE_TEST option

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2015-11-02 14:10 +0100
Subject[PATCH 21/22] clocksource/drivers/samsung-pwm: Add the COMPILE_TEST option
Message-ID<qqn25-5Jb-95@gated-at.bofh.it>
In reply to#1260610
Increase the compilation test coverage by adding the COMPILE_TEST option.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index d829cbe..8f2a3fb 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -219,7 +219,7 @@ config CLKSRC_EXYNOS_MCT
 	  Support for Multi Core Timer controller on Exynos SoCs.
 
 config CLKSRC_SAMSUNG_PWM
-	bool
+	bool "PWM timer drvier for Samsung S3C, S5P" if COMPILE_TEST
 	help
 	  This is a new clocksource driver for the PWM timer found in
 	  Samsung S3C, S5P and Exynos SoCs, replacing an earlier driver
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web