Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1260395 > unrolled thread
| Started by | Milo Kim <milo.kim@ti.com> |
|---|---|
| First post | 2015-11-02 06:30 +0100 |
| Last post | 2015-11-03 09:50 +0100 |
| Articles | 17 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH RESEND 00/16] Support TI LMU devices Milo Kim <milo.kim@ti.com> - 2015-11-02 06:30 +0100
[PATCH RESEND 02/16] Documentation: dt-bindings: backlight: add TI LMU backlight binding information Milo Kim <milo.kim@ti.com> - 2015-11-02 06:30 +0100
Re: [PATCH RESEND 02/16] Documentation: dt-bindings: backlight: add TI LMU backlight binding information Rob Herring <robh@kernel.org> - 2015-11-02 16:10 +0100
Re: [PATCH RESEND 02/16] Documentation: dt-bindings: backlight: add TI LMU backlight binding information "Kim, Milo" <milo.kim@ti.com> - 2015-11-03 08:20 +0100
Re: [PATCH RESEND 02/16] Documentation: dt-bindings: backlight: add TI LMU backlight binding information Rob Herring <robh@kernel.org> - 2015-11-03 16:40 +0100
[PATCH RESEND 06/16] mfd: add TI LMU driver Milo Kim <milo.kim@ti.com> - 2015-11-02 06:30 +0100
[PATCH RESEND 13/16] backlight: ti-lmu-backlight: add LM3697 driver Milo Kim <milo.kim@ti.com> - 2015-11-02 06:30 +0100
[PATCH RESEND 03/16] Documentation: dt-bindings: hwmon: add TI LMU HWMON binding information Milo Kim <milo.kim@ti.com> - 2015-11-02 06:30 +0100
Re: [PATCH RESEND 03/16] Documentation: dt-bindings: hwmon: add TI LMU HWMON binding information Rob Herring <robh@kernel.org> - 2015-11-06 03:00 +0100
Re: [PATCH RESEND 03/16] Documentation: dt-bindings: hwmon: add TI LMU HWMON binding information "Kim, Milo" <milo.kim@ti.com> - 2015-11-06 05:00 +0100
Re: [PATCH RESEND 00/16] Support TI LMU devices Lee Jones <lee.jones@linaro.org> - 2015-11-02 10:00 +0100
Re: [PATCH RESEND 00/16] Support TI LMU devices "Kim, Milo" <milo.kim@ti.com> - 2015-11-03 08:00 +0100
Re: [PATCH RESEND 00/16] Support TI LMU devices Lee Jones <lee.jones@linaro.org> - 2015-11-03 09:50 +0100
Re: [PATCH RESEND 00/16] Support TI LMU devices "Kim, Milo" <milo.kim@ti.com> - 2015-11-03 10:10 +0100
Re: [PATCH RESEND 00/16] Support TI LMU devices Lee Jones <lee.jones@linaro.org> - 2015-11-02 10:10 +0100
Re: [PATCH RESEND 00/16] Support TI LMU devices "Kim, Milo" <milo.kim@ti.com> - 2015-11-03 08:10 +0100
Re: [PATCH RESEND 00/16] Support TI LMU devices Lee Jones <lee.jones@linaro.org> - 2015-11-03 09:50 +0100
| From | Milo Kim <milo.kim@ti.com> |
|---|---|
| Date | 2015-11-02 06:30 +0100 |
| Subject | [PATCH RESEND 00/16] Support TI LMU devices |
| Message-ID | <qqfQR-1lO-5@gated-at.bofh.it> |
TI LMU(Lighting Management Unit) driver supports lighting devices below.
Enable pin Backlights HWMON LEDs Regulators
---------- ---------- ----- ---- ------------
LM3532 o o x x x
LM3631 o o x x 5 regulators
LM3632 o o x x 3 regulators
LM3633 o o o o x
LM3695 o o x x x
LM3697 o o o x x
This patch-set consists of several parts below.
DT bindings : Binding information for each module
TI LMU MFD : Device registration, HW enable pin control and
I2C register access
TI LMU backlight : Common driver for TI LMU backlight devices
Each backlight driver : Chip dependent code
HWMON : LMU hardware fault monitoring driver
LM3633 LED : LED subsystem and dimming pattern generation
supported
LM363X regulator : LM3631 and LM3632 regulator driver for the
display bias
Git location:
Please refer to the location below. Branch name is 'ti-lmu'.
git clone -b ti-lmu https://github.com/milokim/linux.git
Milo Kim (16):
Documentation: dt-bindings: mfd: add TI LMU device binding information
Documentation: dt-bindings: backlight: add TI LMU backlight binding
information
Documentation: dt-bindings: hwmon: add TI LMU HWMON binding
information
Documentation: dt-bindings: leds: add LM3633 LED binding information
Documentation: dt-bindings: regulator: add LM363x regulator binding
information
mfd: add TI LMU driver
backlight: add TI LMU backlight common driver
backlight: ti-lmu-backlight: add LM3532 driver
backlight: ti-lmu-backlight: add LM3631 driver
backlight: ti-lmu-backlight: add LM3632 driver
backlight: ti-lmu-backlight: add LM3633 driver
backlight: ti-lmu-backlight: add LM3695 driver
backlight: ti-lmu-backlight: add LM3697 driver
hwmon: add TI LMU hardware fault monitoring driver
leds: add LM3633 driver
regulator: add LM363X driver
Documentation/ABI/testing/sysfs-class-led-lm3633 | 60 ++
.../devicetree/bindings/hwmon/ti-lmu-hwmon.txt | 12 +
.../devicetree/bindings/leds/leds-lm3633.txt | 28 +
Documentation/devicetree/bindings/mfd/ti-lmu.txt | 282 ++++++++
.../bindings/regulator/lm363x-regulator.txt | 28 +
.../bindings/video/backlight/ti-lmu-backlight.txt | 67 ++
drivers/hwmon/Kconfig | 10 +
drivers/hwmon/Makefile | 1 +
drivers/hwmon/ti-lmu-hwmon.c | 393 +++++++++++
drivers/leds/Kconfig | 10 +
drivers/leds/Makefile | 1 +
drivers/leds/leds-lm3633.c | 749 +++++++++++++++++++++
drivers/mfd/Kconfig | 12 +
drivers/mfd/Makefile | 1 +
drivers/mfd/ti-lmu.c | 324 +++++++++
drivers/regulator/Kconfig | 9 +
drivers/regulator/Makefile | 1 +
drivers/regulator/lm363x-regulator.c | 349 ++++++++++
drivers/video/backlight/Kconfig | 62 ++
drivers/video/backlight/Makefile | 7 +
drivers/video/backlight/lm3532_bl.c | 183 +++++
drivers/video/backlight/lm3631_bl.c | 129 ++++
drivers/video/backlight/lm3632_bl.c | 125 ++++
drivers/video/backlight/lm3633_bl.c | 210 ++++++
drivers/video/backlight/lm3695_bl.c | 91 +++
drivers/video/backlight/lm3697_bl.c | 187 +++++
drivers/video/backlight/ti-lmu-backlight.c | 429 ++++++++++++
drivers/video/backlight/ti-lmu-backlight.h | 152 +++++
include/linux/mfd/ti-lmu-register.h | 277 ++++++++
include/linux/mfd/ti-lmu.h | 81 +++
30 files changed, 4270 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-class-led-lm3633
create mode 100644 Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt
create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3633.txt
create mode 100644 Documentation/devicetree/bindings/mfd/ti-lmu.txt
create mode 100644 Documentation/devicetree/bindings/regulator/lm363x-regulator.txt
create mode 100644 Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt
create mode 100644 drivers/hwmon/ti-lmu-hwmon.c
create mode 100644 drivers/leds/leds-lm3633.c
create mode 100644 drivers/mfd/ti-lmu.c
create mode 100644 drivers/regulator/lm363x-regulator.c
create mode 100644 drivers/video/backlight/lm3532_bl.c
create mode 100644 drivers/video/backlight/lm3631_bl.c
create mode 100644 drivers/video/backlight/lm3632_bl.c
create mode 100644 drivers/video/backlight/lm3633_bl.c
create mode 100644 drivers/video/backlight/lm3695_bl.c
create mode 100644 drivers/video/backlight/lm3697_bl.c
create mode 100644 drivers/video/backlight/ti-lmu-backlight.c
create mode 100644 drivers/video/backlight/ti-lmu-backlight.h
create mode 100644 include/linux/mfd/ti-lmu-register.h
create mode 100644 include/linux/mfd/ti-lmu.h
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Milo Kim <milo.kim@ti.com> |
|---|---|
| Date | 2015-11-02 06:30 +0100 |
| Subject | [PATCH RESEND 02/16] Documentation: dt-bindings: backlight: add TI LMU backlight binding information |
| Message-ID | <qqfQS-1lO-31@gated-at.bofh.it> |
| In reply to | #1260395 |
LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697 use common dt-bindings for describing device. Cc: devicetree@vger.kernel.org Cc: Jingoo Han <jingoohan1@gmail.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim <milo.kim@ti.com> --- .../bindings/video/backlight/ti-lmu-backlight.txt | 67 ++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt diff --git a/Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt b/Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt new file mode 100644 index 0000000..27b0036 --- /dev/null +++ b/Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt @@ -0,0 +1,67 @@ +TI LMU backlight device tree bindings + +Required properties: + - compatible: Should be one of lists below. + "ti,lm3532-backlight" + "ti,lm3631-backlight" + "ti,lm3632-backlight" + "ti,lm3633-backlight" + "ti,lm3695-backlight" + "ti,lm3697-backlight" + +Optional properties: + There are two backlight control mode. One is I2C, the other is PWM mode. + Following properties are only specified in PWM mode. + Please note that LMU backlight device can have only one PWM channel. + + - pwms: OF device-tree PWM specification. + - pwm-names: a list of names for the PWM devices specified in the "pwms" + property. + + For the PWM user nodes, please refer to [1]. + +Child nodes: + LMU backlight is represented as sub-nodes of the TI LMU device [2]. + So, LMU backlight should have more than one backlight child node. + Each node exactly matches with backlight control bank configuration. + Maximum numbers of child nodes depend on the device. + 1 = LM3631, LM3632, LM3695 + 2 = LM3633, LM3697 + 3 = LM3532 + + Required property of a child node: + - hvled1-used, hvled2-used, hvled3-used: + High voltage backlight strings configuration. Type is <boolean>. + Please describe which output backlight string is used. + Please refer to the datasheets [3]. + + Optional properties of a child node: + - backlight-name: Name string for backlight device identification. + It is used for creating backlight sysfs, + /sys/class/backlight/<backlight-name>/. + - backlight-max-microamp: Max current setting. Type is <u32>. + Unit is microampere. + Range is from 5000 to 30000. + - initial-brightness: Backlight initial brightness value. Type is <u32>. + It is set as soon as backlight device is created. + 0 ~ 2047 = LM3631, LM3632, LM3633, LM3695 and LM3697 + 0 ~ 255 = LM3532 + - ramp-up-msec, ramp-down-msec: Light dimming effect properties. + Type is <u32>. Unit is millisecond. + 0 ~ 65 msec = LM3532 + 0 ~ 4000 msec = LM3631 + 0 ~ 16000 msec = LM3633 and LM3697 + - pwm-period: PWM period. Only valid in PWM brightness mode. + Type is <u32>. If this property is missing, then control + mode is set to I2C by default. + +Examples: Please refer to ti-lmu dt-bindings. [2]. + +[1] Documentation/devicetree/bindings/pwm/pwm.txt +[2] Documentation/devicetree/bindings/mfd/ti-lmu.txt +[3] LM3532: http://www.ti.com/product/LM3532/datasheet + LM3631: http://www.ti.com/product/LM3631/datasheet + LM3632: http://www.ti.com/product/LM3632A/datasheet + LM3633: http://www.ti.com/product/LM3633/datasheet + LM3695: Datasheet is not opened yet, but only two strings are used. + LM3697: http://www.ti.com/product/LM3697/datasheet -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2015-11-02 16:10 +0100 |
| Subject | Re: [PATCH RESEND 02/16] Documentation: dt-bindings: backlight: add TI LMU backlight binding information |
| Message-ID | <qqoUa-6R3-15@gated-at.bofh.it> |
| In reply to | #1260396 |
On Sun, Nov 1, 2015 at 11:24 PM, Milo Kim <milo.kim@ti.com> wrote: > LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697 use common dt-bindings > for describing device. > > Cc: devicetree@vger.kernel.org > Cc: Jingoo Han <jingoohan1@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Milo Kim <milo.kim@ti.com> > --- > .../bindings/video/backlight/ti-lmu-backlight.txt | 67 ++++++++++++++++++++++ Please move to bindings/leds/backlight/ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt > > diff --git a/Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt b/Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt > new file mode 100644 > index 0000000..27b0036 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt > @@ -0,0 +1,67 @@ > +TI LMU backlight device tree bindings > + > +Required properties: > + - compatible: Should be one of lists below. > + "ti,lm3532-backlight" > + "ti,lm3631-backlight" > + "ti,lm3632-backlight" > + "ti,lm3633-backlight" > + "ti,lm3695-backlight" > + "ti,lm3697-backlight" > + > +Optional properties: > + There are two backlight control mode. One is I2C, the other is PWM mode. > + Following properties are only specified in PWM mode. > + Please note that LMU backlight device can have only one PWM channel. > + > + - pwms: OF device-tree PWM specification. > + - pwm-names: a list of names for the PWM devices specified in the "pwms" > + property. > + > + For the PWM user nodes, please refer to [1]. > + > +Child nodes: > + LMU backlight is represented as sub-nodes of the TI LMU device [2]. > + So, LMU backlight should have more than one backlight child node. > + Each node exactly matches with backlight control bank configuration. > + Maximum numbers of child nodes depend on the device. > + 1 = LM3631, LM3632, LM3695 > + 2 = LM3633, LM3697 > + 3 = LM3532 > + > + Required property of a child node: > + - hvled1-used, hvled2-used, hvled3-used: > + High voltage backlight strings configuration. Type is <boolean>. > + Please describe which output backlight string is used. > + Please refer to the datasheets [3]. Use led-sources. > + > + Optional properties of a child node: > + - backlight-name: Name string for backlight device identification. > + It is used for creating backlight sysfs, > + /sys/class/backlight/<backlight-name>/. Use label. > + - backlight-max-microamp: Max current setting. Type is <u32>. > + Unit is microampere. > + Range is from 5000 to 30000. Use led-max-microamp > + - initial-brightness: Backlight initial brightness value. Type is <u32>. > + It is set as soon as backlight device is created. > + 0 ~ 2047 = LM3631, LM3632, LM3633, LM3695 and LM3697 > + 0 ~ 255 = LM3532 Use default-brightness-level > + - ramp-up-msec, ramp-down-msec: Light dimming effect properties. > + Type is <u32>. Unit is millisecond. > + 0 ~ 65 msec = LM3532 > + 0 ~ 4000 msec = LM3631 > + 0 ~ 16000 msec = LM3633 and LM3697 > + - pwm-period: PWM period. Only valid in PWM brightness mode. > + Type is <u32>. If this property is missing, then control > + mode is set to I2C by default. > + > +Examples: Please refer to ti-lmu dt-bindings. [2]. > + > +[1] Documentation/devicetree/bindings/pwm/pwm.txt > +[2] Documentation/devicetree/bindings/mfd/ti-lmu.txt > +[3] LM3532: http://www.ti.com/product/LM3532/datasheet > + LM3631: http://www.ti.com/product/LM3631/datasheet > + LM3632: http://www.ti.com/product/LM3632A/datasheet > + LM3633: http://www.ti.com/product/LM3633/datasheet > + LM3695: Datasheet is not opened yet, but only two strings are used. > + LM3697: http://www.ti.com/product/LM3697/datasheet > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Kim, Milo" <milo.kim@ti.com> |
|---|---|
| Date | 2015-11-03 08:20 +0100 |
| Subject | Re: [PATCH RESEND 02/16] Documentation: dt-bindings: backlight: add TI LMU backlight binding information |
| Message-ID | <qqE2S-7ZB-9@gated-at.bofh.it> |
| In reply to | #1260709 |
On 11/3/2015 12:02 AM, Rob Herring wrote: > On Sun, Nov 1, 2015 at 11:24 PM, Milo Kim <milo.kim@ti.com> wrote: >> LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697 use common dt-bindings >> for describing device. >> >> Cc: devicetree@vger.kernel.org >> Cc: Jingoo Han <jingoohan1@gmail.com> >> Cc: Lee Jones <lee.jones@linaro.org> >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Milo Kim <milo.kim@ti.com> >> --- >> .../bindings/video/backlight/ti-lmu-backlight.txt | 67 ++++++++++++++++++++++ > > Please move to bindings/leds/backlight/ There are backlight bindings under video/backlight. I'd like to know why this 'led' location is preferred. My guess is most of properties are from common LED properties. Any other reasons? > >> 1 file changed, 67 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt >> >> diff --git a/Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt b/Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt >> new file mode 100644 >> index 0000000..27b0036 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt >> @@ -0,0 +1,67 @@ >> +TI LMU backlight device tree bindings >> + >> +Required properties: >> + - compatible: Should be one of lists below. >> + "ti,lm3532-backlight" >> + "ti,lm3631-backlight" >> + "ti,lm3632-backlight" >> + "ti,lm3633-backlight" >> + "ti,lm3695-backlight" >> + "ti,lm3697-backlight" >> + >> +Optional properties: >> + There are two backlight control mode. One is I2C, the other is PWM mode. >> + Following properties are only specified in PWM mode. >> + Please note that LMU backlight device can have only one PWM channel. >> + >> + - pwms: OF device-tree PWM specification. >> + - pwm-names: a list of names for the PWM devices specified in the "pwms" >> + property. >> + >> + For the PWM user nodes, please refer to [1]. >> + >> +Child nodes: >> + LMU backlight is represented as sub-nodes of the TI LMU device [2]. >> + So, LMU backlight should have more than one backlight child node. >> + Each node exactly matches with backlight control bank configuration. >> + Maximum numbers of child nodes depend on the device. >> + 1 = LM3631, LM3632, LM3695 >> + 2 = LM3633, LM3697 >> + 3 = LM3532 >> + >> + Required property of a child node: >> + - hvled1-used, hvled2-used, hvled3-used: >> + High voltage backlight strings configuration. Type is <boolean>. >> + Please describe which output backlight string is used. >> + Please refer to the datasheets [3]. > > Use led-sources. OK. > >> + >> + Optional properties of a child node: >> + - backlight-name: Name string for backlight device identification. >> + It is used for creating backlight sysfs, >> + /sys/class/backlight/<backlight-name>/. > > Use label. Got it. > >> + - backlight-max-microamp: Max current setting. Type is <u32>. >> + Unit is microampere. >> + Range is from 5000 to 30000. > > Use led-max-microamp OK. > >> + - initial-brightness: Backlight initial brightness value. Type is <u32>. >> + It is set as soon as backlight device is created. >> + 0 ~ 2047 = LM3631, LM3632, LM3633, LM3695 and LM3697 >> + 0 ~ 255 = LM3532 > > Use default-brightness-level > I'll update the bindings and drivers based on your review. Many thanks! Best regards, Milo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2015-11-03 16:40 +0100 |
| Subject | Re: [PATCH RESEND 02/16] Documentation: dt-bindings: backlight: add TI LMU backlight binding information |
| Message-ID | <qqLQK-4xa-21@gated-at.bofh.it> |
| In reply to | #1261239 |
On Tue, Nov 3, 2015 at 1:13 AM, Kim, Milo <milo.kim@ti.com> wrote: > > On 11/3/2015 12:02 AM, Rob Herring wrote: >> >> On Sun, Nov 1, 2015 at 11:24 PM, Milo Kim <milo.kim@ti.com> wrote: >>> >>> LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697 use common dt-bindings >>> for describing device. >>> >>> Cc: devicetree@vger.kernel.org >>> Cc: Jingoo Han <jingoohan1@gmail.com> >>> Cc: Lee Jones <lee.jones@linaro.org> >>> Cc: linux-kernel@vger.kernel.org >>> Signed-off-by: Milo Kim <milo.kim@ti.com> >>> --- >>> .../bindings/video/backlight/ti-lmu-backlight.txt | 67 >>> ++++++++++++++++++++++ >> >> >> Please move to bindings/leds/backlight/ > > > There are backlight bindings under video/backlight. I'd like to know why Not if you look in linux-next. > this 'led' location is preferred. My guess is most of properties are from > common LED properties. Any other reasons? Yes, that is the main reason. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Milo Kim <milo.kim@ti.com> |
|---|---|
| Date | 2015-11-02 06:30 +0100 |
| Subject | [PATCH RESEND 06/16] mfd: add TI LMU driver |
| Message-ID | <qqfQS-1lO-33@gated-at.bofh.it> |
| In reply to | #1260395 |
TI LMU(Lighting Management Unit) driver supports lighting devices below.
LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697.
LMU devices have common features.
- I2C interface for accessing device registers
- Hardware enable pin control
- Backlight brightness control
- Max current conversion helper function
- Notifier for hardware fault monitoring
- Regulators for LCD display bias
It contains backlight, HWMON, LED and regulator driver.
Backlight
---------
It's handled by TI LMU backlight common driver and chip dependent driver.
Please refer to separate patches for ti-lmu-backlight.
HWMON
-----
LM3633 and LM3697 provide hardware monitoring feature.
It enables opened or shorted circuit detection.
After monitoring is done, each device should be re-initialized.
Notifier is used for this case.
Please refer to separate patch for ti-lmu-hwmon.
LED indicator
-------------
LM3633 has 6 indicator LEDs. Programmable pattern is also supported.
Please refer to separate patch for leds-lm3633.
Regulator
---------
LM3631 has 5 regulators for the display bias.
LM3632 supports 3 regulators. One consolidated driver enables it.
Please refer to separate patch for lm363x-regulator.
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: lm-sensors@lm-sensors.org
Cc: linux-leds@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Milo Kim <milo.kim@ti.com>
---
drivers/mfd/Kconfig | 12 ++
drivers/mfd/Makefile | 1 +
drivers/mfd/ti-lmu.c | 324 ++++++++++++++++++++++++++++++++++++
include/linux/mfd/ti-lmu-register.h | 277 ++++++++++++++++++++++++++++++
include/linux/mfd/ti-lmu.h | 81 +++++++++
5 files changed, 695 insertions(+)
create mode 100644 drivers/mfd/ti-lmu.c
create mode 100644 include/linux/mfd/ti-lmu-register.h
create mode 100644 include/linux/mfd/ti-lmu.h
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 99d6367..a53a38e 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1037,6 +1037,18 @@ config MFD_LP8788
TI LP8788 PMU supports regulators, battery charger, RTC,
ADC, backlight driver and current sinks.
+config MFD_TI_LMU
+ tristate "TI Lighting Management Unit driver"
+ depends on I2C
+ select MFD_CORE
+ select REGMAP_I2C
+ help
+ Say yes here to enable support for TI LMU chips.
+
+ TI LMU MFD supports LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697.
+ It consists of backlight, hwmon, LED and regulator driver.
+ It provides consistent device controls for lighting functions.
+
config MFD_OMAP_USB_HOST
bool "TI OMAP USBHS core and TLL driver"
depends on USB_EHCI_HCD_OMAP || USB_OHCI_HCD_OMAP3
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index a59e3fc..32920f8 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -110,6 +110,7 @@ obj-$(CONFIG_MFD_AXP20X) += axp20x.o
obj-$(CONFIG_MFD_LP3943) += lp3943.o
obj-$(CONFIG_MFD_LP8788) += lp8788.o lp8788-irq.o
+obj-$(CONFIG_MFD_TI_LMU) += ti-lmu.o
da9055-objs := da9055-core.o da9055-i2c.o
obj-$(CONFIG_MFD_DA9055) += da9055.o
diff --git a/drivers/mfd/ti-lmu.c b/drivers/mfd/ti-lmu.c
new file mode 100644
index 0000000..e86a0ea
--- /dev/null
+++ b/drivers/mfd/ti-lmu.c
@@ -0,0 +1,324 @@
+/*
+ * TI LMU(Lighting Management Unit) Core Driver
+ *
+ * Copyright 2015 Texas Instruments
+ *
+ * Author: Milo Kim <milo.kim@ti.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/delay.h>
+#include <linux/err.h>
+#include <linux/gpio.h>
+#include <linux/i2c.h>
+#include <linux/kernel.h>
+#include <linux/mfd/core.h>
+#include <linux/mfd/ti-lmu.h>
+#include <linux/mfd/ti-lmu-register.h>
+#include <linux/module.h>
+#include <linux/notifier.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/of_gpio.h>
+#include <linux/slab.h>
+
+#define LMU_IMAX_OFFSET 6
+
+enum ti_lmu_id {
+ LM3532,
+ LM3631,
+ LM3632,
+ LM3633,
+ LM3695,
+ LM3697,
+};
+
+struct ti_lmu_data {
+ struct mfd_cell *cells;
+ int num_cells;
+ unsigned int max_register;
+};
+
+int ti_lmu_read_byte(struct ti_lmu *lmu, u8 reg, u8 *read)
+{
+ int ret;
+ unsigned int val;
+
+ ret = regmap_read(lmu->regmap, reg, &val);
+ if (ret < 0)
+ return ret;
+
+ *read = (u8)val;
+ return 0;
+}
+EXPORT_SYMBOL_GPL(ti_lmu_read_byte);
+
+int ti_lmu_write_byte(struct ti_lmu *lmu, u8 reg, u8 data)
+{
+ return regmap_write(lmu->regmap, reg, data);
+}
+EXPORT_SYMBOL_GPL(ti_lmu_write_byte);
+
+int ti_lmu_update_bits(struct ti_lmu *lmu, u8 reg, u8 mask, u8 data)
+{
+ return regmap_update_bits(lmu->regmap, reg, mask, data);
+}
+EXPORT_SYMBOL_GPL(ti_lmu_update_bits);
+
+/*
+ * LMU backlight and LED devices use shared max current table.
+ * This function finds appropriate register index and return it.
+ */
+enum ti_lmu_max_current ti_lmu_get_current_code(u32 imax_microamp)
+{
+ u8 imax_milliamp = imax_microamp / 1000;
+
+ const enum ti_lmu_max_current imax_table[] = {
+ LMU_IMAX_6mA, LMU_IMAX_7mA, LMU_IMAX_8mA, LMU_IMAX_9mA,
+ LMU_IMAX_10mA, LMU_IMAX_11mA, LMU_IMAX_12mA, LMU_IMAX_13mA,
+ LMU_IMAX_14mA, LMU_IMAX_15mA, LMU_IMAX_16mA, LMU_IMAX_17mA,
+ LMU_IMAX_18mA, LMU_IMAX_19mA, LMU_IMAX_20mA, LMU_IMAX_21mA,
+ LMU_IMAX_22mA, LMU_IMAX_23mA, LMU_IMAX_24mA, LMU_IMAX_25mA,
+ LMU_IMAX_26mA, LMU_IMAX_27mA, LMU_IMAX_28mA, LMU_IMAX_29mA,
+ };
+
+ /* Valid range is from 5mA to 30mA */
+ if (imax_milliamp <= 5)
+ return LMU_IMAX_5mA;
+
+ if (imax_milliamp >= 30)
+ return LMU_IMAX_30mA;
+
+ return imax_table[imax_milliamp - LMU_IMAX_OFFSET];
+}
+EXPORT_SYMBOL_GPL(ti_lmu_get_current_code);
+
+static int ti_lmu_enable_hw(struct ti_lmu *lmu, enum ti_lmu_id id)
+{
+ int ret;
+
+ if (gpio_is_valid(lmu->en_gpio)) {
+ ret = devm_gpio_request_one(lmu->dev, lmu->en_gpio,
+ GPIOF_OUT_INIT_HIGH, "lmu_hwen");
+ if (ret) {
+ dev_err(lmu->dev, "Can not request enable GPIO: %d\n",
+ ret);
+ return ret;
+ }
+ }
+
+ /* Delay about 1ms after HW enable pin control */
+ usleep_range(1000, 1500);
+
+ /* LM3631 has additional power up sequence - enable LCD_EN bit. */
+ if (id == LM3631) {
+ return ti_lmu_update_bits(lmu, LM3631_REG_DEVCTRL,
+ LM3631_LCD_EN_MASK,
+ LM3631_LCD_EN_MASK);
+ }
+
+ return 0;
+}
+
+static void ti_lmu_disable_hw(struct ti_lmu *lmu)
+{
+ if (gpio_is_valid(lmu->en_gpio))
+ gpio_set_value(lmu->en_gpio, 0);
+}
+
+static struct mfd_cell lm3532_devices[] = {
+ {
+ .name = "lm3532-backlight",
+ .of_compatible = "ti,lm3532-backlight",
+ },
+};
+
+#define LM363X_REGULATOR(_id) \
+{ \
+ .name = "lm363x-regulator", \
+ .id = _id, \
+ .of_compatible = "ti,lm363x-regulator", \
+} \
+
+static struct mfd_cell lm3631_devices[] = {
+ /* 5 regulators */
+ LM363X_REGULATOR(LM3631_BOOST),
+ LM363X_REGULATOR(LM3631_LDO_CONT),
+ LM363X_REGULATOR(LM3631_LDO_OREF),
+ LM363X_REGULATOR(LM3631_LDO_POS),
+ LM363X_REGULATOR(LM3631_LDO_NEG),
+ /* Backlight */
+ {
+ .name = "lm3631-backlight",
+ .of_compatible = "ti,lm3631-backlight",
+ },
+};
+
+static struct mfd_cell lm3632_devices[] = {
+ /* 3 regulators */
+ LM363X_REGULATOR(LM3632_BOOST),
+ LM363X_REGULATOR(LM3632_LDO_POS),
+ LM363X_REGULATOR(LM3632_LDO_NEG),
+ /* Backlight */
+ {
+ .name = "lm3632-backlight",
+ .of_compatible = "ti,lm3632-backlight",
+ },
+};
+
+static struct mfd_cell lm3633_devices[] = {
+ /* Backlight */
+ {
+ .name = "lm3633-backlight",
+ .of_compatible = "ti,lm3633-backlight",
+ },
+ /* LED */
+ {
+ .name = "lm3633-leds",
+ .of_compatible = "ti,lm3633-leds",
+ },
+ /* HWMON for opened/shorted circuit detection */
+ {
+ .name = "ti-lmu-hwmon",
+ .of_compatible = "ti,lm3633-hwmon",
+ },
+};
+
+static struct mfd_cell lm3695_devices[] = {
+ {
+ .name = "lm3695-backlight",
+ .of_compatible = "ti,lm3695-backlight",
+ },
+};
+
+static struct mfd_cell lm3697_devices[] = {
+ /* Backlight */
+ {
+ .name = "lm3697-backlight",
+ .of_compatible = "ti,lm3697-backlight",
+ },
+ /* HWMON for opened/shorted circuit detection */
+ {
+ .name = "ti-lmu-hwmon",
+ .of_compatible = "ti,lm3697-hwmon",
+ },
+};
+
+#define TI_LMU_DATA(chip, max_reg) \
+static const struct ti_lmu_data chip##_data = \
+{ \
+ .cells = chip##_devices, \
+ .num_cells = ARRAY_SIZE(chip##_devices),\
+ .max_register = max_reg, \
+} \
+
+TI_LMU_DATA(lm3532, LM3532_MAX_REG); /* lm3532_data */
+TI_LMU_DATA(lm3631, LM3631_MAX_REG); /* lm3631_data */
+TI_LMU_DATA(lm3632, LM3632_MAX_REG); /* lm3632_data */
+TI_LMU_DATA(lm3633, LM3633_MAX_REG); /* lm3633_data */
+TI_LMU_DATA(lm3695, LM3695_MAX_REG); /* lm3695_data */
+TI_LMU_DATA(lm3697, LM3697_MAX_REG); /* lm3697_data */
+
+static const struct of_device_id ti_lmu_of_match[] = {
+ { .compatible = "ti,lm3532", .data = &lm3532_data },
+ { .compatible = "ti,lm3631", .data = &lm3631_data },
+ { .compatible = "ti,lm3632", .data = &lm3632_data },
+ { .compatible = "ti,lm3633", .data = &lm3633_data },
+ { .compatible = "ti,lm3695", .data = &lm3695_data },
+ { .compatible = "ti,lm3697", .data = &lm3697_data },
+ { }
+};
+MODULE_DEVICE_TABLE(of, ti_lmu_of_match);
+
+static int ti_lmu_probe(struct i2c_client *cl, const struct i2c_device_id *id)
+{
+ struct device *dev = &cl->dev;
+ const struct of_device_id *match;
+ const struct ti_lmu_data *data;
+ struct regmap_config regmap_cfg;
+ struct ti_lmu *lmu;
+ int ret;
+
+ match = of_match_device(ti_lmu_of_match, dev);
+ if (!match)
+ return -ENODEV;
+ /*
+ * Get device specific data from of_match table.
+ * This data is defined by using TI_LMU_DATA() macro.
+ */
+ data = (struct ti_lmu_data *)match->data;
+
+ lmu = devm_kzalloc(dev, sizeof(*lmu), GFP_KERNEL);
+ if (!lmu)
+ return -ENOMEM;
+
+ lmu->dev = &cl->dev;
+
+ /* Setup regmap */
+ memset(®map_cfg, 0, sizeof(struct regmap_config));
+ regmap_cfg.reg_bits = 8;
+ regmap_cfg.val_bits = 8;
+ regmap_cfg.name = id->name;
+ regmap_cfg.max_register = data->max_register;
+
+ lmu->regmap = devm_regmap_init_i2c(cl, ®map_cfg);
+ if (IS_ERR(lmu->regmap))
+ return PTR_ERR(lmu->regmap);
+
+ /* HW enable pin control and additional power up sequence if required */
+ lmu->en_gpio = of_get_named_gpio(dev->of_node, "enable-gpios", 0);
+ ret = ti_lmu_enable_hw(lmu, id->driver_data);
+ if (ret)
+ return ret;
+
+ /*
+ * Fault circuit(opened/shorted) can be detected by ti-lmu-hwmon.
+ * After fault detection is done, some devices should re-initialize
+ * configuration. The notifier enables such kind of handling.
+ */
+ BLOCKING_INIT_NOTIFIER_HEAD(&lmu->notifier);
+
+ i2c_set_clientdata(cl, lmu);
+
+ return mfd_add_devices(lmu->dev, 0, data->cells,
+ data->num_cells, NULL, 0, NULL);
+}
+
+static int ti_lmu_remove(struct i2c_client *cl)
+{
+ struct ti_lmu *lmu = i2c_get_clientdata(cl);
+
+ ti_lmu_disable_hw(lmu);
+ mfd_remove_devices(lmu->dev);
+ return 0;
+}
+
+static const struct i2c_device_id ti_lmu_ids[] = {
+ { "lm3532", LM3532 },
+ { "lm3631", LM3631 },
+ { "lm3632", LM3632 },
+ { "lm3633", LM3633 },
+ { "lm3695", LM3695 },
+ { "lm3697", LM3697 },
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, ti_lmu_ids);
+
+static struct i2c_driver ti_lmu_driver = {
+ .probe = ti_lmu_probe,
+ .remove = ti_lmu_remove,
+ .driver = {
+ .name = "ti-lmu",
+ .of_match_table = ti_lmu_of_match,
+ },
+ .id_table = ti_lmu_ids,
+};
+
+module_i2c_driver(ti_lmu_driver);
+
+MODULE_DESCRIPTION("TI LMU MFD Core Driver");
+MODULE_AUTHOR("Milo Kim");
+MODULE_LICENSE("GPL v2");
diff --git a/include/linux/mfd/ti-lmu-register.h b/include/linux/mfd/ti-lmu-register.h
new file mode 100644
index 0000000..39f5771
--- /dev/null
+++ b/include/linux/mfd/ti-lmu-register.h
@@ -0,0 +1,277 @@
+/*
+ * TI LMU(Lighting Management Unit) Device Register Map
+ *
+ * Copyright 2015 Texas Instruments
+ *
+ * Author: Milo Kim <milo.kim@ti.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef __MFD_TI_LMU_REGISTER_H__
+#define __MFD_TI_LMU_REGISTER_H__
+
+#include <linux/mfd/ti-lmu.h>
+
+/* LM3532 */
+#define LM3532_REG_OUTPUT_CFG 0x10
+#define LM3532_ILED1_CFG_MASK 0x03
+#define LM3532_ILED2_CFG_MASK 0x0C
+#define LM3532_ILED3_CFG_MASK 0x30
+#define LM3532_ILED1_CFG_SHIFT 0
+#define LM3532_ILED2_CFG_SHIFT 2
+#define LM3532_ILED3_CFG_SHIFT 4
+
+#define LM3532_REG_RAMPUP 0x12
+#define LM3532_REG_RAMPDN LM3532_REG_RAMPUP
+#define LM3532_RAMPUP_MASK 0x07
+#define LM3532_RAMPUP_SHIFT 0
+#define LM3532_RAMPDN_MASK 0x38
+#define LM3532_RAMPDN_SHIFT 3
+
+#define LM3532_REG_ENABLE 0x1D
+
+#define LM3532_REG_PWM_CFG_BASE 0x13
+#define LM3532_PWM_SEL_A_MASK 0x05 /* zone 0 */
+#define LM3532_PWM_SEL_B_MASK 0x09 /* zone 1 */
+#define LM3532_PWM_SEL_C_MASK 0x11 /* zone 2 */
+#define LM3532_PWM_SEL_A_SHIFT 2
+#define LM3532_PWM_SEL_B_SHIFT 3
+#define LM3532_PWM_SEL_C_SHIFT 4
+
+#define LM3532_REG_ZONE_CFG_A 0x16
+#define LM3532_REG_ZONE_CFG_B 0x18
+#define LM3532_REG_ZONE_CFG_C 0x1A
+#define LM3532_ZONE_CFG_MASK (BIT(2) | BIT(3) | BIT(4))
+#define LM3532_ZONE_CFG_SHIFT 2
+
+#define LM3532_REG_IMAX_A 0x17
+#define LM3532_REG_IMAX_B 0x19
+#define LM3532_REG_IMAX_C 0x1B
+
+#define LM3532_REG_BRT_A 0x70 /* zone 0 */
+#define LM3532_REG_BRT_B 0x76 /* zone 1 */
+#define LM3532_REG_BRT_C 0x7C /* zone 2 */
+
+#define LM3532_MAX_REG 0x7E
+
+/* LM3631 */
+#define LM3631_REG_DEVCTRL 0x00
+#define LM3631_LCD_EN_MASK BIT(1)
+#define LM3631_BL_EN_MASK BIT(0)
+
+#define LM3631_REG_BRT_LSB 0x01
+#define LM3631_BRT_LSB_MASK (BIT(0) | BIT(1) | BIT(2))
+#define LM3631_REG_BRT_MSB 0x02
+#define LM3631_BRT_MSB_SHIFT 3
+
+#define LM3631_REG_BL_CFG 0x06
+#define LM3631_BL_STRING_MASK BIT(3)
+#define LM3631_BL_TWO_STRINGS 0
+#define LM3631_BL_ONE_STRING BIT(3)
+#define LM3631_MAP_MASK BIT(5)
+#define LM3631_EXPONENTIAL_MAP 0
+
+#define LM3631_REG_BRT_MODE 0x08
+#define LM3631_EN_SLOPE_MASK BIT(1)
+#define LM3631_MODE_MASK (BIT(2) | BIT(3))
+#define LM3631_MODE_I2C 0
+#define LM3631_MODE_PWM BIT(2)
+#define LM3631_MODE_COMB1 BIT(3)
+#define LM3631_MODE_COMB2 (BIT(2) | BIT(3))
+
+#define LM3631_REG_SLOPE 0x09
+#define LM3631_SLOPE_MASK 0xF0
+#define LM3631_SLOPE_SHIFT 4
+
+#define LM3631_REG_LDO_CTRL1 0x0A
+#define LM3631_EN_OREF_MASK BIT(0)
+#define LM3631_EN_VNEG_MASK BIT(1)
+#define LM3631_EN_VPOS_MASK BIT(2)
+
+#define LM3631_REG_LDO_CTRL2 0x0B
+#define LM3631_EN_CONT_MASK BIT(0)
+
+#define LM3631_REG_VOUT_CONT 0x0C
+#define LM3631_VOUT_CONT_MASK (BIT(6) | BIT(7))
+
+#define LM3631_REG_VOUT_BOOST 0x0C
+#define LM3631_REG_VOUT_POS 0x0D
+#define LM3631_REG_VOUT_NEG 0x0E
+#define LM3631_REG_VOUT_OREF 0x0F
+#define LM3631_VOUT_MASK 0x3F
+
+#define LM3631_REG_ENTIME_VCONT 0x0B
+#define LM3631_ENTIME_CONT_MASK 0x70
+
+#define LM3631_REG_ENTIME_VOREF 0x0F
+#define LM3631_REG_ENTIME_VPOS 0x10
+#define LM3631_REG_ENTIME_VNEG 0x11
+#define LM3631_ENTIME_MASK 0xF0
+#define LM3631_ENTIME_SHIFT 4
+
+#define LM3631_MAX_REG 0x16
+
+/* LM3632 */
+#define LM3632_REG_CONFIG1 0x02
+#define LM3632_OVP_MASK (BIT(5) | BIT(6) | BIT(7))
+#define LM3632_OVP_25V BIT(6)
+
+#define LM3632_REG_CONFIG2 0x03
+#define LM3632_SWFREQ_MASK BIT(7)
+#define LM3632_SWFREQ_1MHZ BIT(7)
+
+#define LM3632_REG_BRT_LSB 0x04
+#define LM3632_BRT_LSB_MASK (BIT(0) | BIT(1) | BIT(2))
+#define LM3632_REG_BRT_MSB 0x05
+#define LM3632_BRT_MSB_SHIFT 3
+
+#define LM3632_REG_IO_CTRL 0x09
+#define LM3632_PWM_MASK BIT(6)
+#define LM3632_I2C_MODE 0
+#define LM3632_PWM_MODE BIT(6)
+
+#define LM3632_REG_ENABLE 0x0A
+#define LM3632_BL_EN_MASK BIT(0)
+#define LM3632_BL_STRING_MASK (BIT(3) | BIT(4))
+#define LM3632_BL_ONE_STRING BIT(4)
+#define LM3632_BL_TWO_STRINGS BIT(3)
+
+#define LM3632_REG_BIAS_CONFIG 0x0C
+#define LM3632_EXT_EN_MASK BIT(0)
+#define LM3632_EN_VNEG_MASK BIT(1)
+#define LM3632_EN_VPOS_MASK BIT(2)
+
+#define LM3632_REG_VOUT_BOOST 0x0D
+#define LM3632_REG_VOUT_POS 0x0E
+#define LM3632_REG_VOUT_NEG 0x0F
+#define LM3632_VOUT_MASK 0x3F
+
+#define LM3632_MAX_REG 0x10
+
+/* LM3633 */
+#define LM3633_REG_HVLED_OUTPUT_CFG 0x10
+
+#define LM3633_REG_BANK_SEL 0x11
+
+#define LM3633_REG_BL0_RAMPUP 0x12
+#define LM3633_REG_BL0_RAMPDN LM3633_REG_BL0_RAMPUP
+#define LM3633_REG_BL1_RAMPUP 0x13
+#define LM3633_REG_BL1_RAMPDN LM3633_REG_BL1_RAMPUP
+#define LM3633_BL_RAMPUP_MASK 0xF0
+#define LM3633_BL_RAMPUP_SHIFT 4
+#define LM3633_BL_RAMPDN_MASK 0x0F
+#define LM3633_BL_RAMPDN_SHIFT 0
+
+#define LM3633_REG_BL_RAMP_CONF 0x1B
+#define LM3633_BL_RAMP_MASK 0x0F
+#define LM3633_BL_RAMP_EACH 0x05
+
+#define LM3633_REG_PTN0_RAMP 0x1C
+#define LM3633_REG_PTN1_RAMP 0x1D
+#define LM3633_PTN_RAMPUP_MASK 0x70
+#define LM3633_PTN_RAMPUP_SHIFT 4
+#define LM3633_PTN_RAMPDN_MASK 0x07
+#define LM3633_PTN_RAMPDN_SHIFT 0
+
+#define LM3633_REG_IMAX_HVLED_A 0x20
+#define LM3633_REG_IMAX_HVLED_B 0x21
+#define LM3633_REG_IMAX_LVLED_BASE 0x22
+
+#define LM3633_REG_BL_FEEDBACK_ENABLE 0x28
+
+#define LM3633_REG_ENABLE 0x2B
+#define LM3633_LED_BANK_OFFSET 2
+
+#define LM3633_REG_PATTERN 0x2C
+
+#define LM3633_REG_BOOST_CFG 0x2D
+#define LM3633_BOOST_OVP_MASK (BIT(1) | BIT(2))
+#define LM3633_BOOST_OVP_40V 0x6
+
+#define LM3633_REG_PWM_CFG 0x2F
+
+#define LM3633_REG_BRT_HVLED_A_LSB 0x40
+#define LM3633_REG_BRT_HVLED_A_MSB 0x41
+#define LM3633_REG_BRT_HVLED_B_LSB 0x42
+#define LM3633_REG_BRT_HVLED_B_MSB 0x43
+#define LM3633_BRT_HVLED_LSB_MASK (BIT(0) | BIT(1) | BIT(2))
+#define LM3633_BRT_HVLED_MSB_SHIFT 3
+
+#define LM3633_REG_BRT_LVLED_BASE 0x44
+
+#define LM3633_REG_PTN_DELAY 0x50
+
+#define LM3633_REG_PTN_LOWTIME 0x51
+
+#define LM3633_REG_PTN_HIGHTIME 0x52
+
+#define LM3633_REG_PTN_LOWBRT 0x53
+
+#define LM3633_REG_PTN_HIGHBRT LM3633_REG_BRT_LVLED_BASE
+
+#define LM3633_REG_BL_OPEN_FAULT_STATUS 0xB0
+
+#define LM3633_REG_BL_SHORT_FAULT_STATUS 0xB2
+
+#define LM3633_REG_MONITOR_ENABLE 0xB4
+
+#define LM3633_MAX_REG 0xB4
+
+/* LM3695 */
+#define LM3695_REG_GP 0x10
+#define LM3695_BL_STRING_MASK BIT(3)
+#define LM3695_BL_TWO_STRINGS 0
+#define LM3695_BL_ONE_STRING BIT(3)
+#define LM3695_BRT_RW_MASK BIT(2)
+#define LM3695_BL_EN_MASK BIT(0)
+
+#define LM3695_REG_BRT_LSB 0x13
+#define LM3695_BRT_LSB_MASK (BIT(0) | BIT(1) | BIT(2))
+#define LM3695_REG_BRT_MSB 0x14
+#define LM3695_BRT_MSB_SHIFT 3
+
+#define LM3695_MAX_REG 0x14
+
+/* LM3697 */
+#define LM3697_REG_HVLED_OUTPUT_CFG 0x10
+
+#define LM3697_REG_BL0_RAMPUP 0x11
+#define LM3697_REG_BL0_RAMPDN LM3697_REG_BL0_RAMPUP
+#define LM3697_REG_BL1_RAMPUP 0x12
+#define LM3697_REG_BL1_RAMPDN LM3697_REG_BL1_RAMPUP
+#define LM3697_BL_RAMPUP_MASK 0xF0
+#define LM3697_BL_RAMPUP_SHIFT 4
+#define LM3697_BL_RAMPDN_MASK 0x0F
+#define LM3697_BL_RAMPDN_SHIFT 0
+
+#define LM3697_REG_RAMP_CONF 0x14
+#define LM3697_RAMP_MASK 0x0F
+#define LM3697_RAMP_EACH 0x05
+
+#define LM3697_REG_PWM_CFG 0x1C
+
+#define LM3697_REG_IMAX_A 0x17
+#define LM3697_REG_IMAX_B 0x18
+
+#define LM3697_REG_FEEDBACK_ENABLE 0x19
+
+#define LM3697_REG_BRT_A_LSB 0x20
+#define LM3697_REG_BRT_A_MSB 0x21
+#define LM3697_REG_BRT_B_LSB 0x22
+#define LM3697_REG_BRT_B_MSB 0x23
+#define LM3697_BRT_LSB_MASK (BIT(0) | BIT(1) | BIT(2))
+#define LM3697_BRT_MSB_SHIFT 3
+
+#define LM3697_REG_ENABLE 0x24
+
+#define LM3697_REG_OPEN_FAULT_STATUS 0xB0
+
+#define LM3697_REG_SHORT_FAULT_STATUS 0xB2
+
+#define LM3697_REG_MONITOR_ENABLE 0xB4
+
+#define LM3697_MAX_REG 0xB4
+#endif
diff --git a/include/linux/mfd/ti-lmu.h b/include/linux/mfd/ti-lmu.h
new file mode 100644
index 0000000..eeb6b9e
--- /dev/null
+++ b/include/linux/mfd/ti-lmu.h
@@ -0,0 +1,81 @@
+/*
+ * TI LMU(Lighting Management Unit) Devices
+ *
+ * Copyright 2015 Texas Instruments
+ *
+ * Author: Milo Kim <milo.kim@ti.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef __MFD_TI_LMU_H__
+#define __MFD_TI_LMU_H__
+
+#include <linux/gpio.h>
+#include <linux/regmap.h>
+
+/* Notifier event */
+#define LMU_EVENT_HWMON_DONE 0x01
+
+enum ti_lmu_max_current {
+ LMU_IMAX_5mA,
+ LMU_IMAX_6mA,
+ LMU_IMAX_7mA = 0x03,
+ LMU_IMAX_8mA,
+ LMU_IMAX_9mA,
+ LMU_IMAX_10mA = 0x07,
+ LMU_IMAX_11mA,
+ LMU_IMAX_12mA,
+ LMU_IMAX_13mA,
+ LMU_IMAX_14mA,
+ LMU_IMAX_15mA = 0x0D,
+ LMU_IMAX_16mA,
+ LMU_IMAX_17mA,
+ LMU_IMAX_18mA,
+ LMU_IMAX_19mA,
+ LMU_IMAX_20mA = 0x13,
+ LMU_IMAX_21mA,
+ LMU_IMAX_22mA,
+ LMU_IMAX_23mA = 0x17,
+ LMU_IMAX_24mA,
+ LMU_IMAX_25mA,
+ LMU_IMAX_26mA,
+ LMU_IMAX_27mA = 0x1C,
+ LMU_IMAX_28mA,
+ LMU_IMAX_29mA,
+ LMU_IMAX_30mA,
+};
+
+enum lm363x_regulator_id {
+ LM3631_BOOST, /* Boost output */
+ LM3631_LDO_CONT, /* Display panel controller */
+ LM3631_LDO_OREF, /* Gamma reference */
+ LM3631_LDO_POS, /* Positive display bias output */
+ LM3631_LDO_NEG, /* Negative display bias output */
+ LM3632_BOOST, /* Boost output */
+ LM3632_LDO_POS, /* Positive display bias output */
+ LM3632_LDO_NEG, /* Negative display bias output */
+};
+
+/**
+ * struct ti_lmu
+ *
+ * @dev: Parent device pointer
+ * @regmap: Used for i2c communcation on accessing registers
+ * @en_gpio: GPIO for HWEN pin [Optional]
+ * @notifier: Notifier for reporting hwmon event
+ */
+struct ti_lmu {
+ struct device *dev;
+ struct regmap *regmap;
+ int en_gpio;
+ struct blocking_notifier_head notifier;
+};
+
+int ti_lmu_read_byte(struct ti_lmu *lmu, u8 reg, u8 *read);
+int ti_lmu_write_byte(struct ti_lmu *lmu, u8 reg, u8 data);
+int ti_lmu_update_bits(struct ti_lmu *lmu, u8 reg, u8 mask, u8 data);
+enum ti_lmu_max_current ti_lmu_get_current_code(u32 imax_microamp);
+#endif
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Milo Kim <milo.kim@ti.com> |
|---|---|
| Date | 2015-11-02 06:30 +0100 |
| Subject | [PATCH RESEND 13/16] backlight: ti-lmu-backlight: add LM3697 driver |
| Message-ID | <qqfQS-1lO-35@gated-at.bofh.it> |
| In reply to | #1260395 |
LM3697 has 3 backlight strings and 11 bit dimming is supported.
PWM brightness control is also supported.
LM3697 MFD has HWMON driver which monitors hardware fault detection.
After this monitoring is done, LM3697 backlight device should be
reinitialized. To enable this, 'hwmon_notifier_used' is set to true.
Then, TI LMU backlight handles LMU HWMON event in
ti_lmu_backlight_hwmon_notifier().
Common backlight driver is controlled by TI LMU backlight driver.
Only LM3697 specific code is implemented here.
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Milo Kim <milo.kim@ti.com>
---
drivers/video/backlight/Kconfig | 9 ++
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/lm3697_bl.c | 187 ++++++++++++++++++++++++++++++++++++
3 files changed, 197 insertions(+)
create mode 100644 drivers/video/backlight/lm3697_bl.c
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index c1dc908..c672073 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -434,6 +434,15 @@ config BACKLIGHT_LM3695
Say Y to enable the backlight driver for TI LM3695.
Up to 2 backlight strings and 11 bit dimming is supported.
+config BACKLIGHT_LM3697
+ tristate "Backlight driver for TI LM3697"
+ depends on BACKLIGHT_CLASS_DEVICE && MFD_TI_LMU
+ select TI_LMU_BACKLIGHT
+ help
+ Say Y to enable the backlight driver for TI LM3697.
+ Up to 3 backlight strings and 11 bit dimming is supported.
+ PWM brightness control is also supported.
+
config TI_LMU_BACKLIGHT
tristate "Backlight driver for TI LMU"
depends on BACKLIGHT_LM3532 || BACKLIGHT_LM3631 || \
diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Makefile
index af20285..abb7fe0 100644
--- a/drivers/video/backlight/Makefile
+++ b/drivers/video/backlight/Makefile
@@ -44,6 +44,7 @@ obj-$(CONFIG_BACKLIGHT_LM3632) += lm3632_bl.o
obj-$(CONFIG_BACKLIGHT_LM3633) += lm3633_bl.o
obj-$(CONFIG_BACKLIGHT_LM3639) += lm3639_bl.o
obj-$(CONFIG_BACKLIGHT_LM3695) += lm3695_bl.o
+obj-$(CONFIG_BACKLIGHT_LM3697) += lm3697_bl.o
obj-$(CONFIG_BACKLIGHT_LOCOMO) += locomolcd.o
obj-$(CONFIG_BACKLIGHT_LP855X) += lp855x_bl.o
obj-$(CONFIG_BACKLIGHT_LP8788) += lp8788_bl.o
diff --git a/drivers/video/backlight/lm3697_bl.c b/drivers/video/backlight/lm3697_bl.c
new file mode 100644
index 0000000..bb0c2bf
--- /dev/null
+++ b/drivers/video/backlight/lm3697_bl.c
@@ -0,0 +1,187 @@
+/*
+ * TI LM3697 Backlight Driver
+ *
+ * Copyright 2015 Texas Instruments
+ *
+ * Author: Milo Kim <milo.kim@ti.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/kernel.h>
+#include <linux/mfd/ti-lmu.h>
+#include <linux/mfd/ti-lmu-register.h>
+#include <linux/module.h>
+
+#include "ti-lmu-backlight.h"
+
+#define LM3697_BL_MAX_STRINGS 3
+#define LM3697_MAX_BRIGHTNESS 2047
+
+static int lm3697_bl_init(struct ti_lmu_bl_chip *chip)
+{
+ /* Configure ramp selection for each bank */
+ return ti_lmu_update_bits(chip->lmu, LM3697_REG_RAMP_CONF,
+ LM3697_RAMP_MASK, LM3697_RAMP_EACH);
+}
+
+static int lm3697_bl_enable(struct ti_lmu_bl *lmu_bl, int enable)
+{
+ return ti_lmu_update_bits(lmu_bl->chip->lmu, LM3697_REG_ENABLE,
+ BIT(lmu_bl->bank_id),
+ enable << lmu_bl->bank_id);
+}
+
+static int lm3697_bl_set_brightness(struct ti_lmu_bl *lmu_bl, int brightness)
+{
+ int ret;
+ u8 data;
+ u8 reg_lsb[] = { LM3697_REG_BRT_A_LSB, LM3697_REG_BRT_B_LSB, };
+ u8 reg_msb[] = { LM3697_REG_BRT_A_MSB, LM3697_REG_BRT_B_MSB, };
+
+ data = brightness & LM3697_BRT_LSB_MASK;
+ ret = ti_lmu_update_bits(lmu_bl->chip->lmu, reg_lsb[lmu_bl->bank_id],
+ LM3697_BRT_LSB_MASK, data);
+ if (ret)
+ return ret;
+
+ data = (brightness >> LM3697_BRT_MSB_SHIFT) & 0xFF;
+ return ti_lmu_write_byte(lmu_bl->chip->lmu, reg_msb[lmu_bl->bank_id],
+ data);
+}
+
+static int lm3697_bl_set_ctrl_mode(struct ti_lmu_bl *lmu_bl)
+{
+ int bank_id = lmu_bl->bank_id;
+
+ if (lmu_bl->mode == BL_PWM_BASED)
+ return ti_lmu_update_bits(lmu_bl->chip->lmu,
+ LM3697_REG_PWM_CFG,
+ BIT(bank_id), 1 << bank_id);
+
+ return 0;
+}
+
+static int lm3697_bl_string_configure(struct ti_lmu_bl *lmu_bl)
+{
+ struct ti_lmu *lmu = lmu_bl->chip->lmu;
+ int bank_id = lmu_bl->bank_id;
+ int is_detected = 0;
+ int i, ret;
+
+ /* Assign control bank from backlight string configuration */
+ for (i = 0; i < LM3697_BL_MAX_STRINGS; i++) {
+ if (test_bit(i, &lmu_bl->bl_string)) {
+ ret = ti_lmu_update_bits(lmu,
+ LM3697_REG_HVLED_OUTPUT_CFG,
+ BIT(i), bank_id << i);
+ if (ret)
+ return ret;
+
+ is_detected = 1;
+ }
+ }
+
+ if (!is_detected) {
+ dev_err(lmu_bl->chip->dev, "No backlight string found\n");
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+static int lm3697_bl_set_current_limit(struct ti_lmu_bl *lmu_bl)
+{
+ u8 reg[] = { LM3697_REG_IMAX_A, LM3697_REG_IMAX_B, };
+
+ return ti_lmu_write_byte(lmu_bl->chip->lmu, reg[lmu_bl->bank_id],
+ lmu_bl->imax);
+}
+
+static int lm3697_bl_set_ramp(struct ti_lmu_bl *lmu_bl)
+{
+ int ret, index;
+ u8 reg;
+
+ index = ti_lmu_backlight_get_ramp_index(lmu_bl, BL_RAMP_UP);
+ if (index > 0) {
+ if (lmu_bl->bank_id == 0)
+ reg = LM3697_REG_BL0_RAMPUP;
+ else
+ reg = LM3697_REG_BL1_RAMPUP;
+
+ ret = ti_lmu_update_bits(lmu_bl->chip->lmu, reg,
+ LM3697_BL_RAMPUP_MASK,
+ index << LM3697_BL_RAMPUP_SHIFT);
+ if (ret)
+ return ret;
+ }
+
+ index = ti_lmu_backlight_get_ramp_index(lmu_bl, BL_RAMP_DOWN);
+ if (index > 0) {
+ if (lmu_bl->bank_id == 0)
+ reg = LM3697_REG_BL0_RAMPDN;
+ else
+ reg = LM3697_REG_BL1_RAMPDN;
+
+ ret = ti_lmu_update_bits(lmu_bl->chip->lmu, reg,
+ LM3697_BL_RAMPDN_MASK,
+ index << LM3697_BL_RAMPDN_SHIFT);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
+static int lm3697_bl_configure(struct ti_lmu_bl *lmu_bl)
+{
+ int ret;
+
+ ret = lm3697_bl_set_ctrl_mode(lmu_bl);
+ if (ret)
+ return ret;
+
+ ret = lm3697_bl_string_configure(lmu_bl);
+ if (ret)
+ return ret;
+
+ ret = lm3697_bl_set_current_limit(lmu_bl);
+ if (ret)
+ return ret;
+
+ ret = lm3697_bl_set_ramp(lmu_bl);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+
+/* Backlight ramp up/down time. Unit is msec. */
+static const int lm3697_ramp_table[] = {
+ 2, 250, 500, 1000, 2000, 4000, 8000, 16000,
+};
+
+static const struct ti_lmu_bl_ops lm3697_lmu_ops = {
+ .init = lm3697_bl_init,
+ .configure = lm3697_bl_configure,
+ .update_brightness = lm3697_bl_set_brightness,
+ .bl_enable = lm3697_bl_enable,
+ .hwmon_notifier_used = true,
+ .max_brightness = LM3697_MAX_BRIGHTNESS,
+ .ramp_table = lm3697_ramp_table,
+ .size_ramp = ARRAY_SIZE(lm3697_ramp_table),
+};
+
+/* LM3697 backlight of_device_id */
+TI_LMU_BL_OF_DEVICE(lm3697, "ti,lm3697-backlight");
+
+/* LM3697 backlight platform driver */
+TI_LMU_BL_PLATFORM_DRIVER(lm3697, "lm3697-backlight");
+
+MODULE_DESCRIPTION("TI LM3697 Backlight Driver");
+MODULE_AUTHOR("Milo Kim");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:lm3697-backlight");
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Milo Kim <milo.kim@ti.com> |
|---|---|
| Date | 2015-11-02 06:30 +0100 |
| Subject | [PATCH RESEND 03/16] Documentation: dt-bindings: hwmon: add TI LMU HWMON binding information |
| Message-ID | <qqfQT-1lO-39@gated-at.bofh.it> |
| In reply to | #1260395 |
Hardware fault monitoring driver is used in LM3633 and LM3697 device. Just 'compatible' property is required to describe the driver. Cc: devicetree@vger.kernel.org Cc: Guenter Roeck <linux@roeck-us.net> Cc: Jean Delvare <jdelvare@suse.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: lm-sensors@lm-sensors.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim <milo.kim@ti.com> --- Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt diff --git a/Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt b/Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt new file mode 100644 index 0000000..99cb241 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt @@ -0,0 +1,12 @@ +TI LMU Hardware Monotoring device tree bindings + +LMU HWON driver monitors hardware fault situation of LMU devices, +LM3633 and LM3697. + +Required properties: + - compatible: Should be one of lists below. + "ti,lm3633-hwmon" + "ti,lm3697-hwmon" + +Examples: Please refer to ti-lmu dt-bindings. + Documentation/devicetree/bindings/mfd/ti-lmu.txt -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2015-11-06 03:00 +0100 |
| Subject | Re: [PATCH RESEND 03/16] Documentation: dt-bindings: hwmon: add TI LMU HWMON binding information |
| Message-ID | <qrEtQ-6oo-9@gated-at.bofh.it> |
| In reply to | #1260400 |
On Mon, Nov 02, 2015 at 02:24:22PM +0900, Milo Kim wrote: > Hardware fault monitoring driver is used in LM3633 and LM3697 device. > Just 'compatible' property is required to describe the driver. > > Cc: devicetree@vger.kernel.org > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Jean Delvare <jdelvare@suse.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: lm-sensors@lm-sensors.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Milo Kim <milo.kim@ti.com> Acked-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt b/Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt > new file mode 100644 > index 0000000..99cb241 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt > @@ -0,0 +1,12 @@ > +TI LMU Hardware Monotoring device tree bindings > + > +LMU HWON driver monitors hardware fault situation of LMU devices, > +LM3633 and LM3697. > + > +Required properties: > + - compatible: Should be one of lists below. > + "ti,lm3633-hwmon" > + "ti,lm3697-hwmon" > + > +Examples: Please refer to ti-lmu dt-bindings. > + Documentation/devicetree/bindings/mfd/ti-lmu.txt > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Kim, Milo" <milo.kim@ti.com> |
|---|---|
| Date | 2015-11-06 05:00 +0100 |
| Subject | Re: [PATCH RESEND 03/16] Documentation: dt-bindings: hwmon: add TI LMU HWMON binding information |
| Message-ID | <qrGlY-7Gq-3@gated-at.bofh.it> |
| In reply to | #1263698 |
On 11/6/2015 10:57 AM, Rob Herring wrote: > On Mon, Nov 02, 2015 at 02:24:22PM +0900, Milo Kim wrote: >> Hardware fault monitoring driver is used in LM3633 and LM3697 device. >> Just 'compatible' property is required to describe the driver. >> >> Cc: devicetree@vger.kernel.org >> Cc: Guenter Roeck <linux@roeck-us.net> >> Cc: Jean Delvare <jdelvare@suse.com> >> Cc: Lee Jones <lee.jones@linaro.org> >> Cc: lm-sensors@lm-sensors.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Milo Kim <milo.kim@ti.com> > > Acked-by: Rob Herring <robh@kernel.org> Thanks for your review, Rob. HWMON maintainer, Guenter suggested moving LMU HWMON driver to MFD as the sysfs attributes because it has no sensor data like temperature or voltage. So I'll move this property to mfd/ti-lmu.txt in the next patch. Best regards, Milo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-11-02 10:00 +0100 |
| Message-ID | <qqj86-3aX-11@gated-at.bofh.it> |
| In reply to | #1260395 |
On Mon, 02 Nov 2015, Milo Kim wrote: > TI LMU(Lighting Management Unit) driver supports lighting devices below. > > Enable pin Backlights HWMON LEDs Regulators > ---------- ---------- ----- ---- ------------ > LM3532 o o x x x > LM3631 o o x x 5 regulators > LM3632 o o x x 3 regulators > LM3633 o o o o x > LM3695 o o x x x > LM3697 o o o x x > > This patch-set consists of several parts below. > > DT bindings : Binding information for each module > TI LMU MFD : Device registration, HW enable pin control and > I2C register access > TI LMU backlight : Common driver for TI LMU backlight devices > Each backlight driver : Chip dependent code > HWMON : LMU hardware fault monitoring driver > LM3633 LED : LED subsystem and dimming pattern generation > supported > LM363X regulator : LM3631 and LM3632 regulator driver for the > display bias > > Git location: > Please refer to the location below. Branch name is 'ti-lmu'. > git clone -b ti-lmu https://github.com/milokim/linux.git > > Milo Kim (16): > Documentation: dt-bindings: mfd: add TI LMU device binding information > Documentation: dt-bindings: backlight: add TI LMU backlight binding > information > Documentation: dt-bindings: hwmon: add TI LMU HWMON binding > information > Documentation: dt-bindings: leds: add LM3633 LED binding information > Documentation: dt-bindings: regulator: add LM363x regulator binding > information > mfd: add TI LMU driver > backlight: add TI LMU backlight common driver > backlight: ti-lmu-backlight: add LM3532 driver > backlight: ti-lmu-backlight: add LM3631 driver > backlight: ti-lmu-backlight: add LM3632 driver > backlight: ti-lmu-backlight: add LM3633 driver > backlight: ti-lmu-backlight: add LM3695 driver > backlight: ti-lmu-backlight: add LM3697 driver > hwmon: add TI LMU hardware fault monitoring driver > leds: add LM3633 driver > regulator: add LM363X driver > > Documentation/ABI/testing/sysfs-class-led-lm3633 | 60 ++ > .../devicetree/bindings/hwmon/ti-lmu-hwmon.txt | 12 + > .../devicetree/bindings/leds/leds-lm3633.txt | 28 + > Documentation/devicetree/bindings/mfd/ti-lmu.txt | 282 ++++++++ > .../bindings/regulator/lm363x-regulator.txt | 28 + > .../bindings/video/backlight/ti-lmu-backlight.txt | 67 ++ > drivers/hwmon/Kconfig | 10 + > drivers/hwmon/Makefile | 1 + > drivers/hwmon/ti-lmu-hwmon.c | 393 +++++++++++ > drivers/leds/Kconfig | 10 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-lm3633.c | 749 +++++++++++++++++++++ > drivers/mfd/Kconfig | 12 + > drivers/mfd/Makefile | 1 + > drivers/mfd/ti-lmu.c | 324 +++++++++ > drivers/regulator/Kconfig | 9 + > drivers/regulator/Makefile | 1 + > drivers/regulator/lm363x-regulator.c | 349 ++++++++++ > drivers/video/backlight/Kconfig | 62 ++ > drivers/video/backlight/Makefile | 7 + > drivers/video/backlight/lm3532_bl.c | 183 +++++ > drivers/video/backlight/lm3631_bl.c | 129 ++++ > drivers/video/backlight/lm3632_bl.c | 125 ++++ > drivers/video/backlight/lm3633_bl.c | 210 ++++++ > drivers/video/backlight/lm3695_bl.c | 91 +++ > drivers/video/backlight/lm3697_bl.c | 187 +++++ > drivers/video/backlight/ti-lmu-backlight.c | 429 ++++++++++++ > drivers/video/backlight/ti-lmu-backlight.h | 152 +++++ How different are all of these drivers? Can you create one driver that supports them all instead? > include/linux/mfd/ti-lmu-register.h | 277 ++++++++ > include/linux/mfd/ti-lmu.h | 81 +++ > 30 files changed, 4270 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-class-led-lm3633 > create mode 100644 Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt > create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3633.txt > create mode 100644 Documentation/devicetree/bindings/mfd/ti-lmu.txt > create mode 100644 Documentation/devicetree/bindings/regulator/lm363x-regulator.txt > create mode 100644 Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt > create mode 100644 drivers/hwmon/ti-lmu-hwmon.c > create mode 100644 drivers/leds/leds-lm3633.c > create mode 100644 drivers/mfd/ti-lmu.c > create mode 100644 drivers/regulator/lm363x-regulator.c > create mode 100644 drivers/video/backlight/lm3532_bl.c > create mode 100644 drivers/video/backlight/lm3631_bl.c > create mode 100644 drivers/video/backlight/lm3632_bl.c > create mode 100644 drivers/video/backlight/lm3633_bl.c > create mode 100644 drivers/video/backlight/lm3695_bl.c > create mode 100644 drivers/video/backlight/lm3697_bl.c > create mode 100644 drivers/video/backlight/ti-lmu-backlight.c > create mode 100644 drivers/video/backlight/ti-lmu-backlight.h > create mode 100644 include/linux/mfd/ti-lmu-register.h > create mode 100644 include/linux/mfd/ti-lmu.h > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Kim, Milo" <milo.kim@ti.com> |
|---|---|
| Date | 2015-11-03 08:00 +0100 |
| Message-ID | <qqDJw-7Cn-1@gated-at.bofh.it> |
| In reply to | #1260460 |
Hi Lee, On 11/2/2015 5:59 PM, Lee Jones wrote: >> drivers/video/backlight/Kconfig | 62 ++ >> > drivers/video/backlight/Makefile | 7 + >> > drivers/video/backlight/lm3532_bl.c | 183 +++++ >> > drivers/video/backlight/lm3631_bl.c | 129 ++++ >> > drivers/video/backlight/lm3632_bl.c | 125 ++++ >> > drivers/video/backlight/lm3633_bl.c | 210 ++++++ >> > drivers/video/backlight/lm3695_bl.c | 91 +++ >> > drivers/video/backlight/lm3697_bl.c | 187 +++++ >> > drivers/video/backlight/ti-lmu-backlight.c | 429 ++++++++++++ >> > drivers/video/backlight/ti-lmu-backlight.h | 152 +++++ > How different are all of these drivers? > > Can you create one driver that supports them all instead? > Thanks for your suggestion. 'ti-lmu-backlight' is the common part of lmxxxx_bl drivers. And each lmxxx_bl has its own operation functions by using ti_lmu_bl_ops. I've tried to make consolidated driver but it contained too much device specific code in one file. So I prefer simple drivers structure - 'common part' and 'device specific operations'. It would be appreciated if you could introduce better idea. Best regards, Milo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-11-03 09:50 +0100 |
| Message-ID | <qqFrY-jV-9@gated-at.bofh.it> |
| In reply to | #1261228 |
On Tue, 03 Nov 2015, Kim, Milo wrote: > Hi Lee, > > On 11/2/2015 5:59 PM, Lee Jones wrote: > >> drivers/video/backlight/Kconfig | 62 ++ > >>> drivers/video/backlight/Makefile | 7 + > >>> drivers/video/backlight/lm3532_bl.c | 183 +++++ > >>> drivers/video/backlight/lm3631_bl.c | 129 ++++ > >>> drivers/video/backlight/lm3632_bl.c | 125 ++++ > >>> drivers/video/backlight/lm3633_bl.c | 210 ++++++ > >>> drivers/video/backlight/lm3695_bl.c | 91 +++ > >>> drivers/video/backlight/lm3697_bl.c | 187 +++++ > >>> drivers/video/backlight/ti-lmu-backlight.c | 429 ++++++++++++ > >>> drivers/video/backlight/ti-lmu-backlight.h | 152 +++++ > >How different are all of these drivers? > > > >Can you create one driver that supports them all instead? > > > > Thanks for your suggestion. > > 'ti-lmu-backlight' is the common part of lmxxxx_bl drivers. And each > lmxxx_bl has its own operation functions by using ti_lmu_bl_ops. > I've tried to make consolidated driver but it contained too much > device specific code in one file. So I prefer simple drivers > structure - 'common part' and 'device specific operations'. > It would be appreciated if you could introduce better idea. I wish to avoid having to apply the patches to conduct my own analysis of the files, as I am severely restricted on time. Can you tell me how much duplicated code there is between the files? How many lines would be saved by supporting all of the lm* drivers in a single file? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Kim, Milo" <milo.kim@ti.com> |
|---|---|
| Date | 2015-11-03 10:10 +0100 |
| Message-ID | <qqFLk-Gf-5@gated-at.bofh.it> |
| In reply to | #1261300 |
On 11/3/2015 5:33 PM, Lee Jones wrote: > On Tue, 03 Nov 2015, Kim, Milo wrote: > >> Hi Lee, >> >> On 11/2/2015 5:59 PM, Lee Jones wrote: >>>> drivers/video/backlight/Kconfig | 62 ++ >>>>> drivers/video/backlight/Makefile | 7 + >>>>> drivers/video/backlight/lm3532_bl.c | 183 +++++ >>>>> drivers/video/backlight/lm3631_bl.c | 129 ++++ >>>>> drivers/video/backlight/lm3632_bl.c | 125 ++++ >>>>> drivers/video/backlight/lm3633_bl.c | 210 ++++++ >>>>> drivers/video/backlight/lm3695_bl.c | 91 +++ >>>>> drivers/video/backlight/lm3697_bl.c | 187 +++++ >>>>> drivers/video/backlight/ti-lmu-backlight.c | 429 ++++++++++++ >>>>> drivers/video/backlight/ti-lmu-backlight.h | 152 +++++ >>> How different are all of these drivers? >>> >>> Can you create one driver that supports them all instead? >>> >> >> Thanks for your suggestion. >> >> 'ti-lmu-backlight' is the common part of lmxxxx_bl drivers. And each >> lmxxx_bl has its own operation functions by using ti_lmu_bl_ops. >> I've tried to make consolidated driver but it contained too much >> device specific code in one file. So I prefer simple drivers >> structure - 'common part' and 'device specific operations'. >> It would be appreciated if you could introduce better idea. > > I wish to avoid having to apply the patches to conduct my own analysis > of the files, as I am severely restricted on time. Can you tell me how > much duplicated code there is between the files? How many lines would > be saved by supporting all of the lm* drivers in a single file? > Understood. Let me try it again. I'll get back to you soon. Thanks for your help. Best regards, Milo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-11-02 10:10 +0100 |
| Message-ID | <qqjhL-3tg-15@gated-at.bofh.it> |
| In reply to | #1260395 |
Is it just me, or have you missed lots of people off Cc? > TI LMU(Lighting Management Unit) driver supports lighting devices below. > > Enable pin Backlights HWMON LEDs Regulators > ---------- ---------- ----- ---- ------------ > LM3532 o o x x x > LM3631 o o x x 5 regulators > LM3632 o o x x 3 regulators > LM3633 o o o o x > LM3695 o o x x x > LM3697 o o o x x > > This patch-set consists of several parts below. > > DT bindings : Binding information for each module > TI LMU MFD : Device registration, HW enable pin control and > I2C register access > TI LMU backlight : Common driver for TI LMU backlight devices > Each backlight driver : Chip dependent code > HWMON : LMU hardware fault monitoring driver > LM3633 LED : LED subsystem and dimming pattern generation > supported > LM363X regulator : LM3631 and LM3632 regulator driver for the > display bias > > Git location: > Please refer to the location below. Branch name is 'ti-lmu'. > git clone -b ti-lmu https://github.com/milokim/linux.git > > Milo Kim (16): > Documentation: dt-bindings: mfd: add TI LMU device binding information > Documentation: dt-bindings: backlight: add TI LMU backlight binding > information > Documentation: dt-bindings: hwmon: add TI LMU HWMON binding > information > Documentation: dt-bindings: leds: add LM3633 LED binding information > Documentation: dt-bindings: regulator: add LM363x regulator binding > information > mfd: add TI LMU driver > backlight: add TI LMU backlight common driver > backlight: ti-lmu-backlight: add LM3532 driver > backlight: ti-lmu-backlight: add LM3631 driver > backlight: ti-lmu-backlight: add LM3632 driver > backlight: ti-lmu-backlight: add LM3633 driver > backlight: ti-lmu-backlight: add LM3695 driver > backlight: ti-lmu-backlight: add LM3697 driver > hwmon: add TI LMU hardware fault monitoring driver > leds: add LM3633 driver > regulator: add LM363X driver > > Documentation/ABI/testing/sysfs-class-led-lm3633 | 60 ++ > .../devicetree/bindings/hwmon/ti-lmu-hwmon.txt | 12 + > .../devicetree/bindings/leds/leds-lm3633.txt | 28 + > Documentation/devicetree/bindings/mfd/ti-lmu.txt | 282 ++++++++ > .../bindings/regulator/lm363x-regulator.txt | 28 + > .../bindings/video/backlight/ti-lmu-backlight.txt | 67 ++ > drivers/hwmon/Kconfig | 10 + > drivers/hwmon/Makefile | 1 + > drivers/hwmon/ti-lmu-hwmon.c | 393 +++++++++++ > drivers/leds/Kconfig | 10 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-lm3633.c | 749 +++++++++++++++++++++ > drivers/mfd/Kconfig | 12 + > drivers/mfd/Makefile | 1 + > drivers/mfd/ti-lmu.c | 324 +++++++++ > drivers/regulator/Kconfig | 9 + > drivers/regulator/Makefile | 1 + > drivers/regulator/lm363x-regulator.c | 349 ++++++++++ > drivers/video/backlight/Kconfig | 62 ++ > drivers/video/backlight/Makefile | 7 + > drivers/video/backlight/lm3532_bl.c | 183 +++++ > drivers/video/backlight/lm3631_bl.c | 129 ++++ > drivers/video/backlight/lm3632_bl.c | 125 ++++ > drivers/video/backlight/lm3633_bl.c | 210 ++++++ > drivers/video/backlight/lm3695_bl.c | 91 +++ > drivers/video/backlight/lm3697_bl.c | 187 +++++ > drivers/video/backlight/ti-lmu-backlight.c | 429 ++++++++++++ > drivers/video/backlight/ti-lmu-backlight.h | 152 +++++ > include/linux/mfd/ti-lmu-register.h | 277 ++++++++ > include/linux/mfd/ti-lmu.h | 81 +++ > 30 files changed, 4270 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-class-led-lm3633 > create mode 100644 Documentation/devicetree/bindings/hwmon/ti-lmu-hwmon.txt > create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3633.txt > create mode 100644 Documentation/devicetree/bindings/mfd/ti-lmu.txt > create mode 100644 Documentation/devicetree/bindings/regulator/lm363x-regulator.txt > create mode 100644 Documentation/devicetree/bindings/video/backlight/ti-lmu-backlight.txt > create mode 100644 drivers/hwmon/ti-lmu-hwmon.c > create mode 100644 drivers/leds/leds-lm3633.c > create mode 100644 drivers/mfd/ti-lmu.c > create mode 100644 drivers/regulator/lm363x-regulator.c > create mode 100644 drivers/video/backlight/lm3532_bl.c > create mode 100644 drivers/video/backlight/lm3631_bl.c > create mode 100644 drivers/video/backlight/lm3632_bl.c > create mode 100644 drivers/video/backlight/lm3633_bl.c > create mode 100644 drivers/video/backlight/lm3695_bl.c > create mode 100644 drivers/video/backlight/lm3697_bl.c > create mode 100644 drivers/video/backlight/ti-lmu-backlight.c > create mode 100644 drivers/video/backlight/ti-lmu-backlight.h > create mode 100644 include/linux/mfd/ti-lmu-register.h > create mode 100644 include/linux/mfd/ti-lmu.h > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Kim, Milo" <milo.kim@ti.com> |
|---|---|
| Date | 2015-11-03 08:10 +0100 |
| Message-ID | <qqDTc-7Wb-21@gated-at.bofh.it> |
| In reply to | #1260469 |
Hi Lee, On 11/2/2015 6:00 PM, Lee Jones wrote: > Is it just me, or have you missed lots of people off Cc? Ah, that's what I was hesitating... What is the best way to submit MFD code patches? Cc for all people from get_maintainer.pl? Best regards, Milo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-11-03 09:50 +0100 |
| Message-ID | <qqFrZ-jV-31@gated-at.bofh.it> |
| In reply to | #1261236 |
On Tue, 03 Nov 2015, Kim, Milo wrote: > Hi Lee, > > On 11/2/2015 6:00 PM, Lee Jones wrote: > >Is it just me, or have you missed lots of people off Cc? > > Ah, that's what I was hesitating... > What is the best way to submit MFD code patches? Cc for all people > from get_maintainer.pl? As this is a 0th patch of a set which touches many different subsystems, I suggest that you should have Cc'ed all of the Maintainers of the subsystems you changed. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web