Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1261300

Re: [PATCH RESEND 00/16] Support TI LMU devices

Show all headers | View raw

On Tue, 03 Nov 2015, Kim, Milo wrote:

> Hi Lee,
> 
> On 11/2/2015 5:59 PM, Lee Jones wrote:
> >>  drivers/video/backlight/Kconfig                    |  62 ++
> >>>  drivers/video/backlight/Makefile                   |   7 +
> >>>  drivers/video/backlight/lm3532_bl.c                | 183 +++++
> >>>  drivers/video/backlight/lm3631_bl.c                | 129 ++++
> >>>  drivers/video/backlight/lm3632_bl.c                | 125 ++++
> >>>  drivers/video/backlight/lm3633_bl.c                | 210 ++++++
> >>>  drivers/video/backlight/lm3695_bl.c                |  91 +++
> >>>  drivers/video/backlight/lm3697_bl.c                | 187 +++++
> >>>  drivers/video/backlight/ti-lmu-backlight.c         | 429 ++++++++++++
> >>>  drivers/video/backlight/ti-lmu-backlight.h         | 152 +++++
> >How different are all of these drivers?
> >
> >Can you create one driver that supports them all instead?
> >
> 
> Thanks for your suggestion.
> 
> 'ti-lmu-backlight' is the common part of lmxxxx_bl drivers. And each
> lmxxx_bl has its own operation functions by using ti_lmu_bl_ops.
> I've tried to make consolidated driver but it contained too much
> device specific code in one file. So I prefer simple drivers
> structure - 'common part' and 'device specific operations'.
> It would be appreciated if you could introduce better idea.

I wish to avoid having to apply the patches to conduct my own analysis
of the files, as I am severely restricted on time.  Can you tell me how
much duplicated code there is between the files?  How many lines would
be saved by supporting all of the lm* drivers in a single file?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND 00/16] Support TI LMU devices Milo Kim <milo.kim@ti.com> - 2015-11-02 06:30 +0100
  [PATCH RESEND 02/16] Documentation: dt-bindings: backlight: add TI LMU backlight binding information Milo Kim <milo.kim@ti.com> - 2015-11-02 06:30 +0100
    Re: [PATCH RESEND 02/16] Documentation: dt-bindings: backlight: add  TI LMU backlight binding information Rob Herring <robh@kernel.org> - 2015-11-02 16:10 +0100
      Re: [PATCH RESEND 02/16] Documentation: dt-bindings: backlight: add  TI LMU backlight binding information "Kim, Milo" <milo.kim@ti.com> - 2015-11-03 08:20 +0100
        Re: [PATCH RESEND 02/16] Documentation: dt-bindings: backlight: add  TI LMU backlight binding information Rob Herring <robh@kernel.org> - 2015-11-03 16:40 +0100
  [PATCH RESEND 06/16] mfd: add TI LMU driver Milo Kim <milo.kim@ti.com> - 2015-11-02 06:30 +0100
  [PATCH RESEND 13/16] backlight: ti-lmu-backlight: add LM3697 driver Milo Kim <milo.kim@ti.com> - 2015-11-02 06:30 +0100
  [PATCH RESEND 03/16] Documentation: dt-bindings: hwmon: add TI LMU HWMON binding information Milo Kim <milo.kim@ti.com> - 2015-11-02 06:30 +0100
    Re: [PATCH RESEND 03/16] Documentation: dt-bindings: hwmon: add TI  LMU HWMON binding information Rob Herring <robh@kernel.org> - 2015-11-06 03:00 +0100
      Re: [PATCH RESEND 03/16] Documentation: dt-bindings: hwmon: add TI  LMU HWMON binding information "Kim, Milo" <milo.kim@ti.com> - 2015-11-06 05:00 +0100
  Re: [PATCH RESEND 00/16] Support TI LMU devices Lee Jones <lee.jones@linaro.org> - 2015-11-02 10:00 +0100
    Re: [PATCH RESEND 00/16] Support TI LMU devices "Kim, Milo" <milo.kim@ti.com> - 2015-11-03 08:00 +0100
      Re: [PATCH RESEND 00/16] Support TI LMU devices Lee Jones <lee.jones@linaro.org> - 2015-11-03 09:50 +0100
        Re: [PATCH RESEND 00/16] Support TI LMU devices "Kim, Milo" <milo.kim@ti.com> - 2015-11-03 10:10 +0100
  Re: [PATCH RESEND 00/16] Support TI LMU devices Lee Jones <lee.jones@linaro.org> - 2015-11-02 10:10 +0100
    Re: [PATCH RESEND 00/16] Support TI LMU devices "Kim, Milo" <milo.kim@ti.com> - 2015-11-03 08:10 +0100
      Re: [PATCH RESEND 00/16] Support TI LMU devices Lee Jones <lee.jones@linaro.org> - 2015-11-03 09:50 +0100

csiph-web