Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1259287 > unrolled thread
| Started by | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| First post | 2015-10-30 09:00 +0100 |
| Last post | 2015-10-30 10:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-30 09:00 +0100
Re: [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children Chanwoo Choi <cw00.choi@samsung.com> - 2015-10-30 10:20 +0100
Re: [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children Lee Jones <lee.jones@linaro.org> - 2015-10-30 10:40 +0100
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-10-30 09:00 +0100 |
| Subject | [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children |
| Message-ID | <qpcLo-33V-19@gated-at.bofh.it> |
The commit 54e8827d5f0e ("mfd: sec-core: Add support for S2MPU02
device") added new MFD child devices for S2MPU02: RTC and clock
provider (the clock provider with new compatible). However support for
these devices was not added to existing drivers (rtc-s5m, clk-s2mps11).
New drivers were not submitted neither.
This means that the name of children devices is completely unused. The
"samsung,s2mpu02-clk" compatible remains undocumented so it is unclear
what is provided by that compatible.
Clean up this by removing unused child devices and undocumented
compatible.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
I don't think that removing the "samsung,s2mpu02-clk" compatible would
be considered as ABI break because:
1. Kernel did not document it as ABI.
2. Kernel did not provide any kind of feature for that compatible. It
was totally ignored.
---
drivers/mfd/sec-core.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
index 2626fc0b5b8c..989076d6cb83 100644
--- a/drivers/mfd/sec-core.c
+++ b/drivers/mfd/sec-core.c
@@ -103,12 +103,9 @@ static const struct mfd_cell s2mpa01_devs[] = {
};
static const struct mfd_cell s2mpu02_devs[] = {
- { .name = "s2mpu02-pmic", },
- { .name = "s2mpu02-rtc", },
{
- .name = "s2mpu02-clk",
- .of_compatible = "samsung,s2mpu02-clk",
- }
+ .name = "s2mpu02-pmic",
+ },
};
#ifdef CONFIG_OF
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2015-10-30 10:20 +0100 |
| Message-ID | <qpe0Q-3Z0-37@gated-at.bofh.it> |
| In reply to | #1259287 |
Hi,
On 2015년 10월 30일 16:51, Krzysztof Kozlowski wrote:
> The commit 54e8827d5f0e ("mfd: sec-core: Add support for S2MPU02
> device") added new MFD child devices for S2MPU02: RTC and clock
> provider (the clock provider with new compatible). However support for
> these devices was not added to existing drivers (rtc-s5m, clk-s2mps11).
> New drivers were not submitted neither.
>
> This means that the name of children devices is completely unused. The
> "samsung,s2mpu02-clk" compatible remains undocumented so it is unclear
> what is provided by that compatible.
>
> Clean up this by removing unused child devices and undocumented
> compatible.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> I don't think that removing the "samsung,s2mpu02-clk" compatible would
> be considered as ABI break because:
> 1. Kernel did not document it as ABI.
> 2. Kernel did not provide any kind of feature for that compatible. It
> was totally ignored.
> ---
> drivers/mfd/sec-core.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> index 2626fc0b5b8c..989076d6cb83 100644
> --- a/drivers/mfd/sec-core.c
> +++ b/drivers/mfd/sec-core.c
> @@ -103,12 +103,9 @@ static const struct mfd_cell s2mpa01_devs[] = {
> };
>
> static const struct mfd_cell s2mpu02_devs[] = {
> - { .name = "s2mpu02-pmic", },
> - { .name = "s2mpu02-rtc", },
> {
> - .name = "s2mpu02-clk",
> - .of_compatible = "samsung,s2mpu02-clk",
> - }
> + .name = "s2mpu02-pmic",
> + },
> };
>
> #ifdef CONFIG_OF
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-10-30 10:40 +0100 |
| Message-ID | <qpeka-45t-19@gated-at.bofh.it> |
| In reply to | #1259287 |
On Fri, 30 Oct 2015, Krzysztof Kozlowski wrote:
> The commit 54e8827d5f0e ("mfd: sec-core: Add support for S2MPU02
> device") added new MFD child devices for S2MPU02: RTC and clock
> provider (the clock provider with new compatible). However support for
> these devices was not added to existing drivers (rtc-s5m, clk-s2mps11).
> New drivers were not submitted neither.
>
> This means that the name of children devices is completely unused. The
> "samsung,s2mpu02-clk" compatible remains undocumented so it is unclear
> what is provided by that compatible.
>
> Clean up this by removing unused child devices and undocumented
> compatible.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> I don't think that removing the "samsung,s2mpu02-clk" compatible would
> be considered as ABI break because:
> 1. Kernel did not document it as ABI.
> 2. Kernel did not provide any kind of feature for that compatible. It
> was totally ignored.
> ---
> drivers/mfd/sec-core.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> index 2626fc0b5b8c..989076d6cb83 100644
> --- a/drivers/mfd/sec-core.c
> +++ b/drivers/mfd/sec-core.c
> @@ -103,12 +103,9 @@ static const struct mfd_cell s2mpa01_devs[] = {
> };
>
> static const struct mfd_cell s2mpu02_devs[] = {
> - { .name = "s2mpu02-pmic", },
> - { .name = "s2mpu02-rtc", },
> {
> - .name = "s2mpu02-clk",
> - .of_compatible = "samsung,s2mpu02-clk",
> - }
> + .name = "s2mpu02-pmic",
> + },
> };
>
> #ifdef CONFIG_OF
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web