Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259287

[PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children

Show all headers | View raw

The commit 54e8827d5f0e ("mfd: sec-core: Add support for S2MPU02
device") added new MFD child devices for S2MPU02: RTC and clock
provider (the clock provider with new compatible). However support for
these devices was not added to existing drivers (rtc-s5m, clk-s2mps11).
New drivers were not submitted neither.

This means that the name of children devices is completely unused. The
"samsung,s2mpu02-clk" compatible remains undocumented so it is unclear
what is provided by that compatible.

Clean up this by removing unused child devices and undocumented
compatible.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---

I don't think that removing the "samsung,s2mpu02-clk" compatible would
be considered as ABI break because:
1. Kernel did not document it as ABI.
2. Kernel did not provide any kind of feature for that compatible. It
   was totally ignored.
---
 drivers/mfd/sec-core.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
index 2626fc0b5b8c..989076d6cb83 100644
--- a/drivers/mfd/sec-core.c
+++ b/drivers/mfd/sec-core.c
@@ -103,12 +103,9 @@ static const struct mfd_cell s2mpa01_devs[] = {
 };
 
 static const struct mfd_cell s2mpu02_devs[] = {
-	{ .name = "s2mpu02-pmic", },
-	{ .name = "s2mpu02-rtc", },
 	{
-		.name = "s2mpu02-clk",
-		.of_compatible = "samsung,s2mpu02-clk",
-	}
+		.name = "s2mpu02-pmic",
+	},
 };
 
 #ifdef CONFIG_OF
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk  children Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-30 09:00 +0100
  Re: [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk  children Chanwoo Choi <cw00.choi@samsung.com> - 2015-10-30 10:20 +0100
  Re: [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk  children Lee Jones <lee.jones@linaro.org> - 2015-10-30 10:40 +0100

csiph-web