Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1260001 > unrolled thread
| Started by | Bogicevic Sasa <brutallesale@gmail.com> |
|---|---|
| First post | 2015-10-31 15:10 +0100 |
| Last post | 2015-10-31 17:40 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters Bogicevic Sasa <brutallesale@gmail.com> - 2015-10-31 15:10 +0100
Re: [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters Joe Perches <joe@perches.com> - 2015-10-31 17:00 +0100
Re: [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters Bogicevic Sasa <brutallesale@gmail.com> - 2015-10-31 17:40 +0100
| From | Bogicevic Sasa <brutallesale@gmail.com> |
|---|---|
| Date | 2015-10-31 15:10 +0100 |
| Subject | [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters |
| Message-ID | <qpF10-3NX-19@gated-at.bofh.it> |
This fixes line over 80 characters message from checkpatch.pl Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com> --- drivers/staging/gdm72xx/gdm_qos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c index c03204b..0625a54 100644 --- a/drivers/staging/gdm72xx/gdm_qos.c +++ b/drivers/staging/gdm72xx/gdm_qos.c @@ -382,7 +382,8 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) spin_lock_irqsave(&qcb->qos_lock, flags); qcb->csr[index].sfid = sfid; - qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00); + qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & + 0xff00); qcb->csr[index].classifier_rule_en += buf[pos++]; if (qcb->csr[index].classifier_rule_en == 0) qcb->qos_null_idx = index; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2015-10-31 17:00 +0100 |
| Message-ID | <qpGJs-4ES-23@gated-at.bofh.it> |
| In reply to | #1260001 |
On Sat, 2015-10-31 at 15:00 +0100, Bogicevic Sasa wrote: > This fixes line over 80 characters message from checkpatch.pl [] > diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c [] > @@ -382,7 +382,8 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) > > spin_lock_irqsave(&qcb->qos_lock, flags); > qcb->csr[index].sfid = sfid; > - qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00); > + qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & > + 0xff00); Probably better to remove the unnecessary parentheses instead qcb->csr[index].classifier_rule_en = (buf[pos++] << 8) & 0xff00; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Bogicevic Sasa <brutallesale@gmail.com> |
|---|---|
| Date | 2015-10-31 17:40 +0100 |
| Message-ID | <qpHma-57i-7@gated-at.bofh.it> |
| In reply to | #1260016 |
On 10/31, Joe Perches wrote: >On Sat, 2015-10-31 at 15:00 +0100, Bogicevic Sasa wrote: >> This fixes line over 80 characters message from checkpatch.pl >[] >> diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c >[] >> @@ -382,7 +382,8 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) >> >> spin_lock_irqsave(&qcb->qos_lock, flags); >> qcb->csr[index].sfid = sfid; >> - qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00); >> + qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & >> + 0xff00); > >Probably better to remove the unnecessary parentheses instead > > qcb->csr[index].classifier_rule_en = (buf[pos++] << 8) & 0xff00; > > > You're right, I just sent a new patch. Thanks, Sasa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web