Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1260016

Re: [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters
Date 2015-10-31 17:00 +0100
Message-ID <qpGJs-4ES-23@gated-at.bofh.it> (permalink)
References <qpF10-3NX-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, 2015-10-31 at 15:00 +0100, Bogicevic Sasa wrote:
> This fixes line over 80 characters message from checkpatch.pl
[]
> diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c
[]
> @@ -382,7 +382,8 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size)
>  
>  		spin_lock_irqsave(&qcb->qos_lock, flags);
>  		qcb->csr[index].sfid = sfid;
> -		qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00);
> +		qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) &
> +							0xff00);

Probably better to remove the unnecessary parentheses instead

		qcb->csr[index].classifier_rule_en = (buf[pos++] << 8) & 0xff00;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters Bogicevic Sasa <brutallesale@gmail.com> - 2015-10-31 15:10 +0100
  Re: [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters Joe Perches <joe@perches.com> - 2015-10-31 17:00 +0100
    Re: [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters Bogicevic Sasa <brutallesale@gmail.com> - 2015-10-31 17:40 +0100

csiph-web