Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1255917 > unrolled thread

Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board Linus Walleij <linus.walleij@linaro.org> - 2015-10-26 14:50 +0100
    Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-10-27 21:40 +0100
      Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery  board Andreas Färber <afaerber@suse.de> - 2015-10-27 22:40 +0100
        Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board Linus Walleij <linus.walleij@linaro.org> - 2015-10-27 22:50 +0100
          Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery  board Andreas Färber <afaerber@suse.de> - 2015-10-27 23:00 +0100
            Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery  board Daniel Thompson <daniel.thompson@linaro.org> - 2015-10-28 09:10 +0100
              Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-10-28 15:30 +0100

#1255917 — Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board

On Sat, Oct 17, 2015 at 7:23 PM, Maxime Coquelin
<mcoquelin.stm32@gmail.com> wrote:

> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
(...)
> +       leds {
> +               compatible = "gpio-leds";
> +               red {
> +                       gpios = <&gpiog 14 0>;
> +               };
> +               green {
> +                       gpios = <&gpiog 13 0>;
> +               };

I suggest you add labels to these LEDs.

label = "red-LED"
label = "green-LED"

This make things so much easier in sysfs.

Usually people also want to add a default linux,trigger to these,
like linux,default-trigger = "heartbeat"; but whatever you prefer.

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1257181

2015-10-26 14:41 GMT+01:00 Linus Walleij <linus.walleij@linaro.org>:
> On Sat, Oct 17, 2015 at 7:23 PM, Maxime Coquelin
> <mcoquelin.stm32@gmail.com> wrote:
>
>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> (...)
>> +       leds {
>> +               compatible = "gpio-leds";
>> +               red {
>> +                       gpios = <&gpiog 14 0>;
>> +               };
>> +               green {
>> +                       gpios = <&gpiog 13 0>;
>> +               };
>
> I suggest you add labels to these LEDs.
>
> label = "red-LED"
> label = "green-LED"
>
> This make things so much easier in sysfs.

I'm not sure to understand where it makes things easier in sysfs.
This is the sysfs path for the red led:
/sys/class/leds/red/

Indeed, if label is not present, it gets the node name.

>
> Usually people also want to add a default linux,trigger to these,
> like linux,default-trigger = "heartbeat"; but whatever you prefer.

Makes sense, I will add default trigger in next version.

> Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thanks!
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257290 — Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board

Am 27.10.2015 um 21:31 schrieb Maxime Coquelin:
> 2015-10-26 14:41 GMT+01:00 Linus Walleij <linus.walleij@linaro.org>:
>> Usually people also want to add a default linux,trigger to these,
>> like linux,default-trigger = "heartbeat"; but whatever you prefer.
> 
> Makes sense, I will add default trigger in next version.

Previously, consensus seemed to be not to use heartbeat as default, but
rather off or on.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257331

On Tue, Oct 27, 2015 at 10:37 PM, Andreas Färber <afaerber@suse.de> wrote:
> Am 27.10.2015 um 21:31 schrieb Maxime Coquelin:
>> 2015-10-26 14:41 GMT+01:00 Linus Walleij <linus.walleij@linaro.org>:
>>> Usually people also want to add a default linux,trigger to these,
>>> like linux,default-trigger = "heartbeat"; but whatever you prefer.
>>
>> Makes sense, I will add default trigger in next version.
>
> Previously, consensus seemed to be not to use heartbeat as default, but
> rather off or on.

Which consensus, where, and for whom?

Heartbeat is awesome.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257357 — Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board

Am 27.10.2015 um 22:46 schrieb Linus Walleij:
> Heartbeat is awesome.

Yes, it's awesome for testing, but not for a .dts file that ends up in a
distro (not the case here, of course) and keeps blinking on the desk.

If someone wants LEDs to blink, they can set that via sysfs or by
modifying their .dts locally.

sunxi chose to keep LEDs off my default. For qcom we had a similar
discussion some weeks ago. I don't regularly read Linux patches, so feel
free to skim the archives yourself.

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257758 — Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board

On 27/10/15 21:52, Andreas Färber wrote:
> Am 27.10.2015 um 22:46 schrieb Linus Walleij:
>> Heartbeat is awesome.
>
> Yes, it's awesome for testing, but not for a .dts file that ends up in a
> distro (not the case here, of course) and keeps blinking on the desk.
>
> If someone wants LEDs to blink, they can set that via sysfs or by
> modifying their .dts locally.
>
> sunxi chose to keep LEDs off my default. For qcom we had a similar
> discussion some weeks ago. I don't regularly read Linux patches, so feel
> free to skim the archives yourself.

Among the existing DTS files there is pretty significant use of 
heartbeat although its not absolute.

There are 119 files that set a default-trigger, of these 91 (~75%) 
include a line to configure a heartbeat.

Personally I'd be very happy with heartbeat by default on STM32... I've 
seldom worked on a board without a default-enabled heartbeat so they 
make me feel comfortable. ;-)


Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1258153

2015-10-28 9:09 GMT+01:00 Daniel Thompson <daniel.thompson@linaro.org>:
> On 27/10/15 21:52, Andreas Färber wrote:
>>
>> Am 27.10.2015 um 22:46 schrieb Linus Walleij:
>>>
>>> Heartbeat is awesome.
>>
>>
>> Yes, it's awesome for testing, but not for a .dts file that ends up in a
>> distro (not the case here, of course) and keeps blinking on the desk.
>>
>> If someone wants LEDs to blink, they can set that via sysfs or by
>> modifying their .dts locally.
>>
>> sunxi chose to keep LEDs off my default. For qcom we had a similar
>> discussion some weeks ago. I don't regularly read Linux patches, so feel
>> free to skim the archives yourself.
>
>
> Among the existing DTS files there is pretty significant use of heartbeat
> although its not absolute.
>
> There are 119 files that set a default-trigger, of these 91 (~75%) include a
> line to configure a heartbeat.
>
> Personally I'd be very happy with heartbeat by default on STM32... I've
> seldom worked on a board without a default-enabled heartbeat so they make me
> feel comfortable. ;-)

I will add heartbeat in next version, which will arrive when the
pinctrl driver first review is done.

Thanks,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web