Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257758

Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board

Show all headers | View raw

On 27/10/15 21:52, Andreas Färber wrote:
> Am 27.10.2015 um 22:46 schrieb Linus Walleij:
>> Heartbeat is awesome.
>
> Yes, it's awesome for testing, but not for a .dts file that ends up in a
> distro (not the case here, of course) and keeps blinking on the desk.
>
> If someone wants LEDs to blink, they can set that via sysfs or by
> modifying their .dts locally.
>
> sunxi chose to keep LEDs off my default. For qcom we had a similar
> discussion some weeks ago. I don't regularly read Linux patches, so feel
> free to skim the archives yourself.

Among the existing DTS files there is pretty significant use of 
heartbeat although its not absolute.

There are 119 files that set a default-trigger, of these 91 (~75%) 
include a line to configure a heartbeat.

Personally I'd be very happy with heartbeat by default on STM32... I've 
seldom worked on a board without a default-enabled heartbeat so they 
make me feel comfortable. ;-)


Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board Linus Walleij <linus.walleij@linaro.org> - 2015-10-26 14:50 +0100
  Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-10-27 21:40 +0100
    Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery  board Andreas Färber <afaerber@suse.de> - 2015-10-27 22:40 +0100
      Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board Linus Walleij <linus.walleij@linaro.org> - 2015-10-27 22:50 +0100
        Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery  board Andreas Färber <afaerber@suse.de> - 2015-10-27 23:00 +0100
          Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery  board Daniel Thompson <daniel.thompson@linaro.org> - 2015-10-28 09:10 +0100
            Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-10-28 15:30 +0100

csiph-web