Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256724 > unrolled thread

Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] spi: Setup the master controller driver before setting  the chipselect "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-27 13:30 +0100
    Re: [PATCH v2] spi: Setup the master controller driver before setting  the chipselect Grygorii Strashko <grygorii.strashko@ti.com> - 2015-10-27 14:20 +0100
      Re: [PATCH v2] spi: Setup the master controller driver before setting  the chipselect Grygorii Strashko <grygorii.strashko@ti.com> - 2015-10-27 14:40 +0100
    Re: [PATCH v2] spi: Setup the master controller driver before  setting the chipselect Mark Brown <broonie@kernel.org> - 2015-10-28 01:40 +0100

#1256724 — Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect

On 10/16/2015 10:55 AM, Andy Shevchenko wrote:
> On Fri, Oct 16, 2015 at 6:47 PM, Franklin S Cooper Jr. <fcooper@ti.com> wrote:
>>
>> On 10/16/2015 10:45 AM, Andy Shevchenko wrote:
>>> On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr <fcooper@ti.com> wrote:
>>>> SPI controllers may need to be properly setup before chip selects
>>>> can be used. Therefore, wait until the spi controller has a chance
>>>> to perform their setup procedure before trying to use the chip
>>>> select.
>>>>
>>>> This also insures that the chip selects pins are in a good
>>>> state before asseting them which otherwise may cause confusion.
>>>>
>>>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>>> Does it mean I have to test it again?
>> Oops sorry. No the patch hasn't changed. I can shoot a v3 with your tested by included.
> Whatever Mark prefers.
Hi Mark,
I don't see that you pulled this patch into your topic/core branch just yet. Would you prefer
for me to shoot a v3 with Andy's tested by or will you just add it when your ready to
pull it in?

Without this patch several of our boards don't boot in linux-next so if there is anything you
need for me to do please let me know.
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1256747

On 10/27/2015 02:22 PM, Franklin S Cooper Jr. wrote:
>
>
> On 10/16/2015 10:55 AM, Andy Shevchenko wrote:
>> On Fri, Oct 16, 2015 at 6:47 PM, Franklin S Cooper Jr. <fcooper@ti.com> wrote:
>>>
>>> On 10/16/2015 10:45 AM, Andy Shevchenko wrote:
>>>> On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr <fcooper@ti.com> wrote:
>>>>> SPI controllers may need to be properly setup before chip selects
>>>>> can be used. Therefore, wait until the spi controller has a chance
>>>>> to perform their setup procedure before trying to use the chip
>>>>> select.
>>>>>
>>>>> This also insures that the chip selects pins are in a good
>>>>> state before asseting them which otherwise may cause confusion.
>>>>>
>>>>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>>>> Does it mean I have to test it again?
>>> Oops sorry. No the patch hasn't changed. I can shoot a v3 with your tested by included.
>> Whatever Mark prefers.
> Hi Mark,
> I don't see that you pulled this patch into your topic/core branch just yet. Would you prefer
> for me to shoot a v3 with Andy's tested by or will you just add it when your ready to
> pull it in?
>
> Without this patch several of our boards don't boot in linux-next so if there is anything you
> need for me to do please let me know.
>>
>>
>

Boot tested on K2HK:

Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>
Tested-by: Ivan Khoronzhuk <ivan.khoronzhuk@lonaro.org>

-- 
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1256753

On 10/27/2015 03:11 PM, Grygorii Strashko wrote:
> On 10/27/2015 02:22 PM, Franklin S Cooper Jr. wrote:
>>
>>
>> On 10/16/2015 10:55 AM, Andy Shevchenko wrote:
>>> On Fri, Oct 16, 2015 at 6:47 PM, Franklin S Cooper Jr.
>>> <fcooper@ti.com> wrote:
>>>>
>>>> On 10/16/2015 10:45 AM, Andy Shevchenko wrote:
>>>>> On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr
>>>>> <fcooper@ti.com> wrote:
>>>>>> SPI controllers may need to be properly setup before chip selects
>>>>>> can be used. Therefore, wait until the spi controller has a chance
>>>>>> to perform their setup procedure before trying to use the chip
>>>>>> select.
>>>>>>
>>>>>> This also insures that the chip selects pins are in a good
>>>>>> state before asseting them which otherwise may cause confusion.
>>>>>>
>>>>>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>>>>> Does it mean I have to test it again?
>>>> Oops sorry. No the patch hasn't changed. I can shoot a v3 with your
>>>> tested by included.
>>> Whatever Mark prefers.
>> Hi Mark,
>> I don't see that you pulled this patch into your topic/core branch
>> just yet. Would you prefer
>> for me to shoot a v3 with Andy's tested by or will you just add it
>> when your ready to
>> pull it in?
>>
>> Without this patch several of our boards don't boot in linux-next so
>> if there is anything you
>> need for me to do please let me know.
>>>
>>>
>>
>
> Boot tested on K2HK:
>
> Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Tested-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
>

Sry, Fix Ivan's e-mail
Tested-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>

-- 
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257515 — Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect

[Multipart message — attachments visible in raw view] — view raw

On Tue, Oct 27, 2015 at 07:22:51AM -0500, Franklin S Cooper Jr. wrote:

> I don't see that you pulled this patch into your topic/core branch just yet. Would you prefer
> for me to shoot a v3 with Andy's tested by or will you just add it when your ready to
> pull it in?

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

Please don't send content free pings.  If your patch has been lost then
you will need to resend it, if your patch is waiting to be handled then
at best your message is likely to be threaded in with the original
thread and therefore not seen.  Either way a content free ping just adds
to mail volume rather than helping.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web