Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect

From	"Franklin S Cooper Jr." <fcooper@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect
Date	2015-10-27 13:30 +0100
Message-ID	<qoby2-59v-3@gated-at.bofh.it> (permalink)
References	<qkf7c-1SN-27@gated-at.bofh.it> <qkfqx-2iA-9@gated-at.bofh.it> <qkfqy-2iA-29@gated-at.bofh.it> <qkfAf-2um-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 10/16/2015 10:55 AM, Andy Shevchenko wrote:
> On Fri, Oct 16, 2015 at 6:47 PM, Franklin S Cooper Jr. <fcooper@ti.com> wrote:
>>
>> On 10/16/2015 10:45 AM, Andy Shevchenko wrote:
>>> On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr <fcooper@ti.com> wrote:
>>>> SPI controllers may need to be properly setup before chip selects
>>>> can be used. Therefore, wait until the spi controller has a chance
>>>> to perform their setup procedure before trying to use the chip
>>>> select.
>>>>
>>>> This also insures that the chip selects pins are in a good
>>>> state before asseting them which otherwise may cause confusion.
>>>>
>>>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>>> Does it mean I have to test it again?
>> Oops sorry. No the patch hasn't changed. I can shoot a v3 with your tested by included.
> Whatever Mark prefers.
Hi Mark,
I don't see that you pulled this patch into your topic/core branch just yet. Would you prefer
for me to shoot a v3 with Andy's tested by or will you just add it when your ready to
pull it in?

Without this patch several of our boards don't boot in linux-next so if there is anything you
need for me to do please let me know.
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] spi: Setup the master controller driver before setting  the chipselect "Franklin S Cooper Jr." <fcooper@ti.com> - 2015-10-27 13:30 +0100
  Re: [PATCH v2] spi: Setup the master controller driver before setting  the chipselect Grygorii Strashko <grygorii.strashko@ti.com> - 2015-10-27 14:20 +0100
    Re: [PATCH v2] spi: Setup the master controller driver before setting  the chipselect Grygorii Strashko <grygorii.strashko@ti.com> - 2015-10-27 14:40 +0100
  Re: [PATCH v2] spi: Setup the master controller driver before  setting the chipselect Mark Brown <broonie@kernel.org> - 2015-10-28 01:40 +0100

csiph-web