Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1258648 > unrolled thread
| Started by | Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> |
|---|---|
| First post | 2015-10-29 09:30 +0100 |
| Last post | 2015-10-29 22:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCHv12 26/37] mm: rework mapcount accounting to enable 4k mapping of THPs Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2015-10-29 09:30 +0100
Re: [PATCHv12 26/37] mm: rework mapcount accounting to enable 4k mapping of THPs "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-10-29 22:30 +0100
| From | Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> |
|---|---|
| Date | 2015-10-29 09:30 +0100 |
| Subject | Re: [PATCHv12 26/37] mm: rework mapcount accounting to enable 4k mapping of THPs |
| Message-ID | <qoQKS-6cM-45@gated-at.bofh.it> |
On Tue, Oct 06, 2015 at 06:23:53PM +0300, Kirill A. Shutemov wrote: ... > diff --git a/mm/migrate.c b/mm/migrate.c > index 0268013cce63..45fadab47c53 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -165,7 +165,7 @@ static int remove_migration_pte(struct page *new, struct vm_area_struct *vma, > if (PageAnon(new)) > hugepage_add_anon_rmap(new, vma, addr); > else > - page_dup_rmap(new); > + page_dup_rmap(new, false); This is for hugetlb page, so the second argument should be true, right? Thanks, Naoya Horiguchi > } else if (PageAnon(new)) > page_add_anon_rmap(new, vma, addr, false); > else-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Kirill A. Shutemov" <kirill@shutemov.name> |
|---|---|
| Date | 2015-10-29 22:30 +0100 |
| Message-ID | <qp2VI-5uW-19@gated-at.bofh.it> |
| In reply to | #1258648 |
On Thu, Oct 29, 2015 at 08:19:25AM +0000, Naoya Horiguchi wrote: > On Tue, Oct 06, 2015 at 06:23:53PM +0300, Kirill A. Shutemov wrote: > ... > > diff --git a/mm/migrate.c b/mm/migrate.c > > index 0268013cce63..45fadab47c53 100644 > > --- a/mm/migrate.c > > +++ b/mm/migrate.c > > @@ -165,7 +165,7 @@ static int remove_migration_pte(struct page *new, struct vm_area_struct *vma, > > if (PageAnon(new)) > > hugepage_add_anon_rmap(new, vma, addr); > > else > > - page_dup_rmap(new); > > + page_dup_rmap(new, false); > > This is for hugetlb page, so the second argument should be true, right? You are right. Fixup: index 1ae0113559c9..b1034f9c77e7 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -165,7 +165,7 @@ static int remove_migration_pte(struct page *new, struct vm_area_struct *vma, if (PageAnon(new)) hugepage_add_anon_rmap(new, vma, addr); else - page_dup_rmap(new, false); + page_dup_rmap(new, true); } else if (PageAnon(new)) page_add_anon_rmap(new, vma, addr, false); else -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web