Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259015

Re: [PATCHv12 26/37] mm: rework mapcount accounting to enable 4k mapping of THPs

Show all headers | View raw

On Thu, Oct 29, 2015 at 08:19:25AM +0000, Naoya Horiguchi wrote:
> On Tue, Oct 06, 2015 at 06:23:53PM +0300, Kirill A. Shutemov wrote:
> ...
> > diff --git a/mm/migrate.c b/mm/migrate.c
> > index 0268013cce63..45fadab47c53 100644
> > --- a/mm/migrate.c
> > +++ b/mm/migrate.c
> > @@ -165,7 +165,7 @@ static int remove_migration_pte(struct page *new, struct vm_area_struct *vma,
> >  		if (PageAnon(new))
> >  			hugepage_add_anon_rmap(new, vma, addr);
> >  		else
> > -			page_dup_rmap(new);
> > +			page_dup_rmap(new, false);
> 
> This is for hugetlb page, so the second argument should be true, right?

You are right. Fixup:

index 1ae0113559c9..b1034f9c77e7 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -165,7 +165,7 @@ static int remove_migration_pte(struct page *new, struct vm_area_struct *vma,
 		if (PageAnon(new))
 			hugepage_add_anon_rmap(new, vma, addr);
 		else
-			page_dup_rmap(new, false);
+			page_dup_rmap(new, true);
 	} else if (PageAnon(new))
 		page_add_anon_rmap(new, vma, addr, false);
 	else
-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCHv12 26/37] mm: rework mapcount accounting to enable 4k  mapping of THPs Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2015-10-29 09:30 +0100
  Re: [PATCHv12 26/37] mm: rework mapcount accounting to enable 4k  mapping of THPs "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-10-29 22:30 +0100

csiph-web