Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1258289 > unrolled thread

tools/build: fixdep versus tools/lib/bpf

Started byArnaldo Carvalho de Melo <acme@kernel.org>
First post2015-10-28 17:40 +0100
Last post2015-10-30 10:20 +0100
Articles 7 — 4 participants

Back to article view | Back to linux.kernel

Contents

  tools/build: fixdep versus tools/lib/bpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 17:40 +0100
    Re: tools/build: fixdep versus tools/lib/bpf Jiri Olsa <jolsa@redhat.com> - 2015-10-28 21:20 +0100
      Re: tools/build: fixdep versus tools/lib/bpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 21:40 +0100
        Re: tools/build: fixdep versus tools/lib/bpf Jiri Olsa <jolsa@redhat.com> - 2015-10-28 21:50 +0100
          Re: tools/build: fixdep versus tools/lib/bpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 22:10 +0100
            Re: tools/build: fixdep versus tools/lib/bpf "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-29 03:40 +0100
          [tip:perf/core] perf tools:   Make sure fixdep is built before libbpf tip-bot for Jiri Olsa <tipbot@zytor.com> - 2015-10-30 10:20 +0100

#1258289 — tools/build: fixdep versus tools/lib/bpf

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2015-10-28 17:40 +0100
Subjecttools/build: fixdep versus tools/lib/bpf
Message-ID<qoBVv-51M-1@gated-at.bofh.it>
Hi Jiri, Wang,

	I'm getting these while doing 'make -C tools/perf build-test':

  LD       fixdep-in.o
  LINK     fixdep
/bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied
make[6]: *** [bpf.o] Error 1
make[5]: *** [libbpf-in.o] Error 2
make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2
make[4]: *** Waiting for unfinished jobs....


It happens at different tests, i.e. seems like a race somewhere in the
build system, can you take a look? It happens with my perf/ebpf branch.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1258398

FromJiri Olsa <jolsa@redhat.com>
Date2015-10-28 21:20 +0100
Message-ID<qoFmq-7nd-3@gated-at.bofh.it>
In reply to#1258289
On Wed, Oct 28, 2015 at 01:30:40PM -0300, Arnaldo Carvalho de Melo wrote:
> Hi Jiri, Wang,
> 
> 	I'm getting these while doing 'make -C tools/perf build-test':
> 
>   LD       fixdep-in.o
>   LINK     fixdep
> /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied
> make[6]: *** [bpf.o] Error 1
> make[5]: *** [libbpf-in.o] Error 2
> make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2
> make[4]: *** Waiting for unfinished jobs....
> 
> 
> It happens at different tests, i.e. seems like a race somewhere in the
> build system, can you take a look? It happens with my perf/ebpf branch.

could not reproduce, but looks like attached patch should help

jirka


---
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 1e2e2d1d26b7..0d19d5447d6c 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -430,7 +430,7 @@ $(LIBAPI)-clean:
 	$(call QUIET_CLEAN, libapi)
 	$(Q)$(MAKE) -C $(LIB_DIR) O=$(OUTPUT) clean >/dev/null
 
-$(LIBBPF): FORCE
+$(LIBBPF): fixdep FORCE
 	$(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a
 
 $(LIBBPF)-clean:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1258408

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2015-10-28 21:40 +0100
Message-ID<qoFFN-7u4-25@gated-at.bofh.it>
In reply to#1258398
Em Wed, Oct 28, 2015 at 09:13:52PM +0100, Jiri Olsa escreveu:
> On Wed, Oct 28, 2015 at 01:30:40PM -0300, Arnaldo Carvalho de Melo wrote:
> > Hi Jiri, Wang,
> > 
> > 	I'm getting these while doing 'make -C tools/perf build-test':
> > 
> >   LD       fixdep-in.o
> >   LINK     fixdep
> > /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied
> > make[6]: *** [bpf.o] Error 1
> > make[5]: *** [libbpf-in.o] Error 2
> > make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2
> > make[4]: *** Waiting for unfinished jobs....
> > 
> > 
> > It happens at different tests, i.e. seems like a race somewhere in the
> > build system, can you take a look? It happens with my perf/ebpf branch.
> 
> could not reproduce, but looks like attached patch should help

I'll test this now, i.e. make it go thru a 'make -C tools/perf
build-test'.

In the interest of speeding up things, please provide an explanation of
why this should be applied, so that I can add it to the changeset log.

Thanks a bunch!

- Arnaldo
 
> jirka
> 
> 
> ---
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 1e2e2d1d26b7..0d19d5447d6c 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -430,7 +430,7 @@ $(LIBAPI)-clean:
>  	$(call QUIET_CLEAN, libapi)
>  	$(Q)$(MAKE) -C $(LIB_DIR) O=$(OUTPUT) clean >/dev/null
>  
> -$(LIBBPF): FORCE
> +$(LIBBPF): fixdep FORCE
>  	$(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a
>  
>  $(LIBBPF)-clean:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1258412

FromJiri Olsa <jolsa@redhat.com>
Date2015-10-28 21:50 +0100
Message-ID<qoFPs-7xx-9@gated-at.bofh.it>
In reply to#1258408
On Wed, Oct 28, 2015 at 05:37:52PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 28, 2015 at 09:13:52PM +0100, Jiri Olsa escreveu:
> > On Wed, Oct 28, 2015 at 01:30:40PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Hi Jiri, Wang,
> > > 
> > > 	I'm getting these while doing 'make -C tools/perf build-test':
> > > 
> > >   LD       fixdep-in.o
> > >   LINK     fixdep
> > > /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied
> > > make[6]: *** [bpf.o] Error 1
> > > make[5]: *** [libbpf-in.o] Error 2
> > > make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2
> > > make[4]: *** Waiting for unfinished jobs....
> > > 
> > > 
> > > It happens at different tests, i.e. seems like a race somewhere in the
> > > build system, can you take a look? It happens with my perf/ebpf branch.
> > 
> > could not reproduce, but looks like attached patch should help
> 
> I'll test this now, i.e. make it go thru a 'make -C tools/perf
> build-test'.
> 
> In the interest of speeding up things, please provide an explanation of
> why this should be applied, so that I can add it to the changeset log.
> 
> Thanks a bunch!
> 

The fixdep tool needs to be built as the first binary.
Libraries are built in paralel, so each of them needs
to depend on fixdep target.

jirka

> > jirka
> > 
> > 
> > ---
> > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> > index 1e2e2d1d26b7..0d19d5447d6c 100644
> > --- a/tools/perf/Makefile.perf
> > +++ b/tools/perf/Makefile.perf
> > @@ -430,7 +430,7 @@ $(LIBAPI)-clean:
> >  	$(call QUIET_CLEAN, libapi)
> >  	$(Q)$(MAKE) -C $(LIB_DIR) O=$(OUTPUT) clean >/dev/null
> >  
> > -$(LIBBPF): FORCE
> > +$(LIBBPF): fixdep FORCE
> >  	$(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a
> >  
> >  $(LIBBPF)-clean:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1258426

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2015-10-28 22:10 +0100
Message-ID<qoG8O-7Um-19@gated-at.bofh.it>
In reply to#1258412
Em Wed, Oct 28, 2015 at 09:44:50PM +0100, Jiri Olsa escreveu:
> On Wed, Oct 28, 2015 at 05:37:52PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Oct 28, 2015 at 09:13:52PM +0100, Jiri Olsa escreveu:
> > > On Wed, Oct 28, 2015 at 01:30:40PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > Hi Jiri, Wang,
> > > > 
> > > > 	I'm getting these while doing 'make -C tools/perf build-test':
> > > > 
> > > >   LD       fixdep-in.o
> > > >   LINK     fixdep
> > > > /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied
> > > > make[6]: *** [bpf.o] Error 1
> > > > make[5]: *** [libbpf-in.o] Error 2
> > > > make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2
> > > > make[4]: *** Waiting for unfinished jobs....
> > > > 
> > > > 
> > > > It happens at different tests, i.e. seems like a race somewhere in the
> > > > build system, can you take a look? It happens with my perf/ebpf branch.
> > > 
> > > could not reproduce, but looks like attached patch should help
> > 
> > I'll test this now, i.e. make it go thru a 'make -C tools/perf
> > build-test'.
> > 
> > In the interest of speeding up things, please provide an explanation of
> > why this should be applied, so that I can add it to the changeset log.
> > 
> > Thanks a bunch!
> > 
> 
> The fixdep tool needs to be built as the first binary.
> Libraries are built in paralel, so each of them needs
> to depend on fixdep target.


I really need a faster machine, you provided the answer at this point:

- make_tags_O: cd . && make -f Makefile O=/tmp/tmp.xfRz6THR6o
  DESTDIR=/tmp/tmp.y0nuN0Fr9n tags
- make_cscope_O: cd . && make -f Makefile O=/tmp/tmp.O6phQXHU4z
  DESTDIR=/tmp/tmp.5mdMeF1pH2 cscope
- tarpkg: ./tests/perf-targz-src-pkg .
- make -C <kernelsrc> tools/perf
- make -C <kernelsrc>/tools perf

Almost there :-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1258537

From"Wangnan (F)" <wangnan0@huawei.com>
Date2015-10-29 03:40 +0100
Message-ID<qoLi9-2Ei-1@gated-at.bofh.it>
In reply to#1258426

On 2015/10/29 5:01, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 28, 2015 at 09:44:50PM +0100, Jiri Olsa escreveu:
>> On Wed, Oct 28, 2015 at 05:37:52PM -0300, Arnaldo Carvalho de Melo wrote:
>>> Em Wed, Oct 28, 2015 at 09:13:52PM +0100, Jiri Olsa escreveu:
>>>> On Wed, Oct 28, 2015 at 01:30:40PM -0300, Arnaldo Carvalho de Melo wrote:
>>>>> Hi Jiri, Wang,
>>>>>
>>>>> 	I'm getting these while doing 'make -C tools/perf build-test':
>>>>>
>>>>>    LD       fixdep-in.o
>>>>>    LINK     fixdep
>>>>> /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied
>>>>> make[6]: *** [bpf.o] Error 1
>>>>> make[5]: *** [libbpf-in.o] Error 2
>>>>> make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2
>>>>> make[4]: *** Waiting for unfinished jobs....
>>>>>
>>>>>
>>>>> It happens at different tests, i.e. seems like a race somewhere in the
>>>>> build system, can you take a look? It happens with my perf/ebpf branch.

Never see this message before. Tried make build-test, unable to reproduce
in my environment. Maybe my machine is not fast enough?

>>>> could not reproduce, but looks like attached patch should help
>>> I'll test this now, i.e. make it go thru a 'make -C tools/perf
>>> build-test'.
>>>
>>> In the interest of speeding up things, please provide an explanation of
>>> why this should be applied, so that I can add it to the changeset log.
>>>
>>> Thanks a bunch!
>>>
>> The fixdep tool needs to be built as the first binary.
>> Libraries are built in paralel, so each of them needs
>> to depend on fixdep target.
>
> I really need a faster machine, you provided the answer at this point:
>
> - make_tags_O: cd . && make -f Makefile O=/tmp/tmp.xfRz6THR6o
>    DESTDIR=/tmp/tmp.y0nuN0Fr9n tags
> - make_cscope_O: cd . && make -f Makefile O=/tmp/tmp.O6phQXHU4z
>    DESTDIR=/tmp/tmp.5mdMeF1pH2 cscope
> - tarpkg: ./tests/perf-targz-src-pkg .
> - make -C <kernelsrc> tools/perf
> - make -C <kernelsrc>/tools perf
>
> Almost there :-)

So the problem is gone? Thanks to Jiri, and I'll add this to my local tree,
as a separated patch first.

Thank you.

> - Arnaldo


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1259347 — [tip:perf/core] perf tools: Make sure fixdep is built before libbpf

Fromtip-bot for Jiri Olsa <tipbot@zytor.com>
Date2015-10-30 10:20 +0100
Subject[tip:perf/core] perf tools: Make sure fixdep is built before libbpf
Message-ID<qpe0P-3Z0-29@gated-at.bofh.it>
In reply to#1258412
Commit-ID:  50f1e6d0431d3343cb506037c43ce623bd15581f
Gitweb:     http://git.kernel.org/tip/50f1e6d0431d3343cb506037c43ce623bd15581f
Author:     Jiri Olsa <jolsa@redhat.com>
AuthorDate: Wed, 28 Oct 2015 21:44:50 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 29 Oct 2015 17:16:21 -0300

perf tools: Make sure fixdep is built before libbpf

While doing 'make -C tools/perf build-test':

   LD       fixdep-in.o
   LINK     fixdep
 /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied
 make[6]: *** [bpf.o] Error 1
 make[5]: *** [libbpf-in.o] Error 2
 make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2
 make[4]: *** Waiting for unfinished jobs....

The fixdep tool needs to be built as the first binary.  Libraries are
built in paralel, so each of them needs to depend on fixdep target.

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20151028204450.GA25553@krava.redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 1e2e2d1..0d19d54 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -430,7 +430,7 @@ $(LIBAPI)-clean:
 	$(call QUIET_CLEAN, libapi)
 	$(Q)$(MAKE) -C $(LIB_DIR) O=$(OUTPUT) clean >/dev/null
 
-$(LIBBPF): FORCE
+$(LIBBPF): fixdep FORCE
 	$(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a
 
 $(LIBBPF)-clean:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web