Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1259347

[tip:perf/core] perf tools: Make sure fixdep is built before libbpf

From tip-bot for Jiri Olsa <tipbot@zytor.com>
Newsgroups linux.kernel
Subject [tip:perf/core] perf tools: Make sure fixdep is built before libbpf
Date 2015-10-30 10:20 +0100
Message-ID <qpe0P-3Z0-29@gated-at.bofh.it> (permalink)
References <qoFPs-7xx-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Commit-ID:  50f1e6d0431d3343cb506037c43ce623bd15581f
Gitweb:     http://git.kernel.org/tip/50f1e6d0431d3343cb506037c43ce623bd15581f
Author:     Jiri Olsa <jolsa@redhat.com>
AuthorDate: Wed, 28 Oct 2015 21:44:50 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 29 Oct 2015 17:16:21 -0300

perf tools: Make sure fixdep is built before libbpf

While doing 'make -C tools/perf build-test':

   LD       fixdep-in.o
   LINK     fixdep
 /bin/sh: /home/acme/git/linux/tools/build/fixdep: Permission denied
 make[6]: *** [bpf.o] Error 1
 make[5]: *** [libbpf-in.o] Error 2
 make[4]: *** [/home/acme/git/linux/tools/lib/bpf/libbpf.a] Error 2
 make[4]: *** Waiting for unfinished jobs....

The fixdep tool needs to be built as the first binary.  Libraries are
built in paralel, so each of them needs to depend on fixdep target.

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20151028204450.GA25553@krava.redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 1e2e2d1..0d19d54 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -430,7 +430,7 @@ $(LIBAPI)-clean:
 	$(call QUIET_CLEAN, libapi)
 	$(Q)$(MAKE) -C $(LIB_DIR) O=$(OUTPUT) clean >/dev/null
 
-$(LIBBPF): FORCE
+$(LIBBPF): fixdep FORCE
 	$(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a
 
 $(LIBBPF)-clean:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

tools/build: fixdep versus tools/lib/bpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 17:40 +0100
  Re: tools/build: fixdep versus tools/lib/bpf Jiri Olsa <jolsa@redhat.com> - 2015-10-28 21:20 +0100
    Re: tools/build: fixdep versus tools/lib/bpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 21:40 +0100
      Re: tools/build: fixdep versus tools/lib/bpf Jiri Olsa <jolsa@redhat.com> - 2015-10-28 21:50 +0100
        Re: tools/build: fixdep versus tools/lib/bpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 22:10 +0100
          Re: tools/build: fixdep versus tools/lib/bpf "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-29 03:40 +0100
        [tip:perf/core] perf tools:   Make sure fixdep is built before libbpf tip-bot for Jiri Olsa <tipbot@zytor.com> - 2015-10-30 10:20 +0100

csiph-web