Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1256417 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2015-10-27 03:30 +0100 |
| Last post | 2015-10-31 03:10 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-27 03:30 +0100
Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default Linus Walleij <linus.walleij@linaro.org> - 2015-10-29 14:40 +0100
Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-30 03:10 +0100
Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default Olof Johansson <olof@lixom.net> - 2015-10-31 03:10 +0100
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2015-10-27 03:30 +0100 |
| Subject | [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default |
| Message-ID | <qo2bo-7KG-23@gated-at.bofh.it> |
Add "default y" to the Kconfig rather than adding entries into arch/arm/configs/multi_v7_defconfig. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/pinctrl/uniphier/Kconfig | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/pinctrl/uniphier/Kconfig b/drivers/pinctrl/uniphier/Kconfig index eab23ef..b1d2f941 100644 --- a/drivers/pinctrl/uniphier/Kconfig +++ b/drivers/pinctrl/uniphier/Kconfig @@ -7,26 +7,32 @@ config PINCTRL_UNIPHIER_CORE config PINCTRL_UNIPHIER_PH1_LD4 tristate "UniPhier PH1-LD4 SoC pinctrl driver" + default y select PINCTRL_UNIPHIER_CORE config PINCTRL_UNIPHIER_PH1_PRO4 tristate "UniPhier PH1-Pro4 SoC pinctrl driver" + default y select PINCTRL_UNIPHIER_CORE config PINCTRL_UNIPHIER_PH1_SLD8 tristate "UniPhier PH1-sLD8 SoC pinctrl driver" + default y select PINCTRL_UNIPHIER_CORE config PINCTRL_UNIPHIER_PH1_PRO5 tristate "UniPhier PH1-Pro5 SoC pinctrl driver" + default y select PINCTRL_UNIPHIER_CORE config PINCTRL_UNIPHIER_PROXSTREAM2 tristate "UniPhier ProXstream2 SoC pinctrl driver" + default y select PINCTRL_UNIPHIER_CORE config PINCTRL_UNIPHIER_PH1_LD6B tristate "UniPhier PH1-LD6b SoC pinctrl driver" + default y select PINCTRL_UNIPHIER_CORE endif -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2015-10-29 14:40 +0100 |
| Subject | Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default |
| Message-ID | <qoVAR-KM-1@gated-at.bofh.it> |
| In reply to | #1256417 |
On Tue, Oct 27, 2015 at 3:28 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > Add "default y" to the Kconfig rather than adding entries into > arch/arm/configs/multi_v7_defconfig. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> (...) > config PINCTRL_UNIPHIER_PH1_LD4 > tristate "UniPhier PH1-LD4 SoC pinctrl driver" > + default y > select PINCTRL_UNIPHIER_CORE Why is it not default y if <PH1_LD4_SOC_THING>? So it is only turned on if the corresponding SoC is selected? Or don't you have symbols like that? ARM SoC folks: can you ACK this patch indicating that this is the way you wanna handle this? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2015-10-30 03:10 +0100 |
| Subject | Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default |
| Message-ID | <qp7iF-8fD-3@gated-at.bofh.it> |
| In reply to | #1258789 |
Hi Linus, 2015-10-29 22:33 GMT+09:00 Linus Walleij <linus.walleij@linaro.org>: > On Tue, Oct 27, 2015 at 3:28 AM, Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: > >> Add "default y" to the Kconfig rather than adding entries into >> arch/arm/configs/multi_v7_defconfig. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > (...) >> config PINCTRL_UNIPHIER_PH1_LD4 >> tristate "UniPhier PH1-LD4 SoC pinctrl driver" >> + default y >> select PINCTRL_UNIPHIER_CORE > > Why is it not default y if <PH1_LD4_SOC_THING>? > > So it is only turned on if the corresponding SoC is selected? > > Or don't you have symbols like that? No, I don't have such per-SoC symbols. I only have ARCH_UNIPHIER, for the whole UniPhier SoC family. We no longer #ifdef <SOC_THING> in C sources. The only difference among SoCs is, which drivers should be enabled. All SoCs in UniPhier family share the multi-platform kernel image, so I think, this way is reasonable enough. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Olof Johansson <olof@lixom.net> |
|---|---|
| Date | 2015-10-31 03:10 +0100 |
| Subject | Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default |
| Message-ID | <qptMe-5iJ-11@gated-at.bofh.it> |
| In reply to | #1258789 |
On Thu, Oct 29, 2015 at 02:33:34PM +0100, Linus Walleij wrote: > On Tue, Oct 27, 2015 at 3:28 AM, Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: > > > Add "default y" to the Kconfig rather than adding entries into > > arch/arm/configs/multi_v7_defconfig. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > (...) > > config PINCTRL_UNIPHIER_PH1_LD4 > > tristate "UniPhier PH1-LD4 SoC pinctrl driver" > > + default y > > select PINCTRL_UNIPHIER_CORE > > Why is it not default y if <PH1_LD4_SOC_THING>? > > So it is only turned on if the corresponding SoC is selected? > > Or don't you have symbols like that? > > ARM SoC folks: can you ACK this patch indicating that this is the way > you wanna handle this? Most other will have a "default MACH_<foo>", but Uniphier lacks those Kconfig symbols. Or even a def_bool for that platform such that it's not an option if the platform is enabled. It makes no sense to enable a platform but not the pinctrl on it, so that's a good way to do it. I would honestly rather have those in the mach makefile, and make the drivers select the right thing by default, than having to know exactly which drivers to enable for a specific SoC. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web