Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259902

Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default

Show all headers | View raw

On Thu, Oct 29, 2015 at 02:33:34PM +0100, Linus Walleij wrote:
> On Tue, Oct 27, 2015 at 3:28 AM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> 
> > Add "default y" to the Kconfig rather than adding entries into
> > arch/arm/configs/multi_v7_defconfig.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> 
> (...)
> > config PINCTRL_UNIPHIER_PH1_LD4
> >         tristate "UniPhier PH1-LD4 SoC pinctrl driver"
> > +       default y
> >         select PINCTRL_UNIPHIER_CORE
> 
> Why is it not default y if <PH1_LD4_SOC_THING>?
> 
> So it is only turned on if the corresponding SoC is selected?
> 
> Or don't you have symbols like that?
> 
> ARM SoC folks: can you ACK this patch indicating that this is the way
> you wanna handle this?

Most other will have a "default MACH_<foo>", but Uniphier lacks those Kconfig
symbols. Or even a def_bool for that platform such that it's not an option if
the platform is enabled. It makes no sense to enable a platform but not the
pinctrl on it, so that's a good way to do it.

I would honestly rather have those in the mach makefile, and make the drivers
select the right thing by default, than having to know exactly which drivers to
enable for a specific SoC.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-27 03:30 +0100
  Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl  drivers by default Linus Walleij <linus.walleij@linaro.org> - 2015-10-29 14:40 +0100
    Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl  drivers by default Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-30 03:10 +0100
    Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl  drivers by default Olof Johansson <olof@lixom.net> - 2015-10-31 03:10 +0100
      Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl  drivers by default Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-02 12:50 +0100

csiph-web