Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1255702 > unrolled thread
| Started by | Jiri Kosina <jikos@kernel.org> |
|---|---|
| First post | 2015-10-26 08:00 +0100 |
| Last post | 2015-10-26 15:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread Jiri Kosina <jikos@kernel.org> - 2015-10-26 08:00 +0100
Re: [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread Brian Foster <bfoster@redhat.com> - 2015-10-26 15:10 +0100
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2015-10-26 08:00 +0100 |
| Subject | [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread |
| Message-ID | <qnJV7-4WM-7@gated-at.bofh.it> |
From: Jiri Kosina <jkosina@suse.cz>
Since xfsaild has been converted to kthread in 0030807c, it calls
try_to_freeze() during every AIL push iteration. It however doesn't set
itself as freezable, and therefore this try_to_freeze() will never do
anything.
Before (hopefully eventually) kthread freezing gets converted to fileystem
freezing, we'd rather mark xfsaild freezable (as it can generate I/O
during suspend).
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
fs/xfs/xfs_trans_ail.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
index 1098cf4..06d1a29 100644
--- a/fs/xfs/xfs_trans_ail.c
+++ b/fs/xfs/xfs_trans_ail.c
@@ -497,6 +497,7 @@ xfsaild(
long tout = 0; /* milliseconds */
current->flags |= PF_MEMALLOC;
+ set_freezable();
while (!kthread_should_stop()) {
if (tout && tout <= 20)
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Brian Foster <bfoster@redhat.com> |
|---|---|
| Date | 2015-10-26 15:10 +0100 |
| Message-ID | <qnQDf-Nh-5@gated-at.bofh.it> |
| In reply to | #1255702 |
On Mon, Oct 26, 2015 at 03:53:40PM +0900, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> Since xfsaild has been converted to kthread in 0030807c, it calls
> try_to_freeze() during every AIL push iteration. It however doesn't set
> itself as freezable, and therefore this try_to_freeze() will never do
> anything.
>
> Before (hopefully eventually) kthread freezing gets converted to fileystem
> freezing, we'd rather mark xfsaild freezable (as it can generate I/O
> during suspend).
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---
Looks fine to me:
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_trans_ail.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
> index 1098cf4..06d1a29 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -497,6 +497,7 @@ xfsaild(
> long tout = 0; /* milliseconds */
>
> current->flags |= PF_MEMALLOC;
> + set_freezable();
>
> while (!kthread_should_stop()) {
> if (tout && tout <= 20)
> --
> Jiri Kosina
> SUSE Labs
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web