[PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread
Date	2015-10-26 08:00 +0100
Message-ID	<qnJV7-4WM-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Jiri Kosina <jkosina@suse.cz>

Since xfsaild has been converted to kthread in 0030807c, it calls 
try_to_freeze() during every AIL push iteration. It however doesn't set 
itself as freezable, and therefore this try_to_freeze() will never do 
anything.

Before (hopefully eventually) kthread freezing gets converted to fileystem 
freezing, we'd rather mark xfsaild freezable (as it can generate I/O 
during suspend).

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 fs/xfs/xfs_trans_ail.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
index 1098cf4..06d1a29 100644
--- a/fs/xfs/xfs_trans_ail.c
+++ b/fs/xfs/xfs_trans_ail.c
@@ -497,6 +497,7 @@ xfsaild(
 	long		tout = 0;	/* milliseconds */
 
 	current->flags |= PF_MEMALLOC;
+	set_freezable();
 
 	while (!kthread_should_stop()) {
 		if (tout && tout <= 20)
-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread Jiri Kosina <jikos@kernel.org> - 2015-10-26 08:00 +0100
  Re: [PATCH] xfs: clear PF_NOFREEZE for xfsaild kthread Brian Foster <bfoster@redhat.com> - 2015-10-26 15:10 +0100

csiph-web