Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1255221 > unrolled thread
| Started by | Michele Baldessari <michele@acksyn.org> |
|---|---|
| First post | 2015-10-24 18:00 +0200 |
| Last post | 2015-10-25 17:40 +0100 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Michele Baldessari <michele@acksyn.org> - 2015-10-24 18:00 +0200
Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Jiri Kosina <jikos@kernel.org> - 2015-10-24 22:20 +0200
Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Olivier Scherler <oscherler@ithink.ch> - 2015-10-26 12:10 +0100
Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Michele Baldessari <michele@acksyn.org> - 2015-10-26 13:10 +0100
Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Lars Melin <larsm17@gmail.com> - 2015-10-25 10:20 +0100
Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Michele Baldessari <michele@acksyn.org> - 2015-10-25 17:40 +0100
| From | Michele Baldessari <michele@acksyn.org> |
|---|---|
| Date | 2015-10-24 18:00 +0200 |
| Subject | [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade |
| Message-ID | <qn9oC-4Li-9@gated-at.bofh.it> |
The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order
to have the two distinct joysticks working.
Before the change:
$ jstest /dev/input/js0
Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
...
$ jstest /dev/input/js1
jstest: No such file or directory
After the change:
$ jstest /dev/input/js0
Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
...
$ jstest /dev/input/js1
Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
...
Signed-off-by: Michele Baldessari <michele@acksyn.org>
---
drivers/hid/usbhid/hid-quirks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 1dff8f0015ba..f69049314a2c 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -150,6 +150,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_MULTIPLE_1781, USB_DEVICE_ID_RAPHNET_4NES4SNES_OLD, HID_QUIRK_MULTI_INPUT },
{ USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_2NES2SNES, HID_QUIRK_MULTI_INPUT },
{ USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_4NES4SNES, HID_QUIRK_MULTI_INPUT },
+ { USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
{ 0, 0 }
};
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2015-10-24 22:20 +0200 |
| Message-ID | <qndsd-2pe-1@gated-at.bofh.it> |
| In reply to | #1255221 |
On Sat, 24 Oct 2015, Michele Baldessari wrote:
> The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order
> to have the two distinct joysticks working.
>
> Before the change:
> $ jstest /dev/input/js0
> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> ...
> $ jstest /dev/input/js1
> jstest: No such file or directory
>
> After the change:
> $ jstest /dev/input/js0
> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> ...
> $ jstest /dev/input/js1
> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> ...
>
> Signed-off-by: Michele Baldessari <michele@acksyn.org>
Adding Oliver to CC.
Oliver, how come that you didn't need this while working on the inigial
Xin-Mo Dual Arcade support?
Thanks.
> ---
> drivers/hid/usbhid/hid-quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 1dff8f0015ba..f69049314a2c 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -150,6 +150,7 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_MULTIPLE_1781, USB_DEVICE_ID_RAPHNET_4NES4SNES_OLD, HID_QUIRK_MULTI_INPUT },
> { USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_2NES2SNES, HID_QUIRK_MULTI_INPUT },
> { USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_4NES4SNES, HID_QUIRK_MULTI_INPUT },
> + { USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
>
> { 0, 0 }
> };
> --
> 2.5.0
>
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Olivier Scherler <oscherler@ithink.ch> |
|---|---|
| Date | 2015-10-26 12:10 +0100 |
| Message-ID | <qnNP4-7uf-19@gated-at.bofh.it> |
| In reply to | #1255245 |
Hi, > On 24 oct. 2015, at 22:11, Jiri Kosina <jikos@kernel.org> wrote: > > On Sat, 24 Oct 2015, Michele Baldessari wrote: > >> The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order >> to have the two distinct joysticks working. >> >> Before the change: >> $ jstest /dev/input/js0 >> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y) >> ... >> $ jstest /dev/input/js1 >> jstest: No such file or directory >> >> After the change: >> $ jstest /dev/input/js0 >> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y) >> ... >> $ jstest /dev/input/js1 >> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y) >> ... >> >> Signed-off-by: Michele Baldessari <michele@acksyn.org> > > Adding Oliver to CC. > > Oliver, how come that you didn't need this while working on the inigial > Xin-Mo Dual Arcade support? Because I didn’t mind whether the controller announced itself as two joysticks with two axes each, or one joystick with four axes. In the software I use it for (a MAME for the Raspberry Pi), I can map a single device’s buttons and axes to several players. I’m a bit surprised with this, though: > $ jstest /dev/input/js0 > Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y) because in my case I had four axes, at least using evtest (I don’t remember if I tried jstest as well). What bothered me at the time, though, is that even though the custom driver was made as a kernel module, an entry had to be added in the hid_have_special_driver table in hid-core.c for the kernel to use it, which means, if I understand properly, that the kernel still needs recompiling. Is that normal? Best regards, Olivier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Michele Baldessari <michele@acksyn.org> |
|---|---|
| Date | 2015-10-26 13:10 +0100 |
| Message-ID | <qnOL8-83u-17@gated-at.bofh.it> |
| In reply to | #1255824 |
Hi Olivier, On Mon, Oct 26, 2015 at 12:00:50PM +0100, Olivier Scherler wrote: > > On 24 oct. 2015, at 22:11, Jiri Kosina <jikos@kernel.org> wrote: > > On Sat, 24 Oct 2015, Michele Baldessari wrote: > > > >> The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order > >> to have the two distinct joysticks working. > >> > >> Before the change: > >> $ jstest /dev/input/js0 > >> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y) > >> ... > >> $ jstest /dev/input/js1 > >> jstest: No such file or directory > >> > >> After the change: > >> $ jstest /dev/input/js0 > >> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y) > >> ... > >> $ jstest /dev/input/js1 > >> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y) > >> ... > >> > >> Signed-off-by: Michele Baldessari <michele@acksyn.org> > > > > Adding Oliver to CC. > > > > Oliver, how come that you didn't need this while working on the inigial > > Xin-Mo Dual Arcade support? > > Because I didn’t mind whether the controller announced itself as two > joysticks with two axes each, or one joystick with four axes. In the > software I use it for (a MAME for the Raspberry Pi), I can map a > single device’s buttons and axes to several players. > > I’m a bit surprised with this, though: > > > $ jstest /dev/input/js0 > > Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y) > > because in my case I had four axes, at least using evtest (I don’t > remember if I tried jstest as well). Ah that is the crux of the matter. It never showed up with four axes in my tests (raspbian, kernel 4.1.7), hence I submitted the patch given that the two joysticks were indistinguishable without it on my setup. Which kernel version did you run your tests on? (Maybe some other change skewed things around?) > What bothered me at the time, though, is that even though the custom > driver was made as a kernel module, an entry had to be added in the > hid_have_special_driver table in hid-core.c for the kernel to use it, > which means, if I understand properly, that the kernel still needs > recompiling. Is that normal? I had that line in my kernel prior to my patch: https://github.com/raspberrypi/linux/blob/rpi-4.1.y/drivers/hid/hid-core.c#L2008 Kind regards, Michele -- Michele Baldessari <michele@acksyn.org> C2A5 9DA3 9961 4FFB E01B D0BC DDD4 DCCB 7515 5C6D -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lars Melin <larsm17@gmail.com> |
|---|---|
| Date | 2015-10-25 10:20 +0100 |
| Message-ID | <qnpD4-t9-21@gated-at.bofh.it> |
| In reply to | #1255221 |
On 2015-10-24 22:44, Michele Baldessari wrote:
> The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order
> to have the two distinct joysticks working.
>
> Before the change:
> $ jstest /dev/input/js0
> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> ...
> $ jstest /dev/input/js1
> jstest: No such file or directory
>
> After the change:
> $ jstest /dev/input/js0
> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> ...
> $ jstest /dev/input/js1
> Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> ...
>
> Signed-off-by: Michele Baldessari <michele@acksyn.org>
> ---
> drivers/hid/usbhid/hid-quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 1dff8f0015ba..f69049314a2c 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -150,6 +150,7 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_MULTIPLE_1781, USB_DEVICE_ID_RAPHNET_4NES4SNES_OLD, HID_QUIRK_MULTI_INPUT },
> { USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_2NES2SNES, HID_QUIRK_MULTI_INPUT },
> { USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_4NES4SNES, HID_QUIRK_MULTI_INPUT },
> + { USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
>
> { 0, 0 }
> };
>
Sorry but I don't believe that XIN_MO is the owner of the 16c0 VID so
should not be given that ownership in linux.
/Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Michele Baldessari <michele@acksyn.org> |
|---|---|
| Date | 2015-10-25 17:40 +0100 |
| Message-ID | <qnwuS-5ho-35@gated-at.bofh.it> |
| In reply to | #1255322 |
On Sun, Oct 25, 2015 at 04:15:17PM +0700, Lars Melin wrote:
> On 2015-10-24 22:44, Michele Baldessari wrote:
> >The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order
> >to have the two distinct joysticks working.
> >
> >Before the change:
> >$ jstest /dev/input/js0
> >Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> >...
> >$ jstest /dev/input/js1
> >jstest: No such file or directory
> >
> >After the change:
> >$ jstest /dev/input/js0
> >Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> >...
> >$ jstest /dev/input/js1
> >Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> >...
> >
> >Signed-off-by: Michele Baldessari <michele@acksyn.org>
> >---
> > drivers/hid/usbhid/hid-quirks.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> >index 1dff8f0015ba..f69049314a2c 100644
> >--- a/drivers/hid/usbhid/hid-quirks.c
> >+++ b/drivers/hid/usbhid/hid-quirks.c
> >@@ -150,6 +150,7 @@ static const struct hid_blacklist {
> > { USB_VENDOR_ID_MULTIPLE_1781, USB_DEVICE_ID_RAPHNET_4NES4SNES_OLD, HID_QUIRK_MULTI_INPUT },
> > { USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_2NES2SNES, HID_QUIRK_MULTI_INPUT },
> > { USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_4NES4SNES, HID_QUIRK_MULTI_INPUT },
> >+ { USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
> >
> > { 0, 0 }
> > };
> >
>
> Sorry but I don't believe that XIN_MO is the owner of the 16c0 VID so should
> not be given that ownership in linux.
The "ownership" of 16c0 is a completely orthogonal issue to this patch.
16c0 was already defined (twice actually):
$ grep -i 0x16c0 drivers/hid/hid-ids.h | awk '{ print $2 }'
USB_VENDOR_ID_ATMEL_V_USB
USB_VENDOR_ID_XIN_MO
cheers,
Michele
--
Michele Baldessari <michele@acksyn.org>
C2A5 9DA3 9961 4FFB E01B D0BC DDD4 DCCB 7515 5C6D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web