Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade

From	Michele Baldessari <michele@acksyn.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade
Date	2015-10-25 17:40 +0100
Message-ID	<qnwuS-5ho-35@gated-at.bofh.it> (permalink)
References	<qn9oC-4Li-9@gated-at.bofh.it> <qnpD4-t9-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Oct 25, 2015 at 04:15:17PM +0700, Lars Melin wrote:
> On 2015-10-24 22:44, Michele Baldessari wrote:
> >The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order
> >to have the two distinct joysticks working.
> >
> >Before the change:
> >$ jstest /dev/input/js0
> >Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> >...
> >$ jstest /dev/input/js1
> >jstest: No such file or directory
> >
> >After the change:
> >$ jstest /dev/input/js0
> >Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> >...
> >$ jstest /dev/input/js1
> >Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y)
> >...
> >
> >Signed-off-by: Michele Baldessari <michele@acksyn.org>
> >---
> >  drivers/hid/usbhid/hid-quirks.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> >index 1dff8f0015ba..f69049314a2c 100644
> >--- a/drivers/hid/usbhid/hid-quirks.c
> >+++ b/drivers/hid/usbhid/hid-quirks.c
> >@@ -150,6 +150,7 @@ static const struct hid_blacklist {
> >  	{ USB_VENDOR_ID_MULTIPLE_1781, USB_DEVICE_ID_RAPHNET_4NES4SNES_OLD, HID_QUIRK_MULTI_INPUT },
> >  	{ USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_2NES2SNES, HID_QUIRK_MULTI_INPUT },
> >  	{ USB_VENDOR_ID_DRACAL_RAPHNET, USB_DEVICE_ID_RAPHNET_4NES4SNES, HID_QUIRK_MULTI_INPUT },
> >+	{ USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
> >
> >  	{ 0, 0 }
> >  };
> >
> 
> Sorry but I don't believe that XIN_MO is the owner of the 16c0 VID so should
> not be given that ownership in linux.

The "ownership" of 16c0 is a completely orthogonal issue to this patch.

16c0 was already defined (twice actually):
$ grep -i 0x16c0 drivers/hid/hid-ids.h | awk '{ print $2 }'
USB_VENDOR_ID_ATMEL_V_USB
USB_VENDOR_ID_XIN_MO

cheers,
Michele
-- 
Michele Baldessari            <michele@acksyn.org>
C2A5 9DA3 9961 4FFB E01B  D0BC DDD4 DCCB 7515 5C6D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Michele Baldessari <michele@acksyn.org> - 2015-10-24 18:00 +0200
  Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Jiri Kosina <jikos@kernel.org> - 2015-10-24 22:20 +0200
    Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Olivier Scherler <oscherler@ithink.ch> - 2015-10-26 12:10 +0100
      Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Michele Baldessari <michele@acksyn.org> - 2015-10-26 13:10 +0100
  Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Lars Melin <larsm17@gmail.com> - 2015-10-25 10:20 +0100
    Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade Michele Baldessari <michele@acksyn.org> - 2015-10-25 17:40 +0100

csiph-web