Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1255217 > unrolled thread
| Started by | Fabio Estevam <festevam@gmail.com> |
|---|---|
| First post | 2015-10-24 17:50 +0200 |
| Last post | 2015-10-30 10:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] mtd: spi-nor: fsl-quadspi: add big-endian support Fabio Estevam <festevam@gmail.com> - 2015-10-24 17:50 +0200
RE: [PATCH] mtd: spi-nor: fsl-quadspi: add big-endian support Yao Yuan <yao.yuan@freescale.com> - 2015-10-30 10:50 +0100
| From | Fabio Estevam <festevam@gmail.com> |
|---|---|
| Date | 2015-10-24 17:50 +0200 |
| Subject | Re: [PATCH] mtd: spi-nor: fsl-quadspi: add big-endian support |
| Message-ID | <qn9eW-4A2-13@gated-at.bofh.it> |
On Fri, Oct 23, 2015 at 5:53 AM, Yuan Yao <yao.yuan@freescale.com> wrote:
> /*
> + * R/W functions for big- or little-endian registers:
> + * The qSPI controller's endian is independent of the CPU core's endian.
> + * So far, although the CPU core is little-endian but the qSPI have two
> + * versions for big-endian and little-endian.
> + */
> +static void qspi_writel(struct fsl_qspi *q, u32 val, void __iomem *addr)
> +{
> + if (q->big_endian)
> + iowrite32be(val, addr);
> + else
> + iowrite32(val, addr);
> +}
I suggest you to implement regmap support for this driver instead.
Take a look at drivers/watchdog/imx2_wdt.c for a reference.
Then you only need to pass 'big-endian' as a property for the qspi in
the .dtsi file and regmap core will take care of endianness.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Yao Yuan <yao.yuan@freescale.com> |
|---|---|
| Date | 2015-10-30 10:50 +0100 |
| Message-ID | <qpetQ-48J-13@gated-at.bofh.it> |
| In reply to | #1255217 |
SGkgRmFiaW8gRXN0ZXZhbSwNCg0KVGhhbmtzIGZvciB5b3VyIHN1Z2dlc3Rpb24uDQpXZSBoYXZl IGFuIGludGVybmFsIGRpc2N1c3Npb25zIGZvciB0aGF0Lg0KDQpXZSB0aGluayB0aGF0Og0KQWNj b3JkaW5nIHRvIHRoZSBpbml0aWFsIGNvbW1pdCBtZXNzYWdlIG9mIHJlZ21hcCwgaXQgaXMgdGFy Z2V0aW5nIG5vbi1tZW1vcnkgbWFwcGVkIGJ1c2VzLiAocmVnbWFwOiBBZGQgZ2VuZXJpYyBub24t bWVtb3J5IG1hcHBlZCByZWdpc3RlciBhY2Nlc3MgQVBJKSAgQnV0IGluIHRoZSBpbXgyX3dkdCBk cml2ZXIsIGl0IGlzIHVzZWQgZm9yIG1lbW9yeS1tYXBwZWQgcmVnaXN0ZXIgc3BhY2UuICBTbyBp dCBzZWVtcyB0aGF0IHVzaW5nIHN1Y2ggYSBjb21wbGV4IGZyYW1ld29yayBqdXN0IHRvIGRlYWwg d2l0aCBlbmRpYW4gaXMgYW4gb3Zlci1raWxsLg0KDQp3aGVuIGl0IGlzIG5vdCBuZWNlc3Nhcnkg dG8gZW5hYmxlIHRoZSBjbG9jayBldmVyeSB0aW1lIHdlIGFjY2VzcyB0aGUgcmVnaXN0ZXIuICAN CldlIGRvbid0IHRoaW5rIGl0IGlzIG9idmlvdXMgdG8gdXMgaG93IHRvIHVzZSBpdCBmb3IgaGFu ZGxpbmcgZW5kaWFubmVzcywgZXNwZWNpYWxseSBub3QgdGhlIHdheSBpbXgyX3dkdCB1c2VzIHJl Z21hcC4gIF9fcmVnbWFwX2luaXRfbW1pb19jbGsoKSBjYWxscyByZWdtYXBfbW1pb19nZW5fY29u dGV4dCgpIHdoaWNoIGVycm9ycyBvdXQgaWYgcmVnX2Zvcm1hdF9lbmRpYW4gaXMgbm90IFJFR01B UF9FTkRJQU5fREVGQVVMVCBvciBSRUdNQVBfRU5ESUFOX05BVElWRSwgYW5kIGVsc2V3aGVyZSBy ZWdtYXAtbW1pby5jIEl0IHNlZW1zIG9ubHkgbGl0dGxlLWVuZGlhbiBhY2Nlc3NvcnMuDQoNCkFs dGhvdWdoIGl0IGlzIHBvc3NpYmxlIHRvIGFkZCB0aGUgZW5kaWFubmVzcyBzdXBwb3J0IGluIHRo ZSByZWdtYXBfbW1pbyBkcml2ZXIsIHdlIGRvbid0IHNlZSB0b28gbXVjaCB2YWx1ZSBpbiB1c2lu ZyBpdCBlc3BlY2lhbGx5IA0KDQpTbyB3ZSB0aGluazoNCnN0YXRpYyB2b2lkIHFzcGlfd3JpdGVs KHN0cnVjdCBmc2xfcXNwaSAqcSwgdTMyIHZhbCwgdm9pZCBfX2lvbWVtDQoqYWRkcikgew0KICAg ICAgaWYgKHEtPmJpZ19lbmRpYW4pDQogICAgICAgICAgICAgIGlvd3JpdGUzMmJlKHZhbCwgYWRk cik7DQogICAgICBlbHNlDQogICAgICAgICAgICAgIGlvd3JpdGUzMih2YWwsIGFkZHIpOw0KfQ0K VGhpcyB3YXkgaXMgYW4gZWFzaWVyLCBtb3JlIGVmZmVjdGl2ZSBzb2x1dGlvbiB0byBkbyB0aGUg ZW5kaWFuIGlzc3VlLg0KDQpIb3cgYWJvdXQgeW91ciB0aGluaz8NCg0KQmVzdCBSZWdhcmRzLA0K WXVhbiBZYW8NCg0KT24gU2F0LCBPY3QgMjQsIDIwMTUgYXQgMTE6NDcgUE0sIEZhYmlvIEVzdGV2 YW0gPGZlc3RldmFtQGdtYWlsLmNvbT4gd3JvdGU6DQo+IE9uIEZyaSwgT2N0IDIzLCAyMDE1IGF0 IDU6NTMgQU0sIFl1YW4gWWFvIDx5YW8ueXVhbkBmcmVlc2NhbGUuY29tPiB3cm90ZToNCj4gDQo+ ID4gK3N0YXRpYyB2b2lkIHFzcGlfd3JpdGVsKHN0cnVjdCBmc2xfcXNwaSAqcSwgdTMyIHZhbCwg dm9pZCBfX2lvbWVtDQo+ID4gKyphZGRyKSB7DQo+ID4gKyAgICAgICBpZiAocS0+YmlnX2VuZGlh bikNCj4gPiArICAgICAgICAgICAgICAgaW93cml0ZTMyYmUodmFsLCBhZGRyKTsNCj4gPiArICAg ICAgIGVsc2UNCj4gPiArICAgICAgICAgICAgICAgaW93cml0ZTMyKHZhbCwgYWRkcik7DQo+ID4g K30NCj4gDQo+IEkgc3VnZ2VzdCB5b3UgdG8gaW1wbGVtZW50IHJlZ21hcCBzdXBwb3J0IGZvciB0 aGlzIGRyaXZlciBpbnN0ZWFkLg0KPiANCj4gVGFrZSBhIGxvb2sgYXQgZHJpdmVycy93YXRjaGRv Zy9pbXgyX3dkdC5jIGZvciBhIHJlZmVyZW5jZS4NCj4gDQo+IFRoZW4geW91IG9ubHkgbmVlZCB0 byBwYXNzICdiaWctZW5kaWFuJyBhcyBhIHByb3BlcnR5IGZvciB0aGUgcXNwaSBpbiB0aGUgLmR0 c2kNCj4gZmlsZSBhbmQgcmVnbWFwIGNvcmUgd2lsbCB0YWtlIGNhcmUgb2YgZW5kaWFubmVzcy4N Cg== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web