Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1253574 > unrolled thread
| Started by | Taku Izumi <izumi.taku@jp.fujitsu.com> |
|---|---|
| First post | 2015-10-22 10:30 +0200 |
| Last post | 2015-10-23 02:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds Taku Izumi <izumi.taku@jp.fujitsu.com> - 2015-10-22 10:30 +0200
Re: [PATCH] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-10-22 10:40 +0200
RE: [PATCH] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds "Izumi, Taku" <izumi.taku@jp.fujitsu.com> - 2015-10-23 02:40 +0200
| From | Taku Izumi <izumi.taku@jp.fujitsu.com> |
|---|---|
| Date | 2015-10-22 10:30 +0200 |
| Subject | [PATCH] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds |
| Message-ID | <qmjq1-59y-7@gated-at.bofh.it> |
commit-0f96a99 introduces the following warning message: drivers/firmware/efi/fake_mem.c:186:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] new_memmap_phy was defined as a u64 value and casted to void*. This causes a warning of int-to-pointer-cast on x86 32-bit environment. This patch changes the type of "new_memmap_phy" variable from "u64" into "phys_addr_t" to avoid it. Reported-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com> --- drivers/firmware/efi/fake_mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/efi/fake_mem.c b/drivers/firmware/efi/fake_mem.c index 32bcb14..b65bc07 100644 --- a/drivers/firmware/efi/fake_mem.c +++ b/drivers/firmware/efi/fake_mem.c @@ -59,7 +59,7 @@ void __init efi_fake_memmap(void) u64 start, end, m_start, m_end, m_attr; int new_nr_map = memmap.nr_map; efi_memory_desc_t *md; - u64 new_memmap_phy; + phys_addr_t new_memmap_phy; void *new_memmap; void *old, *new; int i; -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Ard Biesheuvel <ard.biesheuvel@linaro.org> |
|---|---|
| Date | 2015-10-22 10:40 +0200 |
| Message-ID | <qmjzI-5kR-31@gated-at.bofh.it> |
| In reply to | #1253574 |
> On 22 okt. 2015, at 19:28, Taku Izumi <izumi.taku@jp.fujitsu.com> wrote: > > commit-0f96a99 introduces the following warning message: > > drivers/firmware/efi/fake_mem.c:186:20: warning: cast to pointer > from integer of different size [-Wint-to-pointer-cast] > > new_memmap_phy was defined as a u64 value and casted to void*. > This causes a warning of int-to-pointer-cast on x86 32-bit > environment. > > This patch changes the type of "new_memmap_phy" variable > from "u64" into "phys_addr_t" to avoid it. This assumes sizeof(void*) == sizeof(phys_addr_t), which is not always true, e.g., on 32-bit ARM (whose UEFI support is in development but not yet merged) with LPAE enabled. Could we use unsigned long instead? Ard. > Reported-by: Ingo Molnar <mingo@kernel.org> > Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com> > --- > drivers/firmware/efi/fake_mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/efi/fake_mem.c b/drivers/firmware/efi/fake_mem.c > index 32bcb14..b65bc07 100644 > --- a/drivers/firmware/efi/fake_mem.c > +++ b/drivers/firmware/efi/fake_mem.c > @@ -59,7 +59,7 @@ void __init efi_fake_memmap(void) > u64 start, end, m_start, m_end, m_attr; > int new_nr_map = memmap.nr_map; > efi_memory_desc_t *md; > - u64 new_memmap_phy; > + phys_addr_t new_memmap_phy; > void *new_memmap; > void *old, *new; > int i; > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Izumi, Taku" <izumi.taku@jp.fujitsu.com> |
|---|---|
| Date | 2015-10-23 02:40 +0200 |
| Subject | RE: [PATCH] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds |
| Message-ID | <qmyyL-236-31@gated-at.bofh.it> |
| In reply to | #1253585 |
Dear Ard, > > commit-0f96a99 introduces the following warning message: > > > > drivers/firmware/efi/fake_mem.c:186:20: warning: cast to pointer > > from integer of different size [-Wint-to-pointer-cast] > > > > new_memmap_phy was defined as a u64 value and casted to void*. > > This causes a warning of int-to-pointer-cast on x86 32-bit > > environment. > > > > This patch changes the type of "new_memmap_phy" variable > > from "u64" into "phys_addr_t" to avoid it. > > This assumes sizeof(void*) == sizeof(phys_addr_t), which is not always true, e.g., on 32-bit ARM (whose UEFI support is > in development but not yet merged) with LPAE enabled. > > Could we use unsigned long instead? Okay. I'll update my patch. Sincerely, Taku Izumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web