Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1254259

RE: [PATCH] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds

Show all headers | View raw

Dear Ard,

> > commit-0f96a99 introduces the following warning message:
> >
> >  drivers/firmware/efi/fake_mem.c:186:20: warning: cast to pointer
> >  from integer of different size [-Wint-to-pointer-cast]
> >
> > new_memmap_phy was defined as a u64 value and casted to void*.
> > This causes a warning of int-to-pointer-cast on x86 32-bit
> > environment.
> >
> > This patch changes the type of "new_memmap_phy" variable
> > from "u64" into "phys_addr_t" to avoid it.
> 
> This assumes sizeof(void*) == sizeof(phys_addr_t), which is not always true, e.g., on 32-bit ARM (whose UEFI support is
> in development but not yet merged) with LPAE enabled.
> 
> Could we use unsigned long instead?

  Okay. I'll update my patch.

Sincerely,
Taku Izumi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds Taku Izumi <izumi.taku@jp.fujitsu.com> - 2015-10-22 10:30 +0200
  Re: [PATCH] efi: Fix warning of int-to-pointer-cast on x86 32-bit builds Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-10-22 10:40 +0200
    RE: [PATCH] efi: Fix warning of int-to-pointer-cast on x86 32-bit  builds "Izumi, Taku" <izumi.taku@jp.fujitsu.com> - 2015-10-23 02:40 +0200

csiph-web