Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1254241 > unrolled thread

Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific device tree binding document

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific device  tree binding document Mark Brown <broonie@kernel.org> - 2015-10-23 01:40 +0200
    Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific  device tree binding document Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-10-26 12:50 +0100

#1254241 — Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific device tree binding document

[Multipart message — attachments visible in raw view] — view raw

On Thu, Oct 15, 2015 at 02:47:07PM +0100, Charles Keepax wrote:

> +This document lists regulator specific bindings, see the primary binding
> +document:
> +  ../mfd/arizona.txt
> +
> +Required properties:
> +
> +  - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
> +    as covered in regulator.txt
> +
> +  - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
> +    wm5110, wm8280, wm8998, wm1814)
> +
> +  - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
> +    wm5110, wm8280, wm8998, wm1814)
> +
> +  - SPKVDD-supply : Speaker driver power supply (wm8997)
> +

I'd expect these to be on the MFD since they're (with the exception of
AVDD which supplies the regulators IIRC) not part of the regulator
component of the device and are core for bringing it online.

> +Optional properties:
> +  - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
> +
> +Optional subnodes:
> +  - ldo1 : Initial data for the LDO1 regulator, as covered in
> +    Documentation/devicetree/bindings/regulator/regulator.txt
> +  - micvdd : Initial data for the MICVDD regulator, as covered in
> +    Documentation/devicetree/bindings/regulator/regulator.txt

These are the properties for the regulator itself.

> +++ b/MAINTAINERS
> @@ -11381,6 +11381,7 @@ W:	http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-devices
>  S:	Supported
>  F:	Documentation/hwmon/wm83??
>  F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> +F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
>  F:	arch/arm/mach-s3c64xx/mach-crag6410*
>  F:	drivers/clk/clk-wm83*.c
>  F:	drivers/extcon/extcon-arizona.c

I'd suggest moving this to a separate patch which adds all the new files
together to make it easier to merge things.

[toc] | [next] | [standalone]

#1255851 — Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific device tree binding document

On Thu, Oct 22, 2015 at 01:44:49PM +0100, Mark Brown wrote:
> On Thu, Oct 15, 2015 at 02:47:07PM +0100, Charles Keepax wrote:
> 
> > +This document lists regulator specific bindings, see the primary binding
> > +document:
> > +  ../mfd/arizona.txt
> > +
> > +Required properties:
> > +
> > +  - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
> > +    as covered in regulator.txt
> > +
> > +  - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
> > +    wm5110, wm8280, wm8998, wm1814)
> > +
> > +  - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
> > +    wm5110, wm8280, wm8998, wm1814)
> > +
> > +  - SPKVDD-supply : Speaker driver power supply (wm8997)
> > +
> 
> I'd expect these to be on the MFD since they're (with the exception of
> AVDD which supplies the regulators IIRC) not part of the regulator
> component of the device and are core for bringing it online.

Yeah, fair enough I will move those back into the MFD part.

> 
> > +Optional properties:
> > +  - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
> > +
> > +Optional subnodes:
> > +  - ldo1 : Initial data for the LDO1 regulator, as covered in
> > +    Documentation/devicetree/bindings/regulator/regulator.txt
> > +  - micvdd : Initial data for the MICVDD regulator, as covered in
> > +    Documentation/devicetree/bindings/regulator/regulator.txt
> 
> These are the properties for the regulator itself.
> 
> > +++ b/MAINTAINERS
> > @@ -11381,6 +11381,7 @@ W:	http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-devices
> >  S:	Supported
> >  F:	Documentation/hwmon/wm83??
> >  F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> > +F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
> >  F:	arch/arm/mach-s3c64xx/mach-crag6410*
> >  F:	drivers/clk/clk-wm83*.c
> >  F:	drivers/extcon/extcon-arizona.c
> 
> I'd suggest moving this to a separate patch which adds all the new files
> together to make it easier to merge things.

Yeah no problem with making that a seperate patch.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web