Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1254241

Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific device tree binding document

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific device tree binding document
Date 2015-10-23 01:40 +0200
Message-ID <qmxCH-Il-31@gated-at.bofh.it> (permalink)
References <qjRoe-dR-5@gated-at.bofh.it> <qjRog-dR-55@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Oct 15, 2015 at 02:47:07PM +0100, Charles Keepax wrote:

> +This document lists regulator specific bindings, see the primary binding
> +document:
> +  ../mfd/arizona.txt
> +
> +Required properties:
> +
> +  - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
> +    as covered in regulator.txt
> +
> +  - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
> +    wm5110, wm8280, wm8998, wm1814)
> +
> +  - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
> +    wm5110, wm8280, wm8998, wm1814)
> +
> +  - SPKVDD-supply : Speaker driver power supply (wm8997)
> +

I'd expect these to be on the MFD since they're (with the exception of
AVDD which supplies the regulators IIRC) not part of the regulator
component of the device and are core for bringing it online.

> +Optional properties:
> +  - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
> +
> +Optional subnodes:
> +  - ldo1 : Initial data for the LDO1 regulator, as covered in
> +    Documentation/devicetree/bindings/regulator/regulator.txt
> +  - micvdd : Initial data for the MICVDD regulator, as covered in
> +    Documentation/devicetree/bindings/regulator/regulator.txt

These are the properties for the regulator itself.

> +++ b/MAINTAINERS
> @@ -11381,6 +11381,7 @@ W:	http://opensource.wolfsonmicro.com/content/linux-drivers-wolfson-devices
>  S:	Supported
>  F:	Documentation/hwmon/wm83??
>  F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> +F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
>  F:	arch/arm/mach-s3c64xx/mach-crag6410*
>  F:	drivers/clk/clk-wm83*.c
>  F:	drivers/extcon/extcon-arizona.c

I'd suggest moving this to a separate patch which adds all the new files
together to make it easier to merge things.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific device  tree binding document Mark Brown <broonie@kernel.org> - 2015-10-23 01:40 +0200
  Re: [PATCH v2 2/3] regulator: arizona: Add regulator specific  device tree binding document Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-10-26 12:50 +0100

csiph-web