Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1245225 > unrolled thread
| Started by | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| First post | 2015-10-13 02:30 +0200 |
| Last post | 2015-10-14 15:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] perf hists browser: Add 'm' key for context menu display Namhyung Kim <namhyung@kernel.org> - 2015-10-13 02:30 +0200
Re: [PATCH] perf hists browser: Add 'm' key for context menu display Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-13 04:40 +0200
[tip:perf/core] perf hists browser: Add 'm' key for context menu display tip-bot for Namhyung Kim <tipbot@zytor.com> - 2015-10-14 15:20 +0200
| From | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| Date | 2015-10-13 02:30 +0200 |
| Subject | [PATCH] perf hists browser: Add 'm' key for context menu display |
| Message-ID | <qiVDz-6NR-5@gated-at.bofh.it> |
With horizontal scrolling, the left/right arrow keys are used to scroll columns and ENTER/ESC keys are used to enter/exit menu. However if callchain is recorded, the ENTER key is used to toggle callchain expansion so there's no way to display menu. Use 'm' key to display the menu for this case. Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- tools/perf/ui/browsers/hists.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 9b7346a881cf..c8ec9bdb9c04 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -1769,6 +1769,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, "E Expand all callchains\n" \ "F Toggle percentage of filtered entries\n" \ "H Display column headers\n" \ + "m Display context menu\n" \ "S Zoom into current Processor Socket\n" \ /* help messages are sorted by lexical order of the hotkey */ @@ -1934,6 +1935,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, continue; case K_ENTER: case K_RIGHT: + case 'm': /* menu */ break; case K_ESC: -- 2.6.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2015-10-13 04:40 +0200 |
| Message-ID | <qiXFn-1kS-3@gated-at.bofh.it> |
| In reply to | #1245225 |
Em Tue, Oct 13, 2015 at 09:02:01AM +0900, Namhyung Kim escreveu: > With horizontal scrolling, the left/right arrow keys are used to > scroll columns and ENTER/ESC keys are used to enter/exit menu. > However if callchain is recorded, the ENTER key is used to toggle > callchain expansion so there's no way to display menu. Use 'm' key to > display the menu for this case. Thanks, applied. - Arnaldo > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/perf/ui/browsers/hists.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c > index 9b7346a881cf..c8ec9bdb9c04 100644 > --- a/tools/perf/ui/browsers/hists.c > +++ b/tools/perf/ui/browsers/hists.c > @@ -1769,6 +1769,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, > "E Expand all callchains\n" \ > "F Toggle percentage of filtered entries\n" \ > "H Display column headers\n" \ > + "m Display context menu\n" \ > "S Zoom into current Processor Socket\n" \ > > /* help messages are sorted by lexical order of the hotkey */ > @@ -1934,6 +1935,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, > continue; > case K_ENTER: > case K_RIGHT: > + case 'm': > /* menu */ > break; > case K_ESC: > -- > 2.6.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for Namhyung Kim <tipbot@zytor.com> |
|---|---|
| Date | 2015-10-14 15:20 +0200 |
| Subject | [tip:perf/core] perf hists browser: Add 'm' key for context menu display |
| Message-ID | <qju8k-81e-69@gated-at.bofh.it> |
| In reply to | #1245225 |
Commit-ID: 31eb4360546b4bd890f349db01295a173c09b0fb Gitweb: http://git.kernel.org/tip/31eb4360546b4bd890f349db01295a173c09b0fb Author: Namhyung Kim <namhyung@kernel.org> AuthorDate: Tue, 13 Oct 2015 09:02:01 +0900 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Mon, 12 Oct 2015 23:29:14 -0300 perf hists browser: Add 'm' key for context menu display With horizontal scrolling, the left/right arrow keys are used to scroll columns and ENTER/ESC keys are used to enter/exit menu. However if callchain is recorded, the ENTER key is used to toggle callchain expansion so there's no way to display menu. Use 'm' key to display the menu for this case. Signed-off-by: Namhyung Kim <namhyung@kernel.org> Cc: David Ahern <dsahern@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1444694521-8136-1-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/ui/browsers/hists.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 7728349..e5afb89 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -1769,6 +1769,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, "E Expand all callchains\n" \ "F Toggle percentage of filtered entries\n" \ "H Display column headers\n" \ + "m Display context menu\n" \ "S Zoom into current Processor Socket\n" \ /* help messages are sorted by lexical order of the hotkey */ @@ -1935,6 +1936,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, continue; case K_ENTER: case K_RIGHT: + case 'm': /* menu */ break; case K_ESC: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web