Re: [PATCH] perf hists browser: Add 'm' key for context menu display

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf hists browser: Add 'm' key for context menu display
Date	2015-10-13 04:40 +0200
Message-ID	<qiXFn-1kS-3@gated-at.bofh.it> (permalink)
References	<qiVDz-6NR-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Tue, Oct 13, 2015 at 09:02:01AM +0900, Namhyung Kim escreveu:
> With horizontal scrolling, the left/right arrow keys are used to
> scroll columns and ENTER/ESC keys are used to enter/exit menu.
> However if callchain is recorded, the ENTER key is used to toggle
> callchain expansion so there's no way to display menu.  Use 'm' key to
> display the menu for this case.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/ui/browsers/hists.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index 9b7346a881cf..c8ec9bdb9c04 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -1769,6 +1769,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
>  	"E             Expand all callchains\n"				\
>  	"F             Toggle percentage of filtered entries\n"		\
>  	"H             Display column headers\n"			\
> +	"m             Display context menu\n"				\
>  	"S             Zoom into current Processor Socket\n"		\
>  
>  	/* help messages are sorted by lexical order of the hotkey */
> @@ -1934,6 +1935,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
>  			continue;
>  		case K_ENTER:
>  		case K_RIGHT:
> +		case 'm':
>  			/* menu */
>  			break;
>  		case K_ESC:
> -- 
> 2.6.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] perf hists browser: Add 'm' key for context menu display Namhyung Kim <namhyung@kernel.org> - 2015-10-13 02:30 +0200
  Re: [PATCH] perf hists browser: Add 'm' key for context menu display Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-13 04:40 +0200
  [tip:perf/core] perf hists browser: Add 'm'   key for context menu display tip-bot for Namhyung Kim <tipbot@zytor.com> - 2015-10-14 15:20 +0200

csiph-web