Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1244152 > unrolled thread
| Started by | Anand Moon <linux.amoon@gmail.com> |
|---|---|
| First post | 2015-10-11 17:50 +0200 |
| Last post | 2015-10-13 04:50 +0200 |
| Articles | 15 on this page of 35 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Anand Moon <linux.amoon@gmail.com> - 2015-10-11 17:50 +0200
[PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-11 17:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-12 07:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-12 12:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Jaehoon Chung <jh80.chung@samsung.com> - 2015-10-12 13:00 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-12 13:30 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-12 14:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Jaehoon Chung <jh80.chung@samsung.com> - 2015-10-12 15:10 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-12 15:20 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Jaehoon Chung <jh80.chung@samsung.com> - 2015-10-13 04:30 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-12 17:40 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-13 02:20 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-13 05:10 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-13 05:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-13 05:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-13 18:30 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-14 02:10 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Alim Akhtar <alim.akhtar@gmail.com> - 2015-10-14 03:10 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-14 03:20 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Jaehoon Chung <jh80.chung@samsung.com> - 2015-10-14 03:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-14 04:00 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Alim Akhtar <alim.akhtar@gmail.com> - 2015-10-14 04:10 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Alim Akhtar <alim.akhtar@gmail.com> - 2015-10-14 04:20 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Alim Akhtar <alim.akhtar@gmail.com> - 2015-10-14 04:30 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-14 04:30 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Doug Anderson <dianders@chromium.org> - 2015-10-15 00:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-14 06:00 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-14 06:20 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-12 06:40 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Jaehoon Chung <jh80.chung@samsung.com> - 2015-10-12 06:50 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-13 02:20 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Jaehoon Chung <jh80.chung@samsung.com> - 2015-10-13 04:10 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Anand Moon <linux.amoon@gmail.com> - 2015-10-13 05:30 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Anand Moon <linux.amoon@gmail.com> - 2015-10-13 06:10 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Anand Moon <linux.amoon@gmail.com> - 2015-10-13 04:50 +0200
Page 2 of 2 — ← Prev page 1 [2]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-10-14 04:00 +0200 |
| Subject | Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support |
| Message-ID | <qjjwe-9o-7@gated-at.bofh.it> |
| In reply to | #1246242 |
On 14.10.2015 10:40, Jaehoon Chung wrote: > On 10/14/2015 10:15 AM, Krzysztof Kozlowski wrote: >> On 14.10.2015 10:06, Alim Akhtar wrote: >>> +Doug >>> Hello, >>> AFAIR, dw_mmc host controller does support UHS-I [1], specially SDR50 >>> and SDR104 modes. >>> >>> [1]: http://www.spinics.net/lists/linux-mmc/msg28186.html >>> >>> What I remember is, one need to set "broken-cd" property also in order >>> to make it work because of the vqmmc and vmmc connection on board. I >>> didn't find the link right now, but you can search on the web, there >>> was a long discussion about handling this. >>> Have not checked it recently, so not sure if this got broken somehow. >>> >> >> Please, don't top post. >> >> I am not a SD/MMC specialist (I do not feel enough confident in its >> internals) but the datasheet for 5422 does not mention UHS. However it >> mentions "High Speed DDR Mode with 200 MHz clock rate (HS400)". This >> does not look like UHS... > > You're right. It's not UHS mode. it mentions eMMC's HS400 mode. > UHS and HS400 are difference mode. > > eMMC mode are supported > >> https://www.sdcard.org/developers/overview/bus_speed/ >> This of course is not a definite proof that 5422 does not support UHS. I >> am just saying that I couldn't find any information that *it does*. > > Well, I think you want to know whether it supported or not. > Then you can find the information at User manual. > In mobile storage part of User manual, it described the overview. > Mobile storage host supports these specification: > - Secure Digital memory (SD memory version 3.0) > - Secure Digital I/O SDIO (SDIO version 3.0) > - etc... > > SD3.0 is supported UHS-I mode. > If user manual of exynos5422 is mentioned this specification, it should be supported UHS-I mode. Thanks! Indeed datasheet mentions that supported SD and SDIO is version 3.0 (not 3.01... which seems irrelevant because 3.0 introduced UHS-I, right?). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Alim Akhtar <alim.akhtar@gmail.com> |
|---|---|
| Date | 2015-10-14 04:10 +0200 |
| Subject | Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support |
| Message-ID | <qjjFU-F5-3@gated-at.bofh.it> |
| In reply to | #1246247 |
On Wed, Oct 14, 2015 at 7:22 AM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 14.10.2015 10:40, Jaehoon Chung wrote: >> On 10/14/2015 10:15 AM, Krzysztof Kozlowski wrote: >>> On 14.10.2015 10:06, Alim Akhtar wrote: >>>> +Doug >>>> Hello, >>>> AFAIR, dw_mmc host controller does support UHS-I [1], specially SDR50 >>>> and SDR104 modes. >>>> >>>> [1]: http://www.spinics.net/lists/linux-mmc/msg28186.html >>>> >>>> What I remember is, one need to set "broken-cd" property also in order >>>> to make it work because of the vqmmc and vmmc connection on board. I >>>> didn't find the link right now, but you can search on the web, there >>>> was a long discussion about handling this. >>>> Have not checked it recently, so not sure if this got broken somehow. >>>> >>> >>> Please, don't top post. >>> >>> I am not a SD/MMC specialist (I do not feel enough confident in its >>> internals) but the datasheet for 5422 does not mention UHS. However it >>> mentions "High Speed DDR Mode with 200 MHz clock rate (HS400)". This >>> does not look like UHS... >> >> You're right. It's not UHS mode. it mentions eMMC's HS400 mode. >> UHS and HS400 are difference mode. >> >> eMMC mode are supported >> >>> https://www.sdcard.org/developers/overview/bus_speed/ >>> This of course is not a definite proof that 5422 does not support UHS. I >>> am just saying that I couldn't find any information that *it does*. >> >> Well, I think you want to know whether it supported or not. >> Then you can find the information at User manual. >> In mobile storage part of User manual, it described the overview. >> Mobile storage host supports these specification: >> - Secure Digital memory (SD memory version 3.0) >> - Secure Digital I/O SDIO (SDIO version 3.0) >> - etc... >> >> SD3.0 is supported UHS-I mode. >> If user manual of exynos5422 is mentioned this specification, it should be supported UHS-I mode. > > Thanks! Indeed datasheet mentions that supported SD and SDIO is version > 3.0 (not 3.01... which seems irrelevant because 3.0 introduced UHS-I, > right?). > Yes, your understanding is right. SD3.0 does includes UHS-I. > Best regards, > Krzysztof -- Regards, Alim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Alim Akhtar <alim.akhtar@gmail.com> |
|---|---|
| Date | 2015-10-14 04:20 +0200 |
| Subject | Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support |
| Message-ID | <qjjPA-10U-11@gated-at.bofh.it> |
| In reply to | #1246236 |
On Wed, Oct 14, 2015 at 6:45 AM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 14.10.2015 10:06, Alim Akhtar wrote: >> +Doug >> Hello, >> AFAIR, dw_mmc host controller does support UHS-I [1], specially SDR50 >> and SDR104 modes. >> >> [1]: http://www.spinics.net/lists/linux-mmc/msg28186.html >> >> What I remember is, one need to set "broken-cd" property also in order >> to make it work because of the vqmmc and vmmc connection on board. I >> didn't find the link right now, but you can search on the web, there >> was a long discussion about handling this. >> Have not checked it recently, so not sure if this got broken somehow. >> > > Please, don't top post. > I am sorry, but I didn't get this, what is the guide line here??? > I am not a SD/MMC specialist (I do not feel enough confident in its > internals) but the datasheet for 5422 does not mention UHS. However it > mentions "High Speed DDR Mode with 200 MHz clock rate (HS400)". This > does not look like UHS... > https://www.sdcard.org/developers/overview/bus_speed/ > This of course is not a definite proof that 5422 does not support UHS. I > am just saying that I couldn't find any information that *it does*. > > Best regards, > Krzysztof > -- Regards, Alim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Alim Akhtar <alim.akhtar@gmail.com> |
|---|---|
| Date | 2015-10-14 04:30 +0200 |
| Subject | Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support |
| Message-ID | <qjjZf-1gq-1@gated-at.bofh.it> |
| In reply to | #1246256 |
On Wed, Oct 14, 2015 at 7:50 AM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 14.10.2015 11:13, Alim Akhtar wrote: >> On Wed, Oct 14, 2015 at 6:45 AM, Krzysztof Kozlowski >> <k.kozlowski@samsung.com> wrote: >>> On 14.10.2015 10:06, Alim Akhtar wrote: >>>> +Doug >>>> Hello, >>>> AFAIR, dw_mmc host controller does support UHS-I [1], specially SDR50 >>>> and SDR104 modes. >>>> >>>> [1]: http://www.spinics.net/lists/linux-mmc/msg28186.html >>>> >>>> What I remember is, one need to set "broken-cd" property also in order >>>> to make it work because of the vqmmc and vmmc connection on board. I >>>> didn't find the link right now, but you can search on the web, there >>>> was a long discussion about handling this. >>>> Have not checked it recently, so not sure if this got broken somehow. >>>> >>> >>> Please, don't top post. >>> >> I am sorry, but I didn't get this, what is the guide line here??? > > I mean reply inline, under the other person's quote, not above it. > > And some old, really old joke: > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > :) > I see..got it..thanks for clarification. > Best regards, > Krzysztof > -- Regards, Alim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-10-14 04:30 +0200 |
| Subject | Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support |
| Message-ID | <qjjZf-1gq-3@gated-at.bofh.it> |
| In reply to | #1246256 |
On 14.10.2015 11:13, Alim Akhtar wrote: > On Wed, Oct 14, 2015 at 6:45 AM, Krzysztof Kozlowski > <k.kozlowski@samsung.com> wrote: >> On 14.10.2015 10:06, Alim Akhtar wrote: >>> +Doug >>> Hello, >>> AFAIR, dw_mmc host controller does support UHS-I [1], specially SDR50 >>> and SDR104 modes. >>> >>> [1]: http://www.spinics.net/lists/linux-mmc/msg28186.html >>> >>> What I remember is, one need to set "broken-cd" property also in order >>> to make it work because of the vqmmc and vmmc connection on board. I >>> didn't find the link right now, but you can search on the web, there >>> was a long discussion about handling this. >>> Have not checked it recently, so not sure if this got broken somehow. >>> >> >> Please, don't top post. >> > I am sorry, but I didn't get this, what is the guide line here??? I mean reply inline, under the other person's quote, not above it. And some old, really old joke: A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? :) Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Doug Anderson <dianders@chromium.org> |
|---|---|
| Date | 2015-10-15 00:50 +0200 |
| Subject | Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support |
| Message-ID | <qjD1U-4gA-15@gated-at.bofh.it> |
| In reply to | #1246231 |
Hi, On Tue, Oct 13, 2015 at 6:06 PM, Alim Akhtar <alim.akhtar@gmail.com> wrote: > +Doug > Hello, > AFAIR, dw_mmc host controller does support UHS-I [1], specially SDR50 > and SDR104 modes. > > [1]: http://www.spinics.net/lists/linux-mmc/msg28186.html > > What I remember is, one need to set "broken-cd" property also in order > to make it work because of the vqmmc and vmmc connection on board. I > didn't find the link right now, but you can search on the web, there > was a long discussion about handling this. > Have not checked it recently, so not sure if this got broken somehow. Right. It _shouldn't_ be possible to add "vmmc/vqmmc" supplies to your DTS (which you do in patch 2/3) and also to use the "gpc2-2" pin for card detect (even if you configure it as a GPIO). Once you add "vmmc/vqmmc" then Linux ought to be turning these regulators off when no card is plugged in. Presumably the "vqmmc" regulator is hooked up to the "VDDQ_MMC2". If you look in the user manual for 5422 you can see that "GPC2[2]/SD_2_CDn" has power domain "VDDQ_MMC2". Thus you really shouldn't be using that pin when vqmmc is off. I think at some point someone claimed that it still worked for them, but nobody could ever explain why. Full discussion at <https://patchwork.kernel.org/patch/4763881/> --- In case it matters, comments on stuff from earlier in the thread: * As people pointed out, exynos5422 certainly supports all these modes (including DDR50) in the SoC. * Just because the SoC supports these modes doesn't mean that the boards do, which is why the SoC .dtsi doesn't include them. Thus, this patch is "right" in that it changes a board-specific file. * As Krzysztof points out this board doesn't "add" support but rather "enables" support. The distinction is subtle. * You might be able to get DDR50 working, but probably better to just start with SDR modes. Previously I never attempted to get DDR50 cards working, so possibly the software needs extra work? -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Anand Moon <linux.amoon@gmail.com> |
|---|---|
| Date | 2015-10-14 06:00 +0200 |
| Subject | Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support |
| Message-ID | <qjlom-3om-1@gated-at.bofh.it> |
| In reply to | #1246220 |
hi Krzysztof, On 14 October 2015 at 05:29, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 14.10.2015 01:27, Anand Moon wrote: >> Hi Krzysztof, >> >> On 13 October 2015 at 09:13, Krzysztof Kozlowski >> <k.kozlowski@samsung.com> wrote: >>> >>> On 13.10.2015 12:08, Anand Moon wrote: >>>> Hi Krzysztof, >>>> >>>> On 13 October 2015 at 05:44, Krzysztof Kozlowski >>>> <k.kozlowski@samsung.com> wrote: >>>>> On 13.10.2015 00:32, Anand Moon wrote: >>>>>> Hi Krzysztof, >>>>>> >>>>>> On 12 October 2015 at 11:14, Krzysztof Kozlowski >>>>>> <k.kozlowski@samsung.com> wrote: >>>>>>> On 12.10.2015 00:46, Anand Moon wrote: >>>>>>>> Added support for UHS-I bus speed 50MB/s (SDR50, DDR50) 104MB/s (SDR104) >>>>>>> >>>>>>> This description is not entirely correct. The MMC driver already >>>>>>> supports these UHS speeds (you did not any code) so you rather enabled >>>>>>> it (description of bindings says "is supported"). >>>>>>> >>>>>>> You mentioned DDR50 but I don't see respective property below. >>>>>>> >>>>>>> How do you know that these modes are really supported? I don't know. Can >>>>>>> you convince me? >>>>>> >>>>>> Setting this DDR50 capability give me this error. That's the reason to >>>>>> drop this capability. >>>>> >>>>> But you mentioned it in commit message! "Added support for UHS-I ... >>>>> (DDR50)" >>>>> >>>>> In the same time dropping DDR50 is not an sufficient proof that "SDR50 >>>>> and SDR104 are really supported". >>>>> >>>> >>>> These changes are related to the microSD card capabilities. >>>> So SDR50 have better frequency over DDR50. On the same Sandisk card. >>>> >>>> When the card select the capability for DDR50 >>>> --------------------------------------------------- >>>> [ 4.001477] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot >>>> req 50000000Hz, actual 50000000HZ div = 0) >>>> [ 4.001604] mmc1: new ultra high speed DDR50 SDHC card at address aaaa >>>> [ 4.004505] mmcblk0: mmc1:aaaa SL32G 29.7 GiB >>>> [ 4.009179] mmcblk0: error -110 sending status command, retrying >>>> [ 4.009271] mmcblk0: error -115 sending stop command, original cmd >>>> response 0x900, card status 0x900 >>>> [ 4.009275] mmcblk0: error -84 transferring data, sector 0, nr 8, >>>> cmd response 0x900, card status 0x0 >>>> [ 4.025563] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot >>>> req 400000Hz, actual 396825HZ div = 63) >>>> [ 4.067770] Console: switching to colour frame buffer device 274x77 >>>> [ 4.098782] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot >>>> req 50000000Hz, actual 50000000HZ div = 0) >>>> [ 4.099692] mmc1: tried to reset card >>>> [ 4.101332] mmcblk0: p1 p2 >>>> >>>> >>>> When the card select the capability for SDR50 >>>> --------------------------------------------------------------------------------- >>>> [ 2.439806] mmc_host mmc1: Bus speed (slot 0) = 100000000Hz (slot req >>>> 100000000Hz, actual 100000000HZ div = 0) >>>> [ 2.449729] mmc1: new ultra high speed SDR50 SDHC card at address aaaa >>>> [ 2.455984] mmcblk0: mmc1:aaaa SL32G 29.7 GiB >>>> [ 2.461743] mmcblk0: p1 p2 >>>> >>>> Which will relate to better read/write speed. >>> >>> Which is not an answer to my question. To none of my previous questions. >>> >> >> Basically UHS-I capability (sd-uhs-sdr12, sd-uhs-sdr25, sd-uhs-sdr50, >> sd-uhs-sdr104) help tune speed supported for mmc >> >> I have tired to compare the speed on high speed UHS-I vs ultra high >> speed UHS-I using izone utility. >> >> [ 2.572469] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot >> req 50000000Hz, actual 50000000HZ div = 0) >> [ 2.572609] mmc1: new high speed SDHC card at address aaaa >> >> Command line used: ./iozone -L64 -S32 -azecwI -+n -r4k -r64k >> -r128k -s10M -i0 -i1 -i2 -f datafile -Rb out.xls >> Output is in kBytes/sec >> Time Resolution = 0.000001 seconds. >> Processor cache size set to 32 kBytes. >> Processor cache line size set to 64 bytes. >> File stride size set to 17 * record size. >> random >> random bkwd record stride >> kB reclen write rewrite read reread read >> write read rewrite read fwrite frewrite fread >> freread >> 10240 4 1631 0 6556 0 5538 982 >> 10240 64 8828 0 18897 0 17994 303 >> 10240 128 6269 0 20670 0 20128 1096 >> --------------------------------------------------------------------------------------------------------- >> [ 2.613761] mmc_host mmc1: Bus speed (slot 0) = 100000000Hz (slot >> req 100000000Hz, actual 100000000HZ div = 0) >> [ 2.623573] mmc1: new ultra high speed SDR50 SDHC card at address aaaa >> >> Command line used: ./iozone -L64 -S32 -azecwI -+n -r4k -r64k >> -r128k -s10M -i0 -i1 -i2 -f datafile -Rb out.xls >> Output is in kBytes/sec >> Time Resolution = 0.000001 seconds. >> Processor cache size set to 32 kBytes. >> Processor cache line size set to 64 bytes. >> File stride size set to 17 * record size. >> random >> random bkwd record stride >> kB reclen write rewrite read reread read >> write read rewrite read fwrite frewrite fread >> freread >> 10240 4 1809 0 7507 0 5233 859 >> 10240 64 11622 0 31250 0 28072 516 >> 10240 128 4320 0 34417 0 32509 1148 >> >> My observation is that their slight increase in read/write operation. >> >> Hope I have tried to answer you query. If I am wrong please let me know. > > Nope, that did not answer my query. You gave some performance benchmarks > but my question was not about the speed of anything. The question is > (once again): > How do you know that these modes are really supported? > > You are marking the *host* as supporting these modes. Please provide > information that host supports them *really*, not by experimenting "oh, > it seems to work now, maybe it will work always". > > Usually vendors, if their products implement some kind of > specification/protocol, they mark the products as "compatible with XYZ" etc. I found this link from hardkernel website which specify the interface support http://www.hardkernel.com/main/products/prdt_info.php?g_code=G141578491347 Manufacturer Part Number : Sandisk SDSDQAD-016G Interface : UHS-1 SDR50 I don't know much internal specification of the Odroid XU3/XU4 Boards. I am not sure if it will support host will sd-uhs-sdr104, but it will be compatible for sd-uhs-sdr12, sd-uhs-sdr25, sd-uhs-sdr50. -Anand Moon > > Best regards, > Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-10-14 06:20 +0200 |
| Subject | Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support |
| Message-ID | <qjlHH-3ZX-5@gated-at.bofh.it> |
| In reply to | #1246291 |
On 14.10.2015 12:58, Anand Moon wrote: > hi Krzysztof, > > On 14 October 2015 at 05:29, Krzysztof Kozlowski > <k.kozlowski@samsung.com> wrote: >> On 14.10.2015 01:27, Anand Moon wrote: >>> Hi Krzysztof, >>> >>> On 13 October 2015 at 09:13, Krzysztof Kozlowski >>> <k.kozlowski@samsung.com> wrote: >>>> >>>> On 13.10.2015 12:08, Anand Moon wrote: >>>>> Hi Krzysztof, >>>>> >>>>> On 13 October 2015 at 05:44, Krzysztof Kozlowski >>>>> <k.kozlowski@samsung.com> wrote: >>>>>> On 13.10.2015 00:32, Anand Moon wrote: >>>>>>> Hi Krzysztof, >>>>>>> >>>>>>> On 12 October 2015 at 11:14, Krzysztof Kozlowski >>>>>>> <k.kozlowski@samsung.com> wrote: >>>>>>>> On 12.10.2015 00:46, Anand Moon wrote: >>>>>>>>> Added support for UHS-I bus speed 50MB/s (SDR50, DDR50) 104MB/s (SDR104) >>>>>>>> >>>>>>>> This description is not entirely correct. The MMC driver already >>>>>>>> supports these UHS speeds (you did not any code) so you rather enabled >>>>>>>> it (description of bindings says "is supported"). >>>>>>>> >>>>>>>> You mentioned DDR50 but I don't see respective property below. >>>>>>>> >>>>>>>> How do you know that these modes are really supported? I don't know. Can >>>>>>>> you convince me? >>>>>>> >>>>>>> Setting this DDR50 capability give me this error. That's the reason to >>>>>>> drop this capability. >>>>>> >>>>>> But you mentioned it in commit message! "Added support for UHS-I ... >>>>>> (DDR50)" >>>>>> >>>>>> In the same time dropping DDR50 is not an sufficient proof that "SDR50 >>>>>> and SDR104 are really supported". >>>>>> >>>>> >>>>> These changes are related to the microSD card capabilities. >>>>> So SDR50 have better frequency over DDR50. On the same Sandisk card. >>>>> >>>>> When the card select the capability for DDR50 >>>>> --------------------------------------------------- >>>>> [ 4.001477] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot >>>>> req 50000000Hz, actual 50000000HZ div = 0) >>>>> [ 4.001604] mmc1: new ultra high speed DDR50 SDHC card at address aaaa >>>>> [ 4.004505] mmcblk0: mmc1:aaaa SL32G 29.7 GiB >>>>> [ 4.009179] mmcblk0: error -110 sending status command, retrying >>>>> [ 4.009271] mmcblk0: error -115 sending stop command, original cmd >>>>> response 0x900, card status 0x900 >>>>> [ 4.009275] mmcblk0: error -84 transferring data, sector 0, nr 8, >>>>> cmd response 0x900, card status 0x0 >>>>> [ 4.025563] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot >>>>> req 400000Hz, actual 396825HZ div = 63) >>>>> [ 4.067770] Console: switching to colour frame buffer device 274x77 >>>>> [ 4.098782] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot >>>>> req 50000000Hz, actual 50000000HZ div = 0) >>>>> [ 4.099692] mmc1: tried to reset card >>>>> [ 4.101332] mmcblk0: p1 p2 >>>>> >>>>> >>>>> When the card select the capability for SDR50 >>>>> --------------------------------------------------------------------------------- >>>>> [ 2.439806] mmc_host mmc1: Bus speed (slot 0) = 100000000Hz (slot req >>>>> 100000000Hz, actual 100000000HZ div = 0) >>>>> [ 2.449729] mmc1: new ultra high speed SDR50 SDHC card at address aaaa >>>>> [ 2.455984] mmcblk0: mmc1:aaaa SL32G 29.7 GiB >>>>> [ 2.461743] mmcblk0: p1 p2 >>>>> >>>>> Which will relate to better read/write speed. >>>> >>>> Which is not an answer to my question. To none of my previous questions. >>>> >>> >>> Basically UHS-I capability (sd-uhs-sdr12, sd-uhs-sdr25, sd-uhs-sdr50, >>> sd-uhs-sdr104) help tune speed supported for mmc >>> >>> I have tired to compare the speed on high speed UHS-I vs ultra high >>> speed UHS-I using izone utility. >>> >>> [ 2.572469] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot >>> req 50000000Hz, actual 50000000HZ div = 0) >>> [ 2.572609] mmc1: new high speed SDHC card at address aaaa >>> >>> Command line used: ./iozone -L64 -S32 -azecwI -+n -r4k -r64k >>> -r128k -s10M -i0 -i1 -i2 -f datafile -Rb out.xls >>> Output is in kBytes/sec >>> Time Resolution = 0.000001 seconds. >>> Processor cache size set to 32 kBytes. >>> Processor cache line size set to 64 bytes. >>> File stride size set to 17 * record size. >>> random >>> random bkwd record stride >>> kB reclen write rewrite read reread read >>> write read rewrite read fwrite frewrite fread >>> freread >>> 10240 4 1631 0 6556 0 5538 982 >>> 10240 64 8828 0 18897 0 17994 303 >>> 10240 128 6269 0 20670 0 20128 1096 >>> --------------------------------------------------------------------------------------------------------- >>> [ 2.613761] mmc_host mmc1: Bus speed (slot 0) = 100000000Hz (slot >>> req 100000000Hz, actual 100000000HZ div = 0) >>> [ 2.623573] mmc1: new ultra high speed SDR50 SDHC card at address aaaa >>> >>> Command line used: ./iozone -L64 -S32 -azecwI -+n -r4k -r64k >>> -r128k -s10M -i0 -i1 -i2 -f datafile -Rb out.xls >>> Output is in kBytes/sec >>> Time Resolution = 0.000001 seconds. >>> Processor cache size set to 32 kBytes. >>> Processor cache line size set to 64 bytes. >>> File stride size set to 17 * record size. >>> random >>> random bkwd record stride >>> kB reclen write rewrite read reread read >>> write read rewrite read fwrite frewrite fread >>> freread >>> 10240 4 1809 0 7507 0 5233 859 >>> 10240 64 11622 0 31250 0 28072 516 >>> 10240 128 4320 0 34417 0 32509 1148 >>> >>> My observation is that their slight increase in read/write operation. >>> >>> Hope I have tried to answer you query. If I am wrong please let me know. >> >> Nope, that did not answer my query. You gave some performance benchmarks >> but my question was not about the speed of anything. The question is >> (once again): >> How do you know that these modes are really supported? >> >> You are marking the *host* as supporting these modes. Please provide >> information that host supports them *really*, not by experimenting "oh, >> it seems to work now, maybe it will work always". >> >> Usually vendors, if their products implement some kind of >> specification/protocol, they mark the products as "compatible with XYZ" etc. > > I found this link from hardkernel website which specify the interface support > > http://www.hardkernel.com/main/products/prdt_info.php?g_code=G141578491347 > > Manufacturer Part Number : Sandisk SDSDQAD-016G > Interface : UHS-1 SDR50 > > I don't know much internal specification of the Odroid XU3/XU4 Boards. > > I am not sure if it will support host will sd-uhs-sdr104, but it will > be compatible for sd-uhs-sdr12, sd-uhs-sdr25, sd-uhs-sdr50. I can't find how this proofs anything. You can sell an UHS-II card labelled "for ODROID-XU3 and XU4" and it will work fine on Odroid-XU3. Does it mean that Odroid-XU3 supports UHS-II? That UHS-II card will work even on 10-year camera! Of course not in UHS mode... Does it mean that this 10-year old camera supports UHS-II? Of course not because it will work in some HS mode (or even pre-HS). You can label any SD card as "for Odroid XU3" because any card will work... Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-10-12 06:40 +0200 |
| Subject | Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card |
| Message-ID | <qiD3X-4YJ-15@gated-at.bofh.it> |
| In reply to | #1244152 |
On 12.10.2015 00:46, Anand Moon wrote:
> From: Jaehoon Chung <jh80.chung@samsung.com>
>
> To detect sd-card use the cd-gpio method.
> It can decrease the interrupt for detecting sd-card.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>
> ---
> Changes based on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v4.4-next/dt-samsung branch
> ---
> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> index 1af5bdc..26decbd 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -352,8 +352,10 @@
> samsung,dw-mshc-ciu-div = <3>;
> samsung,dw-mshc-sdr-timing = <0 4>;
> samsung,dw-mshc-ddr-timing = <0 2>;
> + cd-gpios = <&gpc2 2 GPIO_ACTIVE_HIGH>;
> + cd-inverted;
> pinctrl-names = "default";
> - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>;
> + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
Anand,
You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0]
pad correctly for Exynos5420 boards"). Why? There is no explanation in
the commit message about this.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| Date | 2015-10-12 06:50 +0200 |
| Subject | Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card |
| Message-ID | <qiDdD-5b7-1@gated-at.bofh.it> |
| In reply to | #1244381 |
Hi,
On 10/12/2015 01:29 PM, Krzysztof Kozlowski wrote:
> On 12.10.2015 00:46, Anand Moon wrote:
>> From: Jaehoon Chung <jh80.chung@samsung.com>
>>
>> To detect sd-card use the cd-gpio method.
>> It can decrease the interrupt for detecting sd-card.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>
>> ---
>> Changes based on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v4.4-next/dt-samsung branch
>> ---
>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> index 1af5bdc..26decbd 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> @@ -352,8 +352,10 @@
>> samsung,dw-mshc-ciu-div = <3>;
>> samsung,dw-mshc-sdr-timing = <0 4>;
>> samsung,dw-mshc-ddr-timing = <0 2>;
>> + cd-gpios = <&gpc2 2 GPIO_ACTIVE_HIGH>;
>> + cd-inverted;
>> pinctrl-names = "default";
>> - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>;
>> + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
Don't do change this.
>
> Anand,
>
> You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0]
> pad correctly for Exynos5420 boards"). Why? There is no explanation in
> the commit message about this.
I don't remember to send the patch relevant to this. Hmm...
Well, Is this patch really signed-off by me?
Best Regards,
Jaehoon Chung
>
> Best regards,
> Krzysztof
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-10-13 02:20 +0200 |
| Subject | Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card |
| Message-ID | <qiVtU-6CR-7@gated-at.bofh.it> |
| In reply to | #1244382 |
On 12.10.2015 23:47, Anand Moon wrote:
>>
>> Anand,
>>
>> You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0]
>> pad correctly for Exynos5420 boards"). Why? There is no explanation in
>> the commit message about this.
>
> I don't remember to send the patch relevant to this. Hmm...
> Well, Is this patch really signed-off by me?
>
> Best Regards,
>
> Jaehoon Chung
>>
>> Best regards,
>> Krzysztof
>>
>
>>
>
>
> Some how I don't receive these mail on my email id.
>
> I have picked up these changes from tizen repository for OdroidXU3.
> I have tested with this changes to detect UHS-I micro cd cards.
> That's the reason for this email.
... and you applied it blindly without looking at actual existing
contents and at previous commits.
That is not how patches from different repositories should be cherry picked.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| Date | 2015-10-13 04:10 +0200 |
| Subject | Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card |
| Message-ID | <qiXcm-GI-3@gated-at.bofh.it> |
| In reply to | #1245224 |
Dear, Anand.
On 10/13/2015 09:12 AM, Krzysztof Kozlowski wrote:
> On 12.10.2015 23:47, Anand Moon wrote:
>>>
>>> Anand,
>>>
>>> You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0]
>>> pad correctly for Exynos5420 boards"). Why? There is no explanation in
>>> the commit message about this.
>>
>> I don't remember to send the patch relevant to this. Hmm...
>> Well, Is this patch really signed-off by me?
>>
>> Best Regards,
>>
>> Jaehoon Chung
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>>>
>>
>>
>> Some how I don't receive these mail on my email id.
>>
>> I have picked up these changes from tizen repository for OdroidXU3.
>> I have tested with this changes to detect UHS-I micro cd cards.
>> That's the reason for this email.
It seems to make manually, right?
I have checked the tizen repository.
The below is
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -335,7 +335,9 @@
samsung,dw-mshc-sdr-timing = <0 4>;
samsung,dw-mshc-ddr-timing = <0 2>;
pinctrl-names = "default";
- pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>;
+ cd-gpios = <&gpc2 2 0>;
+ cd-inverted;
+ pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus1 &sd2_bus4>;
bus-width = <4>;
cap-sd-highspeed;
};
Yours
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -352,8 +352,10 @@
samsung,dw-mshc-ciu-div = <3>;
samsung,dw-mshc-sdr-timing = <0 4>;
samsung,dw-mshc-ddr-timing = <0 2>;
+ cd-gpios = <&gpc2 2 GPIO_ACTIVE_HIGH>;
+ cd-inverted;
pinctrl-names = "default";
- pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>;
+ pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
Did you know what differ? :)
Best Regards,
Jaehoon Chung
>
> ... and you applied it blindly without looking at actual existing
> contents and at previous commits.
>
> That is not how patches from different repositories should be cherry picked.
>
> Best regards,
> Krzysztof
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Anand Moon <linux.amoon@gmail.com> |
|---|---|
| Date | 2015-10-13 05:30 +0200 |
| Subject | Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card |
| Message-ID | <qiYrL-2vS-5@gated-at.bofh.it> |
| In reply to | #1245282 |
Hi Jaehoon Chung,
On 13 October 2015 at 07:36, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Dear, Anand.
>
>
> On 10/13/2015 09:12 AM, Krzysztof Kozlowski wrote:
>> On 12.10.2015 23:47, Anand Moon wrote:
>>>>
>>>> Anand,
>>>>
>>>> You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0]
>>>> pad correctly for Exynos5420 boards"). Why? There is no explanation in
>>>> the commit message about this.
>>>
>>> I don't remember to send the patch relevant to this. Hmm...
>>> Well, Is this patch really signed-off by me?
>>>
>>> Best Regards,
>>>
>>> Jaehoon Chung
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>>
>>>>
>>>
>>>
>>> Some how I don't receive these mail on my email id.
>>>
>>> I have picked up these changes from tizen repository for OdroidXU3.
>>> I have tested with this changes to detect UHS-I micro cd cards.
>>> That's the reason for this email.
>
> It seems to make manually, right?
> I have checked the tizen repository.
>
> The below is
>
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -335,7 +335,9 @@
> samsung,dw-mshc-sdr-timing = <0 4>;
> samsung,dw-mshc-ddr-timing = <0 2>;
> pinctrl-names = "default";
> - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>;
> + cd-gpios = <&gpc2 2 0>;
> + cd-inverted;
> + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus1 &sd2_bus4>;
> bus-width = <4>;
> cap-sd-highspeed;
> };
>
>
>
> Yours
>
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -352,8 +352,10 @@
> samsung,dw-mshc-ciu-div = <3>;
> samsung,dw-mshc-sdr-timing = <0 4>;
> samsung,dw-mshc-ddr-timing = <0 2>;
> + cd-gpios = <&gpc2 2 GPIO_ACTIVE_HIGH>;
> + cd-inverted;
> pinctrl-names = "default";
> - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>;
> + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
>
> Did you know what differ? :)
>
My mistake, I will drop the changes. Sorry for the whole mess.
-Anand Moon
> Best Regards,
> Jaehoon Chung
>
>>
>> ... and you applied it blindly without looking at actual existing
>> contents and at previous commits.
>>
>> That is not how patches from different repositories should be cherry picked.
>>
>> Best regards,
>> Krzysztof
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Anand Moon <linux.amoon@gmail.com> |
|---|---|
| Date | 2015-10-13 06:10 +0200 |
| Subject | Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card |
| Message-ID | <qiZ4t-3w3-7@gated-at.bofh.it> |
| In reply to | #1245282 |
Hi Jaehoon,
On 13 October 2015 at 07:36, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Dear, Anand.
>
>
> On 10/13/2015 09:12 AM, Krzysztof Kozlowski wrote:
>> On 12.10.2015 23:47, Anand Moon wrote:
>>>>
>>>> Anand,
>>>>
>>>> You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0]
>>>> pad correctly for Exynos5420 boards"). Why? There is no explanation in
>>>> the commit message about this.
>>>
>>> I don't remember to send the patch relevant to this. Hmm...
>>> Well, Is this patch really signed-off by me?
>>>
>>> Best Regards,
>>>
>>> Jaehoon Chung
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>>
>>>>
>>>
>>>
>>> Some how I don't receive these mail on my email id.
>>>
>>> I have picked up these changes from tizen repository for OdroidXU3.
>>> I have tested with this changes to detect UHS-I micro cd cards.
>>> That's the reason for this email.
>
> It seems to make manually, right?
> I have checked the tizen repository.
>
> The below is
>
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -335,7 +335,9 @@
> samsung,dw-mshc-sdr-timing = <0 4>;
> samsung,dw-mshc-ddr-timing = <0 2>;
> pinctrl-names = "default";
> - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>;
> + cd-gpios = <&gpc2 2 0>;
> + cd-inverted;
> + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus1 &sd2_bus4>;
> bus-width = <4>;
> cap-sd-highspeed;
> };
>
>
>
> Yours
>
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -352,8 +352,10 @@
> samsung,dw-mshc-ciu-div = <3>;
> samsung,dw-mshc-sdr-timing = <0 4>;
> samsung,dw-mshc-ddr-timing = <0 2>;
> + cd-gpios = <&gpc2 2 GPIO_ACTIVE_HIGH>;
> + cd-inverted;
> pinctrl-names = "default";
> - pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>;
> + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
>
> Did you know what differ? :)
>
> Best Regards,
> Jaehoon Chung
>
>>
>> ... and you applied it blindly without looking at actual existing
>> contents and at previous commits.
>>
>> That is not how patches from different repositories should be cherry picked.
>>
>> Best regards,
>> Krzysztof
>>
>>
>
Looks like my changes have introduce another bug so please ignore this changes.
-Anand Moon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Anand Moon <linux.amoon@gmail.com> |
|---|---|
| Date | 2015-10-13 04:50 +0200 |
| Subject | Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card |
| Message-ID | <qiXP4-1wY-11@gated-at.bofh.it> |
| In reply to | #1245224 |
Hi Krzysztof,
On 13 October 2015 at 05:42, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> On 12.10.2015 23:47, Anand Moon wrote:
>>>
>>> Anand,
>>>
>>> You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0]
>>> pad correctly for Exynos5420 boards"). Why? There is no explanation in
>>> the commit message about this.
>>
>> I don't remember to send the patch relevant to this. Hmm...
>> Well, Is this patch really signed-off by me?
>>
>> Best Regards,
>>
>> Jaehoon Chung
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>>>
>>
>>
>> Some how I don't receive these mail on my email id.
>>
>> I have picked up these changes from tizen repository for OdroidXU3.
>> I have tested with this changes to detect UHS-I micro cd cards.
>> That's the reason for this email.
>
> ... and you applied it blindly without looking at actual existing
> contents and at previous commits.
>
> That is not how patches from different repositories should be cherry picked.
Sorry But I did not change it right way. By looking at the diff.
If the changes are wrong I will drop that changes.
I have to dig in my logs to find out why I have changes this setting.
Here is the log below, I will check If I am able to reproduce this bug
in the current kernel.
Sorry for the mess I have created.
---------------------------------------------------------------------------------------
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559940]
======================================================
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559943] [ INFO: possible
circular locking dependency detected ]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559947] 4.2.0-xu4hkdn #7 Not tainted
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559950]
-------------------------------------------------------
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559954] swapper/0/1 is trying
to acquire lock:
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559972]
(&map->mutex){+.+...}, at: [<c04a9414>] regmap_lock_mutex+0x1c/0x20
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559975]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559975] but task is already
holding lock:
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559987]
(prepare_lock){+.+.+.}, at: [<c05b468c>] clk_prepare_lock+0x20/0x108
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559990]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559990] which lock already
depends on the new lock.
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559990]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559993]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.559993] the existing
dependency chain (in reverse order) is:
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560004]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560004] -> #1 (prepare_lock){+.+.+.}:
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560019] [<c06b90d0>]
mutex_lock_nested+0x84/0x4e4
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560026] [<c05b46cc>]
clk_prepare_lock+0x60/0x108
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560033] [<c05b84a8>]
clk_unprepare+0x28/0x38
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560044] [<c0542ba8>]
exynos5_i2c_xfer+0x2dc/0x3a4
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560051] [<c053e1b4>]
__i2c_transfer+0x160/0xc60
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560057] [<c053ed28>]
i2c_transfer+0x74/0xa0
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560065] [<c04b2be4>]
regmap_i2c_read+0x58/0x74
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560072] [<c04ac38c>]
_regmap_raw_read+0x130/0x654
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560078] [<c04ac8e4>]
_regmap_bus_read+0x34/0x6c
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560083] [<c04ab350>]
_regmap_read+0x7c/0x350
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560090] [<c04ab674>]
regmap_read+0x50/0x70
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560100] [<c04043a0>]
regulator_is_enabled_regmap+0x30/0xa4
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560107] [<c03ff73c>]
_regulator_is_enabled.part.10+0x2c/0x38
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560113] [<c04000c4>]
_regulator_do_set_voltage+0x720/0x9d0
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560119] [<c0400438>]
regulator_set_voltage+0xc4/0x150
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560129] [<c0589d6c>]
dw_mci_switch_voltage+0x98/0xbc
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560136] [<c0570dc0>]
mmc_power_up.part.16+0x6c/0x108
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560143] [<c0571e44>]
mmc_start_host+0x54/0x78
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560149] [<c0573194>]
mmc_add_host+0x6c/0x90
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560156] [<c058ae84>]
dw_mci_probe+0x660/0xc98
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560162] [<c058c978>]
dw_mci_pltfm_register+0x9c/0xa8
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560168] [<c058d014>]
dw_mci_exynos_probe+0x30/0x38
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560176] [<c048de40>]
platform_drv_probe+0x54/0xb4
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560183] [<c048b9d8>]
driver_probe_device+0x184/0x2c0
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560189] [<c048bbb8>]
__driver_attach+0xa4/0xa8
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560195] [<c0489b90>]
bus_for_each_dev+0x78/0xac
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560202] [<c048b498>]
driver_attach+0x2c/0x30
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560208] [<c048b0a4>]
bus_add_driver+0x1b0/0x228
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560214] [<c048ce6c>]
driver_register+0x88/0x108
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560221] [<c048dd6c>]
__platform_driver_register+0x64/0x6c
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560229] [<c0995abc>]
dw_mci_exynos_pltfm_driver_init+0x1c/0x20
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560237] [<c0009820>]
do_one_initcall+0x9c/0x1e8
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560245] [<c095efa8>]
kernel_init_freeable+0x250/0x2f4
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560252] [<c06b3774>]
kernel_init+0x1c/0xf8
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560259] [<c000fe58>]
ret_from_fork+0x14/0x3c
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560269]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560269] -> #0 (&map->mutex){+.+...}:
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560277] [<c008ac00>]
lock_acquire+0x128/0x378
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560284] [<c06b90d0>]
mutex_lock_nested+0x84/0x4e4
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560290] [<c04a9414>]
regmap_lock_mutex+0x1c/0x20
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560296] [<c04ab664>]
regmap_read+0x40/0x70
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560304] [<c05bd62c>]
s2mps11_clk_is_prepared+0x30/0x4c
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560310] [<c05b4bc8>]
clk_unprepare_unused_subtree+0x84/0x564
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560316] [<c05b7940>]
clk_disable_unused+0xb8/0x148
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560322] [<c0009820>]
do_one_initcall+0x9c/0x1e8
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560328] [<c095efa8>]
kernel_init_freeable+0x250/0x2f4
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560334] [<c06b3774>]
kernel_init+0x1c/0xf8
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560340] [<c000fe58>]
ret_from_fork+0x14/0x3c
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560343]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560343] other info that might
help us debug this:
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560343]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560346] Possible unsafe
locking scenario:
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560346]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560349] CPU0
CPU1
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560351] ----
----
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560358] lock(prepare_lock);
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560365]
lock(&map->mutex);
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560371]
lock(prepare_lock);
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560378] lock(&map->mutex);
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560380]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560380] *** DEADLOCK ***
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560380]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560384] 1 lock held by swapper/0/1:
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560397] #0:
(prepare_lock){+.+.+.}, at: [<c05b468c>] clk_prepare_lock+0x20/0x108
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560400]
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560400] stack backtrace:
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560405] CPU: 2 PID: 1 Comm:
swapper/0 Not tainted 4.2.0-xu4hkdn #7
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560408] Hardware name:
SAMSUNG EXYNOS (Flattened Device Tree)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560418] [<c00189bc>]
(unwind_backtrace) from [<c0014608>] (show_stack+0x20/0x24)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560424] [<c0014608>]
(show_stack) from [<c06b64f8>] (dump_stack+0x8c/0xcc)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560430] [<c06b64f8>]
(dump_stack) from [<c0083c34>] (print_circular_bug+0x218/0x340)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560436] [<c0083c34>]
(print_circular_bug) from [<c0089d14>] (__lock_acquire+0x1c40/0x227c)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560441] [<c0089d14>]
(__lock_acquire) from [<c008ac00>] (lock_acquire+0x128/0x378)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560447] [<c008ac00>]
(lock_acquire) from [<c06b90d0>] (mutex_lock_nested+0x84/0x4e4)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560453] [<c06b90d0>]
(mutex_lock_nested) from [<c04a9414>] (regmap_lock_mutex+0x1c/0x20)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560458] [<c04a9414>]
(regmap_lock_mutex) from [<c04ab664>] (regmap_read+0x40/0x70)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560464] [<c04ab664>]
(regmap_read) from [<c05bd62c>] (s2mps11_clk_is_prepared+0x30/0x4c)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560471] [<c05bd62c>]
(s2mps11_clk_is_prepared) from [<c05b4bc8>]
(clk_unprepare_unused_subtree+0x84/0x564)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560477] [<c05b4bc8>]
(clk_unprepare_unused_subtree) from [<c05b7940>]
(clk_disable_unused+0xb8/0x148)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560482] [<c05b7940>]
(clk_disable_unused) from [<c0009820>] (do_one_initcall+0x9c/0x1e8)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560487] [<c0009820>]
(do_one_initcall) from [<c095efa8>] (kernel_init_freeable+0x250/0x2f4)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560493] [<c095efa8>]
(kernel_init_freeable) from [<c06b3774>] (kernel_init+0x1c/0xf8)
Oct 6 08:23:21 odroidxu4 kernel: [ 6.560498] [<c06b3774>]
(kernel_init) from [<c000fe58>] (ret_from_fork+0x14/0x3c)
-Anand Moon
>
> Best regards,
> Krzysztof
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Page 2 of 2 — ← Prev page 1 [2]
Back to top | Article view | linux.kernel
csiph-web