Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1245282
| From | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card |
| Date | 2015-10-13 04:10 +0200 |
| Message-ID | <qiXcm-GI-3@gated-at.bofh.it> (permalink) |
| References | <qir2N-4ja-5@gated-at.bofh.it> <qiD3X-4YJ-15@gated-at.bofh.it> <qiDdD-5b7-1@gated-at.bofh.it> <qiVtU-6CR-9@gated-at.bofh.it> <qiVtU-6CR-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Dear, Anand.
On 10/13/2015 09:12 AM, Krzysztof Kozlowski wrote:
> On 12.10.2015 23:47, Anand Moon wrote:
>>>
>>> Anand,
>>>
>>> You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0]
>>> pad correctly for Exynos5420 boards"). Why? There is no explanation in
>>> the commit message about this.
>>
>> I don't remember to send the patch relevant to this. Hmm...
>> Well, Is this patch really signed-off by me?
>>
>> Best Regards,
>>
>> Jaehoon Chung
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>>>
>>
>>
>> Some how I don't receive these mail on my email id.
>>
>> I have picked up these changes from tizen repository for OdroidXU3.
>> I have tested with this changes to detect UHS-I micro cd cards.
>> That's the reason for this email.
It seems to make manually, right?
I have checked the tizen repository.
The below is
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -335,7 +335,9 @@
samsung,dw-mshc-sdr-timing = <0 4>;
samsung,dw-mshc-ddr-timing = <0 2>;
pinctrl-names = "default";
- pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>;
+ cd-gpios = <&gpc2 2 0>;
+ cd-inverted;
+ pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus1 &sd2_bus4>;
bus-width = <4>;
cap-sd-highspeed;
};
Yours
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -352,8 +352,10 @@
samsung,dw-mshc-ciu-div = <3>;
samsung,dw-mshc-sdr-timing = <0 4>;
samsung,dw-mshc-ddr-timing = <0 2>;
+ cd-gpios = <&gpc2 2 GPIO_ACTIVE_HIGH>;
+ cd-inverted;
pinctrl-names = "default";
- pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>;
+ pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
Did you know what differ? :)
Best Regards,
Jaehoon Chung
>
> ... and you applied it blindly without looking at actual existing
> contents and at previous commits.
>
> That is not how patches from different repositories should be cherry picked.
>
> Best regards,
> Krzysztof
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Anand Moon <linux.amoon@gmail.com> - 2015-10-11 17:50 +0200
[PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-11 17:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-12 07:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-12 12:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Jaehoon Chung <jh80.chung@samsung.com> - 2015-10-12 13:00 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-12 13:30 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-12 14:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Jaehoon Chung <jh80.chung@samsung.com> - 2015-10-12 15:10 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-12 15:20 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Jaehoon Chung <jh80.chung@samsung.com> - 2015-10-13 04:30 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-12 17:40 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-13 02:20 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-13 05:10 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-13 05:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-13 05:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-13 18:30 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-14 02:10 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Alim Akhtar <alim.akhtar@gmail.com> - 2015-10-14 03:10 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-14 03:20 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Jaehoon Chung <jh80.chung@samsung.com> - 2015-10-14 03:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-14 04:00 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Alim Akhtar <alim.akhtar@gmail.com> - 2015-10-14 04:10 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Alim Akhtar <alim.akhtar@gmail.com> - 2015-10-14 04:20 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Alim Akhtar <alim.akhtar@gmail.com> - 2015-10-14 04:30 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-14 04:30 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Doug Anderson <dianders@chromium.org> - 2015-10-15 00:50 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon <linux.amoon@gmail.com> - 2015-10-14 06:00 +0200
Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-14 06:20 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-12 06:40 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Jaehoon Chung <jh80.chung@samsung.com> - 2015-10-12 06:50 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-13 02:20 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Jaehoon Chung <jh80.chung@samsung.com> - 2015-10-13 04:10 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Anand Moon <linux.amoon@gmail.com> - 2015-10-13 05:30 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Anand Moon <linux.amoon@gmail.com> - 2015-10-13 06:10 +0200
Re: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Anand Moon <linux.amoon@gmail.com> - 2015-10-13 04:50 +0200
csiph-web