Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245531 > unrolled thread

[PATCH] MAINTAINERS: fix entry of char/misc

Back to article view | Back to linux.kernel

Contents

  [PATCH] MAINTAINERS: fix entry of char/misc Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-13 12:10 +0200
    Re: [PATCH] MAINTAINERS: fix entry of char/misc Joe Perches <joe@perches.com> - 2015-10-13 16:50 +0200
      Re: [PATCH] MAINTAINERS: fix entry of char/misc Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-13 19:20 +0200
        Re: [PATCH] MAINTAINERS: fix entry of char/misc Joe Perches <joe@perches.com> - 2015-10-13 19:40 +0200
        Re: [PATCH] MAINTAINERS: fix entry of char/misc Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-13 19:50 +0200
          Re: [PATCH] MAINTAINERS: fix entry of char/misc Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-14 06:50 +0200

#1245531 — [PATCH] MAINTAINERS: fix entry of char/misc

Greg and Arnd are supporter of char and misc drivers. While using
getmaintainer.pl on any patch or any file in these directories their
names were never displayed.
And for this reason quite a few patches for these char and misc have
never been picked up as they never had Greg or Arnd in To or Cc.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

I personally faced this multiple times and faced again just now while
sending another patch for misc. Greg can also confirm about the missing
patches. But this maybe a problem with getmaintainer.pl file also.
So adding Joe Perches to Cc list.

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 21348d8..a8a1676 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2698,8 +2698,8 @@ M:	Arnd Bergmann <arnd@arndb.de>
 M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
 S:	Supported
-F:	drivers/char/*
-F:	drivers/misc/*
+F:	drivers/char/
+F:	drivers/misc/
 F:	include/linux/miscdevice.h
 
 CHECKPATCH
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1245797

On Tue, 2015-10-13 at 15:34 +0530, Sudip Mukherjee wrote:
> Greg and Arnd are supporter of char and misc drivers. While using
> getmaintainer.pl on any patch or any file in these directories their
> names were never displayed.
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
>  M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
>  S:	Supported
> -F:	drivers/char/*
> -F:	drivers/misc/*
> +F:	drivers/char/
> +F:	drivers/misc/
>  F:	include/linux/miscdevice.h

Do Greg and Arnd really want to be supporting all
subsystems below drivers/char like agp and xillybus?




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245929

On Tue, Oct 13, 2015 at 07:48:05AM -0700, Joe Perches wrote:
> On Tue, 2015-10-13 at 15:34 +0530, Sudip Mukherjee wrote:
> > Greg and Arnd are supporter of char and misc drivers. While using
> > getmaintainer.pl on any patch or any file in these directories their
> > names were never displayed.
> []
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> >  M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> >  S:	Supported
> > -F:	drivers/char/*
> > -F:	drivers/misc/*
> > +F:	drivers/char/
> > +F:	drivers/misc/
> >  F:	include/linux/miscdevice.h
> 
> Do Greg and Arnd really want to be supporting all
> subsystems below drivers/char like agp and xillybus?

I don't know that. Maybe Greg and Arnd can say.
But wasn't that the intention when char/* and misc/* was mentioned here?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245959

On Tue, 2015-10-13 at 22:49 +0530, Sudip Mukherjee wrote:
> On Tue, Oct 13, 2015 at 07:48:05AM -0700, Joe Perches wrote:
> > On Tue, 2015-10-13 at 15:34 +0530, Sudip Mukherjee wrote:
> > > Greg and Arnd are supporter of char and misc drivers. While using
> > > getmaintainer.pl on any patch or any file in these directories their
> > > names were never displayed.
> > []
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > []
> > >  M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > >  S:	Supported
> > > -F:	drivers/char/*
> > > -F:	drivers/misc/*
> > > +F:	drivers/char/
> > > +F:	drivers/misc/
> > >  F:	include/linux/miscdevice.h
> > 
> > Do Greg and Arnd really want to be supporting all
> > subsystems below drivers/char like agp and xillybus?
> 
> I don't know that. Maybe Greg and Arnd can say.
> But wasn't that the intention when char/* *nd misc/* was mentioned here?

No.

It was specific to files that are only in the top level
directories drivers/char/ and drivers/misc/ but not any
files in directories below those.

There should be some difference between S: uses for
some of the char and misc bits.

Besides, as commit 46e642614b36 shows, Greg and Arnd are
self-described fools...

Still, it may be sensible have 2 MAINTAINERS sections like:

CHAR and MISC CORE
M:	Arnd Bergmann <arnd@arndb.de>
M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S:	Supported
F:	drivers/char/*
F:	drivers/misc/*
F:	include/linux/miscdevice.h

CHAR and MISC DRIVERS
M:	Arnd Bergmann <arnd@arndb.de>
M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S:	Odd fixes
F:	drivers/char/
F:	drivers/misc/

but maybe there should be some exclusions in the
drivers block like:

X:	drivers/char/hw_random/
X:	drivers/char/ipmi/

and probably some others.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245979

On Tue, Oct 13, 2015 at 10:49:24PM +0530, Sudip Mukherjee wrote:
> On Tue, Oct 13, 2015 at 07:48:05AM -0700, Joe Perches wrote:
> > On Tue, 2015-10-13 at 15:34 +0530, Sudip Mukherjee wrote:
> > > Greg and Arnd are supporter of char and misc drivers. While using
> > > getmaintainer.pl on any patch or any file in these directories their
> > > names were never displayed.
> > []
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > []
> > >  M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > >  S:	Supported
> > > -F:	drivers/char/*
> > > -F:	drivers/misc/*
> > > +F:	drivers/char/
> > > +F:	drivers/misc/
> > >  F:	include/linux/miscdevice.h
> > 
> > Do Greg and Arnd really want to be supporting all
> > subsystems below drivers/char like agp and xillybus?
> 
> I don't know that. Maybe Greg and Arnd can say.
> But wasn't that the intention when char/* and misc/* was mentioned here?

Kind of, I'm here to pick up the portions of this tree that do not have
a maintainer already (random.c is one example.)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1246298

On Tue, Oct 13, 2015 at 10:39:47AM -0700, Greg Kroah-Hartman wrote:
> On Tue, Oct 13, 2015 at 10:49:24PM +0530, Sudip Mukherjee wrote:
> > On Tue, Oct 13, 2015 at 07:48:05AM -0700, Joe Perches wrote:
> > > On Tue, 2015-10-13 at 15:34 +0530, Sudip Mukherjee wrote:
> > > > Greg and Arnd are supporter of char and misc drivers. While using
> > > > getmaintainer.pl on any patch or any file in these directories their
> > > > names were never displayed.
> > > []
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > []
> > > >  M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > > >  S:	Supported
> > > > -F:	drivers/char/*
> > > > -F:	drivers/misc/*
> > > > +F:	drivers/char/
> > > > +F:	drivers/misc/
> > > >  F:	include/linux/miscdevice.h
> > > 
> > > Do Greg and Arnd really want to be supporting all
> > > subsystems below drivers/char like agp and xillybus?
> > 
> > I don't know that. Maybe Greg and Arnd can say.
> > But wasn't that the intention when char/* and misc/* was mentioned here?
> 
> Kind of, I'm here to pick up the portions of this tree that do not have
> a maintainer already (random.c is one example.)

Then what about the ones that has a maintainer? I had specifically
sgi-gru in mind when I made this patch. I hope you remember the issue
that I pointed out when i sent some patches for that.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web