Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245959

Re: [PATCH] MAINTAINERS: fix entry of char/misc

Show all headers | View raw

On Tue, 2015-10-13 at 22:49 +0530, Sudip Mukherjee wrote:
> On Tue, Oct 13, 2015 at 07:48:05AM -0700, Joe Perches wrote:
> > On Tue, 2015-10-13 at 15:34 +0530, Sudip Mukherjee wrote:
> > > Greg and Arnd are supporter of char and misc drivers. While using
> > > getmaintainer.pl on any patch or any file in these directories their
> > > names were never displayed.
> > []
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > []
> > >  M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > >  S:	Supported
> > > -F:	drivers/char/*
> > > -F:	drivers/misc/*
> > > +F:	drivers/char/
> > > +F:	drivers/misc/
> > >  F:	include/linux/miscdevice.h
> > 
> > Do Greg and Arnd really want to be supporting all
> > subsystems below drivers/char like agp and xillybus?
> 
> I don't know that. Maybe Greg and Arnd can say.
> But wasn't that the intention when char/* *nd misc/* was mentioned here?

No.

It was specific to files that are only in the top level
directories drivers/char/ and drivers/misc/ but not any
files in directories below those.

There should be some difference between S: uses for
some of the char and misc bits.

Besides, as commit 46e642614b36 shows, Greg and Arnd are
self-described fools...

Still, it may be sensible have 2 MAINTAINERS sections like:

CHAR and MISC CORE
M:	Arnd Bergmann <arnd@arndb.de>
M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S:	Supported
F:	drivers/char/*
F:	drivers/misc/*
F:	include/linux/miscdevice.h

CHAR and MISC DRIVERS
M:	Arnd Bergmann <arnd@arndb.de>
M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S:	Odd fixes
F:	drivers/char/
F:	drivers/misc/

but maybe there should be some exclusions in the
drivers block like:

X:	drivers/char/hw_random/
X:	drivers/char/ipmi/

and probably some others.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] MAINTAINERS: fix entry of char/misc Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-13 12:10 +0200
  Re: [PATCH] MAINTAINERS: fix entry of char/misc Joe Perches <joe@perches.com> - 2015-10-13 16:50 +0200
    Re: [PATCH] MAINTAINERS: fix entry of char/misc Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-13 19:20 +0200
      Re: [PATCH] MAINTAINERS: fix entry of char/misc Joe Perches <joe@perches.com> - 2015-10-13 19:40 +0200
      Re: [PATCH] MAINTAINERS: fix entry of char/misc Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-13 19:50 +0200
        Re: [PATCH] MAINTAINERS: fix entry of char/misc Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-14 06:50 +0200

csiph-web