Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1247926 > unrolled thread

Re: [PATCH v3 1/2] ACPI / tables: simplify acpi_parse_entries

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 1/2] ACPI / tables: simplify acpi_parse_entries Sudeep Holla <sudeep.holla@arm.com> - 2015-10-15 17:50 +0200
    Re: [PATCH v3 1/2] ACPI / tables: simplify acpi_parse_entries Al Stone <al.stone@linaro.org> - 2015-10-15 18:00 +0200
      Re: [PATCH v3 1/2] ACPI / tables: simplify acpi_parse_entries "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-15 23:10 +0200

#1247926 — Re: [PATCH v3 1/2] ACPI / tables: simplify acpi_parse_entries

Hi Rafael,

On 01/10/15 16:11, Sudeep Holla wrote:
> acpi_parse_entries passes the table end pointer to the sub-table entry
> handler. acpi_parse_entries itself could validate the end of an entry
> against the table end using the length in the sub-table entry.
>
> This patch adds the validation of the sub-table entry end using the
> length field.This will help to eliminate the need to pass the table end
> to the handlers.
>
> It also moves the check for zero length entry early so that execution of
> the handler can be avoided.
>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>

Now that Al's MADT is queued, can you consider applying these ?

-- 
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1247929

On 10/15/2015 09:44 AM, Sudeep Holla wrote:
> Hi Rafael,
> 
> On 01/10/15 16:11, Sudeep Holla wrote:
>> acpi_parse_entries passes the table end pointer to the sub-table entry
>> handler. acpi_parse_entries itself could validate the end of an entry
>> against the table end using the length in the sub-table entry.
>>
>> This patch adds the validation of the sub-table entry end using the
>> length field.This will help to eliminate the need to pass the table end
>> to the handlers.
>>
>> It also moves the check for zero length entry early so that execution of
>> the handler can be avoided.
>>
>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> 
> Now that Al's MADT is queued, can you consider applying these ?
> 

I think we have to remove my patches from the queue until I can make
them arch-specific; doing these MADT checks breaks far too many existing
x86 systems where the firmware does things it should not; re-reading some
of the ia64 kernel code, there's a pathological case there where it could
break (but shouldn't if iasl is being used to compile tables).  I'll be
working on the new version today.

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone@linaro.org
-----------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1248178

On Thursday, October 15, 2015 09:57:38 AM Al Stone wrote:
> On 10/15/2015 09:44 AM, Sudeep Holla wrote:
> > Hi Rafael,
> > 
> > On 01/10/15 16:11, Sudeep Holla wrote:
> >> acpi_parse_entries passes the table end pointer to the sub-table entry
> >> handler. acpi_parse_entries itself could validate the end of an entry
> >> against the table end using the length in the sub-table entry.
> >>
> >> This patch adds the validation of the sub-table entry end using the
> >> length field.This will help to eliminate the need to pass the table end
> >> to the handlers.
> >>
> >> It also moves the check for zero length entry early so that execution of
> >> the handler can be avoided.
> >>
> >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > 
> > Now that Al's MADT is queued, can you consider applying these ?
> > 
> 
> I think we have to remove my patches from the queue until I can make
> them arch-specific; doing these MADT checks breaks far too many existing
> x86 systems where the firmware does things it should not;

Right.  I've dropped the series already.

> re-reading some of the ia64 kernel code, there's a pathological case there
> where it could break (but shouldn't if iasl is being used to compile tables).

I wouldn't count on iasl being used.

> I'll be working on the new version today.

Thanks!

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web