Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1247929
| From | Al Stone <al.stone@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 1/2] ACPI / tables: simplify acpi_parse_entries |
| Date | 2015-10-15 18:00 +0200 |
| Message-ID | <qjT6G-2yx-7@gated-at.bofh.it> (permalink) |
| References | <q9ktA-4U2-13@gated-at.bofh.it> <qeNOi-8mD-17@gated-at.bofh.it> <qjSX2-2mu-49@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/15/2015 09:44 AM, Sudeep Holla wrote: > Hi Rafael, > > On 01/10/15 16:11, Sudeep Holla wrote: >> acpi_parse_entries passes the table end pointer to the sub-table entry >> handler. acpi_parse_entries itself could validate the end of an entry >> against the table end using the length in the sub-table entry. >> >> This patch adds the validation of the sub-table entry end using the >> length field.This will help to eliminate the need to pass the table end >> to the handlers. >> >> It also moves the check for zero length entry early so that execution of >> the handler can be avoided. >> >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > Now that Al's MADT is queued, can you consider applying these ? > I think we have to remove my patches from the queue until I can make them arch-specific; doing these MADT checks breaks far too many existing x86 systems where the firmware does things it should not; re-reading some of the ia64 kernel code, there's a pathological case there where it could break (but shouldn't if iasl is being used to compile tables). I'll be working on the new version today. -- ciao, al ----------------------------------- Al Stone Software Engineer Linaro Enterprise Group al.stone@linaro.org ----------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3 1/2] ACPI / tables: simplify acpi_parse_entries Sudeep Holla <sudeep.holla@arm.com> - 2015-10-15 17:50 +0200
Re: [PATCH v3 1/2] ACPI / tables: simplify acpi_parse_entries Al Stone <al.stone@linaro.org> - 2015-10-15 18:00 +0200
Re: [PATCH v3 1/2] ACPI / tables: simplify acpi_parse_entries "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-15 23:10 +0200
csiph-web