Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1242614 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2015-10-08 19:10 +0200 |
| Last post | 2015-10-09 18:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] dmaengine: zxdma: fix memset that is currently doing nothing Colin King <colin.king@canonical.com> - 2015-10-08 19:10 +0200
Re: [PATCH] dmaengine: zxdma: fix memset that is currently doing nothing Vinod Koul <vinod.koul@intel.com> - 2015-10-09 18:00 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2015-10-08 19:10 +0200 |
| Subject | [PATCH] dmaengine: zxdma: fix memset that is currently doing nothing |
| Message-ID | <qhmRA-1ld-1@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com> The size and value arguments are swapped in the call to memset effectively making it a no-op because of the zero size. Swap these arguments around to do the memset correctly. Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/dma/zx296702_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/zx296702_dma.c b/drivers/dma/zx296702_dma.c index c017fcd..245d759 100644 --- a/drivers/dma/zx296702_dma.c +++ b/drivers/dma/zx296702_dma.c @@ -441,7 +441,7 @@ static struct zx_dma_desc_sw *zx_alloc_desc_resource(int num, kfree(ds); return NULL; } - memset(ds->desc_hw, sizeof(struct zx_desc_hw) * num, 0); + memset(ds->desc_hw, 0, sizeof(struct zx_desc_hw) * num); ds->desc_num = num; return ds; } -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Date | 2015-10-09 18:00 +0200 |
| Subject | Re: [PATCH] dmaengine: zxdma: fix memset that is currently doing nothing |
| Message-ID | <qhIfo-6C3-21@gated-at.bofh.it> |
| In reply to | #1242614 |
On Thu, Oct 08, 2015 at 06:01:34PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The size and value arguments are swapped in the call to memset
> effectively making it a no-op because of the zero size. Swap
> these arguments around to do the memset correctly.
Sorry you are late! You should always sync to target tree before generating
a patch
commit 1a492ac2b87b05c8a175478e79d3c74511c74921
Author: Vinod Koul <vinod.koul@intel.com>
Date: Thu Oct 1 07:11:48 2015 +0530
dmaengine: zxdma: fix memset call
Fix the call to memset in this driver
[linux-4.2-next-20150911/drivers/dma/zx296702_dma.c:444]: (warning)
memset() called to fill 0 bytes of 'ds'.
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web